Re: [PATCH v4 19/23] kprobes: Remove kretprobe hash

2020-08-28 Thread Masami Hiramatsu
On Fri, 28 Aug 2020 22:29:12 +0200 Peter Zijlstra wrote: > On Fri, Aug 28, 2020 at 07:32:11PM +, eddy...@trendmicro.com wrote: > > > > > -Original Message- > > > From: Masami Hiramatsu > > > > > > @@ -1311,24 +1257,23 @@ void kprobe_busy_end(void) > > > void

Re: [PATCH v4 19/23] kprobes: Remove kretprobe hash

2020-08-28 Thread Peter Zijlstra
On Fri, Aug 28, 2020 at 07:32:11PM +, eddy...@trendmicro.com wrote: > > > -Original Message- > > From: Masami Hiramatsu > > > > @@ -1311,24 +1257,23 @@ void kprobe_busy_end(void) > > void kprobe_flush_task(struct task_struct *tk) > > { > > struct kretprobe_instance *ri; > >

RE: [PATCH v4 19/23] kprobes: Remove kretprobe hash

2020-08-28 Thread eddy...@trendmicro.com
> -Original Message- > From: Masami Hiramatsu > > @@ -1311,24 +1257,23 @@ void kprobe_busy_end(void) > void kprobe_flush_task(struct task_struct *tk) > { > struct kretprobe_instance *ri; > - struct hlist_head *head; > - struct hlist_node *tmp; > - unsigned

Re: [PATCH v4 19/23] kprobes: Remove kretprobe hash

2020-08-28 Thread peterz
On Sat, Aug 29, 2020 at 03:37:26AM +0900, Masami Hiramatsu wrote: > cd /sys/kernel/debug/tracing/ > > echo r:schedule schedule >> kprobe_events > echo 1 > events/kprobes/enable > > sleep 333 Thanks! that does indeed trigger it reliably. Let me go have dinner and then I'll try and figure out

Re: [PATCH v4 19/23] kprobes: Remove kretprobe hash

2020-08-28 Thread Masami Hiramatsu
On Fri, 28 Aug 2020 21:30:06 +0900 Masami Hiramatsu wrote: > From: Peter Zijlstra > > The kretprobe hash is mostly superfluous, replace it with a per-task > variable. > > This gets rid of the task hash and it's related locking. > > The whole invalidate_rp_inst() is tedious and could go away

[PATCH v4 19/23] kprobes: Remove kretprobe hash

2020-08-28 Thread Masami Hiramatsu
From: Peter Zijlstra The kretprobe hash is mostly superfluous, replace it with a per-task variable. This gets rid of the task hash and it's related locking. The whole invalidate_rp_inst() is tedious and could go away once we drop rp specific ri size. Signed-off-by: Peter Zijlstra (Intel) ---