Re: [PATCH v4 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth

2018-03-18 Thread Rob Herring
On Thu, Mar 15, 2018 at 02:46:45PM +0100, Sebastian Reichel wrote: > Hi Thierry, > > On Thu, Mar 15, 2018 at 12:07:44PM +0100, Thierry Escande wrote: > > > > BT_DISABLE_N is the name of this pin in the datasheet of the QCA chip, > > > > not on the board, so this name is the same regardless of what

Re: [PATCH v4 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth

2018-03-15 Thread Marcel Holtmann
Hi Sebastian, BT_DISABLE_N is the name of this pin in the datasheet of the QCA chip, not on the board, so this name is the same regardless of what you name the line or gpio your board connect it to. >>> >>> and QCA chip v1 and QCA chip v2 will use the same driver and >>> same firmw

Re: [PATCH v4 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth

2018-03-15 Thread Sebastian Reichel
Hi Thierry, On Thu, Mar 15, 2018 at 12:07:44PM +0100, Thierry Escande wrote: > > > BT_DISABLE_N is the name of this pin in the datasheet of the QCA chip, > > > not on the board, so this name is the same regardless of what you name > > > the line or gpio your board connect it to. > > > > and QCA c

Re: [PATCH v4 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth

2018-03-15 Thread Thierry Escande
Hi Marcel, On 14/03/2018 20:51, Marcel Holtmann wrote: Hi Bjorn, + bt-disable-n-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>; can we use a common name here. I think that Nokia and Broadcom drivers define one. And if this is the enable/shutdown GPIO, we should name it consistentl

Re: [PATCH v4 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth

2018-03-14 Thread Marcel Holtmann
Hi Bjorn, > + bt-disable-n-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>; can we use a common name here. I think that Nokia and Broadcom drivers define one. And if this is the enable/shutdown GPIO, we should name it consistently across all manufacturers. It essential

Re: [PATCH v4 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth

2018-03-14 Thread Bjorn Andersson
On Wed 14 Mar 11:42 PDT 2018, Marcel Holtmann wrote: > Hi Bjoern, > > >>> + bt-disable-n-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>; > >> > >> can we use a common name here. I think that Nokia and Broadcom drivers > >> define one. And if this is the enable/shutdown GPIO, we should name

Re: [PATCH v4 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth

2018-03-14 Thread Marcel Holtmann
Hi Bjoern, >>> + bt-disable-n-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>; >> >> can we use a common name here. I think that Nokia and Broadcom drivers >> define one. And if this is the enable/shutdown GPIO, we should name it >> consistently across all manufacturers. It essentially does

Re: [PATCH v4 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth

2018-03-14 Thread Bjorn Andersson
On Wed 14 Mar 09:13 PDT 2018, Marcel Holtmann wrote: > > + bt-disable-n-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>; > > can we use a common name here. I think that Nokia and Broadcom drivers > define one. And if this is the enable/shutdown GPIO, we should name it > consistently across a

Re: [PATCH v4 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth

2018-03-14 Thread Marcel Holtmann
Hi Thierry, > Add binding document for serial bluetooth chips using Qualcomm protocol. > > Signed-off-by: Thierry Escande > --- > > v4: > - Move bt-disable-n-gpios to required properties section > - Add clocks and pinctrl-0 as required properties > > v3: no change > v2: no change > > .../devi

[PATCH v4 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth

2018-03-14 Thread Thierry Escande
Add binding document for serial bluetooth chips using Qualcomm protocol. Signed-off-by: Thierry Escande --- v4: - Move bt-disable-n-gpios to required properties section - Add clocks and pinctrl-0 as required properties v3: no change v2: no change .../devicetree/bindings/net/qualcomm-bluetooth