Re: [PATCH v4 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks

2021-01-13 Thread Mark Brown
On Wed, Jan 13, 2021 at 09:00:19AM +0900, Kuninori Morimoto wrote: > Ahh, sorry for my unclear comment. > I think "PLL settings" is very board/platform specific, > so, adding such code to common driver will be issue in the future. > This is the reason why I don't want add it to audio-graph-card.

Re: [PATCH v4 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks

2021-01-12 Thread Kuninori Morimoto
Hi Richard > > As I mentioned in v3, adding *general* pll to common card driver is > > maybe difficult. > > You did say that. But you did not say why. > Can you be more specific about what problem you see with adding it > to the generic driver? > > > Using your own customized audio-graph-card

Re: [PATCH v4 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks

2021-01-12 Thread Richard Fitzgerald
On 12/01/2021 01:35, Kuninori Morimoto wrote: Hi Richard Some codecs need plls and/or sysclks to be configured using the snd_soc_component_set_[sysclk|pll] functions. These drivers cannot necessarily be converted to use the clock framework. If the codec is on a I2C/SPI bus, a nested clk_get wo

Re: [PATCH v4 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks

2021-01-11 Thread Kuninori Morimoto
Hi Richard > Some codecs need plls and/or sysclks to be configured using the > snd_soc_component_set_[sysclk|pll] functions. These drivers cannot > necessarily be converted to use the clock framework. If the codec is on > a I2C/SPI bus, a nested clk_get would be needed to enable the bus clock. >

[PATCH v4 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks

2021-01-08 Thread Richard Fitzgerald
Some codecs need plls and/or sysclks to be configured using the snd_soc_component_set_[sysclk|pll] functions. These drivers cannot necessarily be converted to use the clock framework. If the codec is on a I2C/SPI bus, a nested clk_get would be needed to enable the bus clock. But the clock framework