Re: [PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral assocation to DSTI

2016-09-12 Thread Maxime Ripard
On Thu, Sep 08, 2016 at 11:51:09AM +0200, Jorik Jonker wrote: > >>- put rts/cts in seperate pinmux sets for uart1 (2,3: see below) > >>- associate rx/tx for uart1-3 in H3 DTSI (this is the only option) > > > >I'm still a bit skeptical about this. This wouldn't be in any way > >consistant. I prefer

Re: [PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral assocation to DSTI

2016-09-08 Thread Jorik Jonker
On Thu, Sep 08, 2016 at 11:01:53AM +0200, Maxime Ripard wrote: On Thu, Sep 08, 2016 at 10:02:13AM +0200, Jorik Jonker wrote: So, I'm going for a v5, with these changes: - rename uart0_pins to uart0_pa_pins (as there could be a pf) - associate uart0_pa_pins with uart0 on all H3 board DTS files

Re: [PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral assocation to DSTI

2016-09-08 Thread Maxime Ripard
On Thu, Sep 08, 2016 at 10:02:13AM +0200, Jorik Jonker wrote: > Maxime, Chen-Yu: thanks for taking the effort to go through my patches > again! > > On Thu, Sep 08, 2016 at 08:23:17AM +0200, Maxime Ripard wrote: > >On Wed, Sep 07, 2016 at 09:58:57AM +0200, jo...@kippendief.biz wrote: > >>From: Jori

Re: [PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral assocation to DSTI

2016-09-08 Thread Jorik Jonker
Maxime, Chen-Yu: thanks for taking the effort to go through my patches again! On Thu, Sep 08, 2016 at 08:23:17AM +0200, Maxime Ripard wrote: On Wed, Sep 07, 2016 at 09:58:57AM +0200, jo...@kippendief.biz wrote: From: Jorik Jonker Users using this UART without RTS/CTS should override the asso

Re: [PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral assocation to DSTI

2016-09-07 Thread Maxime Ripard
On Wed, Sep 07, 2016 at 09:58:57AM +0200, jo...@kippendief.biz wrote: > From: Jorik Jonker > > Users using this UART without RTS/CTS should override the association in > their board specific DTS. All (1) board using this UART uses RTS/CTS, so > this breaks nothing. Using RTS / CTS is very rare a

Re: [PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral assocation to DSTI

2016-09-07 Thread Chen-Yu Tsai
On Wed, Sep 7, 2016 at 3:58 PM, wrote: > From: Jorik Jonker > > Users using this UART without RTS/CTS should override the association in > their board specific DTS. All (1) board using this UART uses RTS/CTS, so > this breaks nothing. I'd prefer we only do this for peripherals that have absolut

[PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral assocation to DSTI

2016-09-07 Thread jorik
From: Jorik Jonker Users using this UART without RTS/CTS should override the association in their board specific DTS. All (1) board using this UART uses RTS/CTS, so this breaks nothing. Signed-off-by: Jorik Jonker --- arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 2 -- arch/arm/boot/dts/su