Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

Hi Wucheng, On Tue, 2016-02-23 at 13:46 +0800, Wu-Cheng Li (李務誠) wrote: > On Thu, Feb 4, 2016 at 7:35 PM, Tiffany Lin wrote: > > From: Andrew-CT Chen > > > > Add v4l2 layer encoder driver for MT8173 > > > > Signed-off-by: Tiffany Lin

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

Hi Wucheng, On Tue, 2016-02-23 at 13:46 +0800, Wu-Cheng Li (李務誠) wrote: > On Thu, Feb 4, 2016 at 7:35 PM, Tiffany Lin wrote: > > From: Andrew-CT Chen > > > > Add v4l2 layer encoder driver for MT8173 > > > > Signed-off-by: Tiffany Lin > > --- > > drivers/media/platform/Kconfig

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On Thu, Feb 4, 2016 at 7:35 PM, Tiffany Lin wrote: > From: Andrew-CT Chen > > Add v4l2 layer encoder driver for MT8173 > > Signed-off-by: Tiffany Lin > --- > drivers/media/platform/Kconfig |

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On Thu, Feb 4, 2016 at 7:35 PM, Tiffany Lin wrote: > From: Andrew-CT Chen > > Add v4l2 layer encoder driver for MT8173 > > Signed-off-by: Tiffany Lin > --- > drivers/media/platform/Kconfig | 11 + > drivers/media/platform/Makefile|2 + >

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

Hi Hans, On Sat, 2016-02-20 at 10:18 +0100, Hans Verkuil wrote: > On 02/20/2016 10:11 AM, tiffany lin wrote: > > Hi Hans, > > > > On Tue, 2016-02-16 at 08:44 +0100, Hans Verkuil wrote: > >> On 02/16/2016 07:37 AM, tiffany lin wrote: > > + > > +const struct v4l2_ioctl_ops

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

Hi Hans, On Sat, 2016-02-20 at 10:18 +0100, Hans Verkuil wrote: > On 02/20/2016 10:11 AM, tiffany lin wrote: > > Hi Hans, > > > > On Tue, 2016-02-16 at 08:44 +0100, Hans Verkuil wrote: > >> On 02/16/2016 07:37 AM, tiffany lin wrote: > > + > > +const struct v4l2_ioctl_ops

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On 02/20/2016 10:11 AM, tiffany lin wrote: > Hi Hans, > > On Tue, 2016-02-16 at 08:44 +0100, Hans Verkuil wrote: >> On 02/16/2016 07:37 AM, tiffany lin wrote: > + > +const struct v4l2_ioctl_ops mtk_venc_ioctl_ops = { > + .vidioc_streamon= v4l2_m2m_ioctl_streamon, >

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On 02/20/2016 10:11 AM, tiffany lin wrote: > Hi Hans, > > On Tue, 2016-02-16 at 08:44 +0100, Hans Verkuil wrote: >> On 02/16/2016 07:37 AM, tiffany lin wrote: > + > +const struct v4l2_ioctl_ops mtk_venc_ioctl_ops = { > + .vidioc_streamon= v4l2_m2m_ioctl_streamon, >

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

Hi Hans, On Tue, 2016-02-16 at 08:44 +0100, Hans Verkuil wrote: > On 02/16/2016 07:37 AM, tiffany lin wrote: > >>> + > >>> +const struct v4l2_ioctl_ops mtk_venc_ioctl_ops = { > >>> + .vidioc_streamon= v4l2_m2m_ioctl_streamon, > >>> + .vidioc_streamoff =

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

Hi Hans, On Tue, 2016-02-16 at 08:44 +0100, Hans Verkuil wrote: > On 02/16/2016 07:37 AM, tiffany lin wrote: > >>> + > >>> +const struct v4l2_ioctl_ops mtk_venc_ioctl_ops = { > >>> + .vidioc_streamon= v4l2_m2m_ioctl_streamon, > >>> + .vidioc_streamoff =

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On Wed, 2016-02-17 at 09:31 +0100, Hans Verkuil wrote: > On 02/17/16 09:01, tiffany lin wrote: > > On Tue, 2016-02-16 at 14:48 +0100, Hans Verkuil wrote: > >> Hi Tiffany, > >> > >>> +int mtk_vcodec_enc_queue_init(void *priv, struct vb2_queue *src_vq, > >>> +struct

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On Wed, 2016-02-17 at 09:31 +0100, Hans Verkuil wrote: > On 02/17/16 09:01, tiffany lin wrote: > > On Tue, 2016-02-16 at 14:48 +0100, Hans Verkuil wrote: > >> Hi Tiffany, > >> > >>> +int mtk_vcodec_enc_queue_init(void *priv, struct vb2_queue *src_vq, > >>> +struct

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

Hi Hans, On Wed, 2016-02-17 at 08:47 +0100, Hans Verkuil wrote: > On 02/16/2016 07:37 AM, tiffany lin wrote: > >>> +static int fops_vcodec_open(struct file *file) > >>> +{ > >>> + struct video_device *vfd = video_devdata(file); > >>> + struct mtk_vcodec_dev *dev = video_drvdata(file); > >>> +

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

Hi Hans, On Wed, 2016-02-17 at 08:47 +0100, Hans Verkuil wrote: > On 02/16/2016 07:37 AM, tiffany lin wrote: > >>> +static int fops_vcodec_open(struct file *file) > >>> +{ > >>> + struct video_device *vfd = video_devdata(file); > >>> + struct mtk_vcodec_dev *dev = video_drvdata(file); > >>> +

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On 02/17/16 09:01, tiffany lin wrote: > On Tue, 2016-02-16 at 14:48 +0100, Hans Verkuil wrote: >> Hi Tiffany, >> >>> +int mtk_vcodec_enc_queue_init(void *priv, struct vb2_queue *src_vq, >>> + struct vb2_queue *dst_vq) >>> +{ >>> + struct

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On 02/17/16 09:01, tiffany lin wrote: > On Tue, 2016-02-16 at 14:48 +0100, Hans Verkuil wrote: >> Hi Tiffany, >> >>> +int mtk_vcodec_enc_queue_init(void *priv, struct vb2_queue *src_vq, >>> + struct vb2_queue *dst_vq) >>> +{ >>> + struct

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On Tue, 2016-02-16 at 14:48 +0100, Hans Verkuil wrote: > Hi Tiffany, > > > +int mtk_vcodec_enc_queue_init(void *priv, struct vb2_queue *src_vq, > > + struct vb2_queue *dst_vq) > > +{ > > + struct mtk_vcodec_ctx *ctx = priv; > > + int ret; >

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On Tue, 2016-02-16 at 14:48 +0100, Hans Verkuil wrote: > Hi Tiffany, > > > +int mtk_vcodec_enc_queue_init(void *priv, struct vb2_queue *src_vq, > > + struct vb2_queue *dst_vq) > > +{ > > + struct mtk_vcodec_ctx *ctx = priv; > > + int ret; >

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On 02/16/2016 07:37 AM, tiffany lin wrote: >>> +static int fops_vcodec_open(struct file *file) >>> +{ >>> + struct video_device *vfd = video_devdata(file); >>> + struct mtk_vcodec_dev *dev = video_drvdata(file); >>> + struct mtk_vcodec_ctx *ctx = NULL; >>> + int ret = 0; >>> + >>> +

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On 02/16/2016 07:37 AM, tiffany lin wrote: >>> +static int fops_vcodec_open(struct file *file) >>> +{ >>> + struct video_device *vfd = video_devdata(file); >>> + struct mtk_vcodec_dev *dev = video_drvdata(file); >>> + struct mtk_vcodec_ctx *ctx = NULL; >>> + int ret = 0; >>> + >>> +

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

Hi Tiffany, > +int mtk_vcodec_enc_queue_init(void *priv, struct vb2_queue *src_vq, > +struct vb2_queue *dst_vq) > +{ > + struct mtk_vcodec_ctx *ctx = priv; > + int ret; > + > + src_vq->type= V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE; > +

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

Hi Tiffany, > +int mtk_vcodec_enc_queue_init(void *priv, struct vb2_queue *src_vq, > +struct vb2_queue *dst_vq) > +{ > + struct mtk_vcodec_ctx *ctx = priv; > + int ret; > + > + src_vq->type= V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE; > +

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On Tue, 2016-02-16 at 08:44 +0100, Hans Verkuil wrote: > On 02/16/2016 07:37 AM, tiffany lin wrote: > > > > >>> +static int vidioc_venc_s_parm(struct file *file, void *priv, > >>> + struct v4l2_streamparm *a) > >>> +{ > >>> + struct mtk_vcodec_ctx *ctx = fh_to_ctx(priv); >

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On Tue, 2016-02-16 at 08:44 +0100, Hans Verkuil wrote: > On 02/16/2016 07:37 AM, tiffany lin wrote: > > > > >>> +static int vidioc_venc_s_parm(struct file *file, void *priv, > >>> + struct v4l2_streamparm *a) > >>> +{ > >>> + struct mtk_vcodec_ctx *ctx = fh_to_ctx(priv); >

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On 02/16/2016 07:37 AM, tiffany lin wrote: >>> +static int vidioc_venc_s_parm(struct file *file, void *priv, >>> + struct v4l2_streamparm *a) >>> +{ >>> + struct mtk_vcodec_ctx *ctx = fh_to_ctx(priv); >>> + >>> + if (a->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On 02/16/2016 07:37 AM, tiffany lin wrote: >>> +static int vidioc_venc_s_parm(struct file *file, void *priv, >>> + struct v4l2_streamparm *a) >>> +{ >>> + struct mtk_vcodec_ctx *ctx = fh_to_ctx(priv); >>> + >>> + if (a->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

Hi Hans, Thanks for your time. On Mon, 2016-02-15 at 12:21 +0100, Hans Verkuil wrote: > On 02/04/2016 12:35 PM, Tiffany Lin wrote: > > From: Andrew-CT Chen > > > > Add v4l2 layer encoder driver for MT8173 > > > > Signed-off-by: Tiffany Lin

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

Hi Hans, Thanks for your time. On Mon, 2016-02-15 at 12:21 +0100, Hans Verkuil wrote: > On 02/04/2016 12:35 PM, Tiffany Lin wrote: > > From: Andrew-CT Chen > > > > Add v4l2 layer encoder driver for MT8173 > > > > Signed-off-by: Tiffany Lin > > If Andrew is the author, shouldn't there be a

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On 02/04/2016 12:35 PM, Tiffany Lin wrote: > From: Andrew-CT Chen > > Add v4l2 layer encoder driver for MT8173 > > Signed-off-by: Tiffany Lin If Andrew is the author, shouldn't there be a Signed-off-by from him as well? And in copyright

Re: [PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

On 02/04/2016 12:35 PM, Tiffany Lin wrote: > From: Andrew-CT Chen > > Add v4l2 layer encoder driver for MT8173 > > Signed-off-by: Tiffany Lin If Andrew is the author, shouldn't there be a Signed-off-by from him as well? And in copyright notices (might want to update the year to 2016 BTW) PC

[PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

From: Andrew-CT Chen Add v4l2 layer encoder driver for MT8173 Signed-off-by: Tiffany Lin --- drivers/media/platform/Kconfig | 11 + drivers/media/platform/Makefile|2 + drivers/media/platform/mtk-vcodec/Makefile |8 +

[PATCH v4 5/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

From: Andrew-CT Chen Add v4l2 layer encoder driver for MT8173 Signed-off-by: Tiffany Lin --- drivers/media/platform/Kconfig | 11 + drivers/media/platform/Makefile|2 +