Re: [PATCH v5] soc: qcom: Add SoC info driver

2016-12-12 Thread Bjorn Andersson
On Mon 12 Dec 07:14 PST 2016, Imran Khan wrote: > On 12/5/2016 11:35 PM, Bjorn Andersson wrote: [..] > > > > Rather than having this based on two huge macros take a look at > > DEVICE_INT_ATTR() and struct dev_ext_attribute in > > include/linux/device.h. It looks like if you just put the index in

Re: [PATCH v5] soc: qcom: Add SoC info driver

2016-12-12 Thread Imran Khan
On 12/5/2016 11:35 PM, Bjorn Andersson wrote: > On Wed 16 Nov 05:22 PST 2016, Imran Khan wrote: > >> >> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c >> new file mode 100644 >> index 000..eca46df >> --- /dev/null >> +++ b/drivers/soc/qcom/socinfo.c >> @@ -0,0 +1,989 @

Re: [PATCH v5] soc: qcom: Add SoC info driver

2016-12-05 Thread Bjorn Andersson
On Wed 16 Nov 05:22 PST 2016, Imran Khan wrote: > The SoC info driver provides information such as Chip ID, > Chip family, serial number and other such details about > Qualcomm SoCs. > > Signed-off-by: Imran Khan > --- > v4 --> v5: > - Removed redundant function socinfo_print > > v3 --> v4: >

[PATCH v5] soc: qcom: Add SoC info driver

2016-11-16 Thread Imran Khan
The SoC info driver provides information such as Chip ID, Chip family, serial number and other such details about Qualcomm SoCs. Signed-off-by: Imran Khan --- v4 --> v5: - Removed redundant function socinfo_print v3 --> v4: - Corrected makefile so that smem and socinfo are treated as one modul