Re: [PATCH v5 0/2] Small devm helper for devm implementations

2020-07-23 Thread Greg Kroah-Hartman
On Tue, Jul 21, 2020 at 09:10:23AM +0200, Marc Gonzalez wrote: > On 06/07/2020 21:57, Greg Kroah-Hartman wrote: > > > Given the lack of testing of the patch, it doesn't seem wise to add > > this, right? > > You're probably not wrong :) > > > Please get some testing, and some more users, and I'll

Re: [PATCH v5 0/2] Small devm helper for devm implementations

2020-07-21 Thread Marc Gonzalez
On 06/07/2020 21:57, Greg Kroah-Hartman wrote: > Given the lack of testing of the patch, it doesn't seem wise to add > this, right? You're probably not wrong :) > Please get some testing, and some more users, and I'll be glad to > consider it. "Users" == files modified to use the new helper? H

Re: [PATCH v5 0/2] Small devm helper for devm implementations

2020-07-06 Thread Greg Kroah-Hartman
On Mon, Jul 06, 2020 at 05:56:04PM +0200, Marc Gonzalez wrote: > Hello Greg, > > Would you agree to take this series? Given the lack of testing of the patch, it doesn't seem wise to add this, right? Please get some testing, and some more users, and I'll be glad to consider it. thanks, greg k-h

Re: [PATCH v5 0/2] Small devm helper for devm implementations

2020-07-06 Thread Marc Gonzalez
Hello Greg, Would you agree to take this series? Regards. On 18/06/2020 13:38, Marc Gonzalez wrote: > Hello everyone, > > In my opinion, the small and simple devm_add() helper > (and its cousin, devm_vadd) can help make devm code > slightly easier to write and maintain. > > Would anyone care

Re: [PATCH v5 0/2] Small devm helper for devm implementations

2020-06-18 Thread Marc Gonzalez
Hello everyone, In my opinion, the small and simple devm_add() helper (and its cousin, devm_vadd) can help make devm code slightly easier to write and maintain. Would anyone care to agree or disagree? :-) Regards. On 10/03/2020 11:11, Marc Gonzalez wrote: > Differences from v4 to v5 > x Fix t

Re: [PATCH v5 0/2] Small devm helper for devm implementations

2020-06-04 Thread Greg Kroah-Hartman
On Thu, Jun 04, 2020 at 06:13:21PM +0200, Marc Gonzalez wrote: > Looks like this series has fallen through the cracks :( > Greg, you would be taking the drivers/base/devres.c changes? > As mentioned in patch 2, "This patch needs testing on a platform with many > clocks." > (I've only tested using

Re: [PATCH v5 0/2] Small devm helper for devm implementations

2020-06-04 Thread Marc Gonzalez
Looks like this series has fallen through the cracks :( Greg, you would be taking the drivers/base/devres.c changes? As mentioned in patch 2, "This patch needs testing on a platform with many clocks." (I've only tested using a trivial kernel module) On 10/03/2020 11:11, Marc Gonzalez wrote: > Di