Re: [PATCH v5 15/15] tracing: Update subbuffer with kilobytes not page order

2023-12-20 Thread Steven Rostedt
On Thu, 21 Dec 2023 09:26:21 +0900 Masami Hiramatsu (Google) wrote: > > If the user specifies 3 via: > > > > echo 3 > buffer_subbuf_size_kb > > > > Then the sub-buffer size will round up to 4kb (on a 4kb page size system). > > > > If they specify: > > > > echo 6 > buffer_subbuf_size_kb >

Re: [PATCH v5 15/15] tracing: Update subbuffer with kilobytes not page order

2023-12-20 Thread Google
On Tue, 19 Dec 2023 13:54:29 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > Using page order for deciding what the size of the ring buffer sub buffers > are is exposing a bit too much of the implementation. Although the sub > buffers are only allocated in orders of pages, all

[PATCH v5 15/15] tracing: Update subbuffer with kilobytes not page order

2023-12-19 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Using page order for deciding what the size of the ring buffer sub buffers are is exposing a bit too much of the implementation. Although the sub buffers are only allocated in orders of pages, allow the user to specify the minimum size of each sub-buffer via kiloby