Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-19 Thread Alexey Budankov
Hi, On 19.07.2017 8:48, Alexander Shishkin wrote: > Alexey Budankov writes: > >> On 18.07.2017 19:55, Alexander Shishkin wrote: >>> Alexey Budankov writes: >>> I see. Do you personally have some more issues that needs to be addressed? My intention is that this patch v5 4/4 addresses a

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexander Shishkin
Alexey Budankov writes: > On 18.07.2017 19:55, Alexander Shishkin wrote: >> Alexey Budankov writes: >> >>> I see. Do you personally have some more issues that needs to be addressed? >>> My intention is that this patch v5 4/4 addresses all your comments raised >>> in >>> the previous reviews.

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexey Budankov
On 18.07.2017 19:55, Alexander Shishkin wrote: > Alexey Budankov writes: > >> I see. Do you personally have some more issues that needs to be addressed? >> My intention is that this patch v5 4/4 addresses all your comments raised in >> the previous reviews. > > I don't know yet, I haven't start

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexander Shishkin
Alexey Budankov writes: > I see. Do you personally have some more issues that needs to be addressed? > My intention is that this patch v5 4/4 addresses all your comments raised in > the previous reviews. I don't know yet, I haven't started on the actual content of the patchset, it being hard to

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexey Budankov
On 18.07.2017 18:23, Alexander Shishkin wrote: > Alexey Budankov writes: > >>> You probably also want to explain this change, for example change the >>> @group_list description, saying that something else links into it now. >>> >> >> The whole patch as a single commit, attached to patch v5 4/4, m

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexey Budankov
Hi, On 18.07.2017 18:08, Alexander Shishkin wrote: > Alexey Budankov writes: > >> Ok. I see. So what are the next steps needs to be taken towards the upstream >> of this work? >> What do I need to do more to have this stuff included into the kernel? >> Could you please clarify this? > > Well,

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexander Shishkin
Alexey Budankov writes: >> You probably also want to explain this change, for example change the >> @group_list description, saying that something else links into it now. >> > > The whole patch as a single commit, attached to patch v5 4/4, may provide > the complete view of suggested changes. N

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexander Shishkin
Alexey Budankov writes: > Ok. I see. So what are the next steps needs to be taken towards the upstream > of this work? > What do I need to do more to have this stuff included into the kernel? > Could you please clarify this? Well, normally you'd be sending new versions of your patchset until th

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexey Budankov
Hi, On 18.07.2017 17:01, Alexander Shishkin wrote: > Alexey Budankov writes: > >>> Apparently the patches are not threaded, so one needs to fish them out >>> one by one in order to review. >> >> Thanks for feedback. The BKM in this case is just to keep subject unchanged, >> right? > > No, just

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexander Shishkin
Alexey Budankov writes: >> Apparently the patches are not threaded, so one needs to fish them out >> one by one in order to review. > > Thanks for feedback. The BKM in this case is just to keep subject unchanged, > right? No, just use git-send-email, it will set all the email headers correctly

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexey Budankov
Hi, On 18.07.2017 15:40, Alexander Shishkin wrote: > Alexey Budankov writes: > >> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h >> index 7b2cddf..8e1967f 100644 >> --- a/include/linux/perf_event.h >> +++ b/include/linux/perf_event.h >> @@ -603,13 +603,6 @@ struct perf_even

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexey Budankov
Hi, On 18.07.2017 14:33, Alexander Shishkin wrote: > Alexey Budankov writes: > >> Hi, > > Hi, > >> Are there any new comments so far? Could you please suggest further steps >> forward? > > Apparently the patches are not threaded, so one needs to fish them out > one by one in order to review.

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexander Shishkin
Alexey Budankov writes: > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index 7b2cddf..8e1967f 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -603,13 +603,6 @@ struct perf_event { >*/ > struct list_headgroup

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexander Shishkin
Alexander Shishkin writes: > Alexey Budankov writes: > >> Are there any new comments so far? Could you please suggest further steps >> forward? > > Apparently the patches are not threaded, so one needs to fish them out > one by one in order to review. And I can't seem to find the cover letter

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexander Shishkin
Alexey Budankov writes: > Hi, Hi, > Are there any new comments so far? Could you please suggest further steps > forward? Apparently the patches are not threaded, so one needs to fish them out one by one in order to review. > On 10.07.2017 16:03, Alexey Budankov wrote: >> perf/core: complete

Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-18 Thread Alexey Budankov
Hi, Are there any new comments so far? Could you please suggest further steps forward? Thanks, Alexey On 10.07.2017 16:03, Alexey Budankov wrote: > perf/core: complete replace of lists by rb trees for pinned and >flexible groups at perf_event_context > > By default, the userspace

[PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

2017-07-10 Thread Alexey Budankov
perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context By default, the userspace perf tool opens per-cpu task-bound events when sampling, so for N logical events requested by the user, the tool will open N * NR_CPUS events. In the kernel,