Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-29 Thread Dan Williams
On Mon, Oct 29, 2018 at 11:29 PM Michal Hocko wrote: > > On Mon 29-10-18 12:59:11, Alexander Duyck wrote: > > On Mon, 2018-10-29 at 19:18 +0100, Michal Hocko wrote: [..] > > The patches Andrew pushed addressed the immediate issue so that now > > systems with nvdimm/DAX memory can at least initiali

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-11 Thread Alexander Duyck
On 10/11/2018 1:39 AM, Yi Zhang wrote: On 2018-10-10 at 11:18:49 -0700, Dan Williams wrote: On Wed, Oct 10, 2018 at 10:30 AM Michal Hocko wrote: On Wed 10-10-18 09:39:08, Alexander Duyck wrote: On 10/10/2018 2:58 AM, Michal Hocko wrote: On Tue 09-10-18 13:26:41, Alexander Duyck wrote: [...]

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-11 Thread Michal Hocko
On Wed 10-10-18 20:52:42, Michal Hocko wrote: [...] > My recollection was that we do clear the reserved bit in > move_pfn_range_to_zone and we indeed do in __init_single_page. But then > we set the bit back right afterwards. This seems to be the case since > d0dc12e86b319 which reorganized the code

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-10 Thread Alexander Duyck
On 10/10/2018 2:58 AM, Michal Hocko wrote: On Tue 09-10-18 13:26:41, Alexander Duyck wrote: [...] I would think with that being the case we still probably need the call to __SetPageReserved to set the bit with the expectation that it will not be cleared for device-pages since the pages are not o

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-09 Thread Dan Williams
On Tue, Oct 9, 2018 at 1:34 PM Alexander Duyck wrote: > > On 10/9/2018 11:04 AM, Dan Williams wrote: > > On Tue, Oct 9, 2018 at 3:21 AM Yi Zhang wrote: [..] > > That comment is incorrect, device-pages are never onlined. So I think > > we can just skip that call to __SetPageReserved() unless the m

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-09-27 Thread David Hildenbrand
On 27/09/2018 16:50, Oscar Salvador wrote: > On Thu, Sep 27, 2018 at 03:13:29PM +0200, Michal Hocko wrote: >> On Thu 27-09-18 14:25:37, Oscar Salvador wrote: >>> On Thu, Sep 27, 2018 at 01:09:26PM +0200, Michal Hocko wrote: > So there were a few things I wasn't sure we could pull outside of the

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-09-27 Thread Oscar Salvador
On Thu, Sep 27, 2018 at 03:13:29PM +0200, Michal Hocko wrote: > On Thu 27-09-18 14:25:37, Oscar Salvador wrote: > > On Thu, Sep 27, 2018 at 01:09:26PM +0200, Michal Hocko wrote: > > > > So there were a few things I wasn't sure we could pull outside of the > > > > hotplug lock. One specific example

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-09-27 Thread Michal Hocko
On Thu 27-09-18 14:25:37, Oscar Salvador wrote: > On Thu, Sep 27, 2018 at 01:09:26PM +0200, Michal Hocko wrote: > > > So there were a few things I wasn't sure we could pull outside of the > > > hotplug lock. One specific example is the bits related to resizing the > > > pgdat > > > and zone. I wan

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-09-27 Thread Oscar Salvador
On Wed, Sep 26, 2018 at 11:25:37AM -0700, Alexander Duyck wrote: > With that said I am open to suggestions if you still feel like I need to > follow this up with some additional work. I just want to avoid introducing > any regressions in regards to functionality or performance. Hi Alexander, the

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-09-27 Thread Oscar Salvador
On Thu, Sep 27, 2018 at 01:09:26PM +0200, Michal Hocko wrote: > > So there were a few things I wasn't sure we could pull outside of the > > hotplug lock. One specific example is the bits related to resizing the pgdat > > and zone. I wanted to avoid pulling those bits outside of the hotplug lock. >

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-09-27 Thread Michal Hocko
On Wed 26-09-18 11:52:56, Dan Williams wrote: [...] > Could we push the hotplug lock deeper to the places that actually need > it? What I found with my initial investigation is that we don't even > need the hotplug lock for the vmemmap initialization with this patch > [1]. Yes, the scope of the ho