Re: [PATCH v5 5/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver

2016-04-14 Thread Pavel Machek
> +#define CHARGER_DIR_NAME "CROS_USB_PD_CHARGER%d" > +#define CHARGER_DIR_NAME_LENGTH sizeof(CHARGER_DIR_NAME) > + > +#define MANUFACTURER_MODEL_LENGTH32 > + > +struct port_data { > + int port_number; > + char name[CHARGER_DIR_NAME_LENGTH]; That's not really

Re: [PATCH v5 5/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver

2016-04-14 Thread Pavel Machek
> +#define CHARGER_DIR_NAME "CROS_USB_PD_CHARGER%d" > +#define CHARGER_DIR_NAME_LENGTH sizeof(CHARGER_DIR_NAME) > + > +#define MANUFACTURER_MODEL_LENGTH32 > + > +struct port_data { > + int port_number; > + char name[CHARGER_DIR_NAME_LENGTH]; That's not really

[PATCH v5 5/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver

2016-03-14 Thread Tomeu Vizoso
From: Sameer Nanda This driver exposes the charger functionality in the PD EC to userspace. Signed-off-by: Tomeu Vizoso Cc: Sameer Nanda Cc: Benson Leung Cc: Shawn Nematbakhsh ---

[PATCH v5 5/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver

2016-03-14 Thread Tomeu Vizoso
From: Sameer Nanda This driver exposes the charger functionality in the PD EC to userspace. Signed-off-by: Tomeu Vizoso Cc: Sameer Nanda Cc: Benson Leung Cc: Shawn Nematbakhsh --- Changes in v5: - Fix type of variable passed to do_div. Changes in v4: - Declare size parameters in