Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-09-07 Thread Quentin Perret
On Thursday 06 Sep 2018 at 16:49:47 (-0700), Dietmar Eggemann wrote: > I would prefer a sched_feature. I guess it has to be disabled by default so > that other systems don't have to check rcu_dereference(rd->pd) in the wakeup > path. Right, this is what I had in mind too. I guess downstream

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-09-07 Thread Quentin Perret
On Thursday 06 Sep 2018 at 16:49:47 (-0700), Dietmar Eggemann wrote: > I would prefer a sched_feature. I guess it has to be disabled by default so > that other systems don't have to check rcu_dereference(rd->pd) in the wakeup > path. Right, this is what I had in mind too. I guess downstream

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-09-06 Thread Dietmar Eggemann
On 09/06/2018 02:29 AM, Quentin Perret wrote: Hi Dietmar, On Wednesday 05 Sep 2018 at 23:06:38 (-0700), Dietmar Eggemann wrote: On 08/20/2018 02:44 AM, Quentin Perret wrote: In order to ensure a minimal performance impact on non-energy-aware systems, introduce a static_key guarding the access

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-09-06 Thread Dietmar Eggemann
On 09/06/2018 02:29 AM, Quentin Perret wrote: Hi Dietmar, On Wednesday 05 Sep 2018 at 23:06:38 (-0700), Dietmar Eggemann wrote: On 08/20/2018 02:44 AM, Quentin Perret wrote: In order to ensure a minimal performance impact on non-energy-aware systems, introduce a static_key guarding the access

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-09-06 Thread Quentin Perret
Hi Dietmar, On Wednesday 05 Sep 2018 at 23:06:38 (-0700), Dietmar Eggemann wrote: > On 08/20/2018 02:44 AM, Quentin Perret wrote: > > In order to ensure a minimal performance impact on non-energy-aware > > systems, introduce a static_key guarding the access to Energy-Aware > > Scheduling (EAS)

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-09-06 Thread Quentin Perret
Hi Dietmar, On Wednesday 05 Sep 2018 at 23:06:38 (-0700), Dietmar Eggemann wrote: > On 08/20/2018 02:44 AM, Quentin Perret wrote: > > In order to ensure a minimal performance impact on non-energy-aware > > systems, introduce a static_key guarding the access to Energy-Aware > > Scheduling (EAS)

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-09-06 Thread Dietmar Eggemann
On 08/20/2018 02:44 AM, Quentin Perret wrote: In order to ensure a minimal performance impact on non-energy-aware systems, introduce a static_key guarding the access to Energy-Aware Scheduling (EAS) code. The static key is set iff all the following conditions are met for at least one root

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-09-06 Thread Dietmar Eggemann
On 08/20/2018 02:44 AM, Quentin Perret wrote: In order to ensure a minimal performance impact on non-energy-aware systems, introduce a static_key guarding the access to Energy-Aware Scheduling (EAS) code. The static key is set iff all the following conditions are met for at least one root

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-08-30 Thread Patrick Bellasi
On 30-Aug 10:57, Quentin Perret wrote: > Hi Patrick, > > On Thursday 30 Aug 2018 at 10:23:29 (+0100), Patrick Bellasi wrote: > > Yes, dunno if it's just me but perhaps a bit of rephrasing could help. > > Ok, so what about something a little bit more explicit like: > > /* > * The complexity of

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-08-30 Thread Patrick Bellasi
On 30-Aug 10:57, Quentin Perret wrote: > Hi Patrick, > > On Thursday 30 Aug 2018 at 10:23:29 (+0100), Patrick Bellasi wrote: > > Yes, dunno if it's just me but perhaps a bit of rephrasing could help. > > Ok, so what about something a little bit more explicit like: > > /* > * The complexity of

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-08-30 Thread Quentin Perret
Hi Patrick, On Thursday 30 Aug 2018 at 10:23:29 (+0100), Patrick Bellasi wrote: > Yes, dunno if it's just me but perhaps a bit of rephrasing could help. Ok, so what about something a little bit more explicit like: /* * The complexity of the Energy Model is defined as: * * C =

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-08-30 Thread Quentin Perret
Hi Patrick, On Thursday 30 Aug 2018 at 10:23:29 (+0100), Patrick Bellasi wrote: > Yes, dunno if it's just me but perhaps a bit of rephrasing could help. Ok, so what about something a little bit more explicit like: /* * The complexity of the Energy Model is defined as: * * C =

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-08-30 Thread Patrick Bellasi
On 29-Aug 18:20, Quentin Perret wrote: > On Wednesday 29 Aug 2018 at 17:50:58 (+0100), Patrick Bellasi wrote: > > > +/* > > > + * The complexity of the Energy Model is defined as: nr_pd * (nr_cpus + > > > nr_cs) > > > + * with: 'nr_pd' the number of performance domains; 'nr_cpus' the number > >

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-08-30 Thread Patrick Bellasi
On 29-Aug 18:20, Quentin Perret wrote: > On Wednesday 29 Aug 2018 at 17:50:58 (+0100), Patrick Bellasi wrote: > > > +/* > > > + * The complexity of the Energy Model is defined as: nr_pd * (nr_cpus + > > > nr_cs) > > > + * with: 'nr_pd' the number of performance domains; 'nr_cpus' the number > >

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-08-29 Thread Quentin Perret
On Wednesday 29 Aug 2018 at 17:50:58 (+0100), Patrick Bellasi wrote: > > +/* > > + * The complexity of the Energy Model is defined as: nr_pd * (nr_cpus + > > nr_cs) > > + * with: 'nr_pd' the number of performance domains; 'nr_cpus' the number of > > + * CPUs; and 'nr_cs' the sum of the capacity

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-08-29 Thread Quentin Perret
On Wednesday 29 Aug 2018 at 17:50:58 (+0100), Patrick Bellasi wrote: > > +/* > > + * The complexity of the Energy Model is defined as: nr_pd * (nr_cpus + > > nr_cs) > > + * with: 'nr_pd' the number of performance domains; 'nr_cpus' the number of > > + * CPUs; and 'nr_cs' the sum of the capacity

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-08-29 Thread Patrick Bellasi
Hi Quentin, a couple of minor notes/questions follow... Best, Patrick On 20-Aug 10:44, Quentin Perret wrote: > In order to ensure a minimal performance impact on non-energy-aware > systems, introduce a static_key guarding the access to Energy-Aware > Scheduling (EAS) code. > > The static key is

Re: [PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-08-29 Thread Patrick Bellasi
Hi Quentin, a couple of minor notes/questions follow... Best, Patrick On 20-Aug 10:44, Quentin Perret wrote: > In order to ensure a minimal performance impact on non-energy-aware > systems, introduce a static_key guarding the access to Energy-Aware > Scheduling (EAS) code. > > The static key is

[PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-08-20 Thread Quentin Perret
In order to ensure a minimal performance impact on non-energy-aware systems, introduce a static_key guarding the access to Energy-Aware Scheduling (EAS) code. The static key is set iff all the following conditions are met for at least one root domain: 1. all online CPUs of the root domain are

[PATCH v6 07/14] sched/topology: Introduce sched_energy_present static key

2018-08-20 Thread Quentin Perret
In order to ensure a minimal performance impact on non-energy-aware systems, introduce a static_key guarding the access to Energy-Aware Scheduling (EAS) code. The static key is set iff all the following conditions are met for at least one root domain: 1. all online CPUs of the root domain are