Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-30 Thread Jacek Anaszewski
On 12/01/2015 02:54 AM, Ingi Kim wrote: Hi Jacek, On 2015년 11월 30일 19:59, Jacek Anaszewski wrote: Hi Ingi, On 11/30/2015 03:31 AM, Ingi Kim wrote: Hi Jacek, On 2015년 11월 26일 18:43, Jacek Anaszewski wrote: Hi Ingi, On 11/26/2015 09:02 AM, Ingi Kim wrote: [...] +torch_unlock: +mutex_unl

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-30 Thread Ingi Kim
Hi Jacek, On 2015년 11월 30일 19:59, Jacek Anaszewski wrote: > Hi Ingi, > > On 11/30/2015 03:31 AM, Ingi Kim wrote: >> Hi Jacek, >> >> On 2015년 11월 26일 18:43, Jacek Anaszewski wrote: >>> Hi Ingi, >>> >>> On 11/26/2015 09:02 AM, Ingi Kim wrote: >>> [...] >> +torch_unlock: >> +mutex_unlock

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-30 Thread Jacek Anaszewski
Hi Ingi, On 11/30/2015 03:31 AM, Ingi Kim wrote: Hi Jacek, On 2015년 11월 26일 18:43, Jacek Anaszewski wrote: Hi Ingi, On 11/26/2015 09:02 AM, Ingi Kim wrote: [...] +torch_unlock: +mutex_unlock(&led->lock); +return ret; +} + +static int rt5033_led_flash_brightness_set(struct led_classde

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-29 Thread Ingi Kim
Hi, Lee Thanks to the review, I'll carry your Ack when I reflect Jacek's comment. On 2015년 11월 26일 18:11, Lee Jones wrote: > On Wed, 25 Nov 2015, Ingi Kim wrote: > >> This patch adds device driver of Richtek RT5033 PMIC. >> The RT5033 Flash LED Circuit is designed for one or two LEDs driving >>

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-29 Thread Ingi Kim
Hi Jacek, On 2015년 11월 26일 18:43, Jacek Anaszewski wrote: > Hi Ingi, > > On 11/26/2015 09:02 AM, Ingi Kim wrote: > [...] +torch_unlock: +mutex_unlock(&led->lock); +return ret; +} + +static int rt5033_led_flash_brightness_set(struct led_classdev_flash *f

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-26 Thread Jacek Anaszewski
Hi Ingi, On 11/26/2015 09:02 AM, Ingi Kim wrote: [...] +torch_unlock: +mutex_unlock(&led->lock); +return ret; +} + +static int rt5033_led_flash_brightness_set(struct led_classdev_flash *fled_cdev, + u32 brightness) +{ +struct rt5033_sub_led *sub_led = flcdev_to

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-26 Thread Lee Jones
On Thu, 26 Nov 2015, Ingi Kim wrote: > On 2015년 11월 26일 00:13, Jacek Anaszewski wrote: > > Hi Ingi, > > > > Thanks for the update. > > > > On 11/25/2015 11:22 AM, Ingi Kim wrote: > >> This patch adds device driver of Richtek RT5033 PMIC. > >> The RT5033 Flash LED Circuit is designed for one or tw

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-26 Thread Lee Jones
On Wed, 25 Nov 2015, Ingi Kim wrote: > This patch adds device driver of Richtek RT5033 PMIC. > The RT5033 Flash LED Circuit is designed for one or two LEDs driving > for torch and strobe applications, it provides an I2C software command > to trigger the torch and strobe operation. > > Each of LED

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-26 Thread Ingi Kim
Hi Jacek, Thanks for the review. On 2015년 11월 26일 00:13, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the update. > > On 11/25/2015 11:22 AM, Ingi Kim wrote: >> This patch adds device driver of Richtek RT5033 PMIC. >> The RT5033 Flash LED Circuit is designed for one or two LEDs driving >>

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-25 Thread Jacek Anaszewski
Hi Ingi, Thanks for the update. On 11/25/2015 11:22 AM, Ingi Kim wrote: This patch adds device driver of Richtek RT5033 PMIC. The RT5033 Flash LED Circuit is designed for one or two LEDs driving for torch and strobe applications, it provides an I2C software command to trigger the torch and stro

[PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-25 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The RT5033 Flash LED Circuit is designed for one or two LEDs driving for torch and strobe applications, it provides an I2C software command to trigger the torch and strobe operation. Each of LED outputs can contorl a separate LED sharing their