Re: [PATCH v6 31/57] pci: Remove dev_err() usage after platform_get_irq()

2019-08-10 Thread Linus Walleij
On Tue, Jul 30, 2019 at 8:19 PM Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. (...) > While we're here, remove b

Re: [PATCH v6 31/57] pci: Remove dev_err() usage after platform_get_irq()

2019-08-08 Thread Geert Uytterhoeven
Hi Stephen, On Tue, Jul 30, 2019 at 8:21 PM Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. > > // > @@ > express

Re: [PATCH v6 31/57] pci: Remove dev_err() usage after platform_get_irq()

2019-08-07 Thread Bjorn Helgaas
On Wed, Aug 07, 2019 at 04:09:10PM +0200, Marc Gonzalez wrote: > On 30/07/2019 23:56, Bjorn Helgaas wrote: > > >> diff --git a/drivers/pci/controller/pcie-tango.c > >> b/drivers/pci/controller/pcie-tango.c > >> index 21a208da3f59..b87aa9041480 100644 > >> --- a/drivers/pci/controller/pcie-tango.c

Re: [PATCH v6 31/57] pci: Remove dev_err() usage after platform_get_irq()

2019-08-07 Thread Marc Gonzalez
On 30/07/2019 23:56, Bjorn Helgaas wrote: >> diff --git a/drivers/pci/controller/pcie-tango.c >> b/drivers/pci/controller/pcie-tango.c >> index 21a208da3f59..b87aa9041480 100644 >> --- a/drivers/pci/controller/pcie-tango.c >> +++ b/drivers/pci/controller/pcie-tango.c >> @@ -273,10 +273,8 @@ stati

Re: [PATCH v6 31/57] pci: Remove dev_err() usage after platform_get_irq()

2019-07-30 Thread Bjorn Helgaas
[+cc Lorenzo, maintainer of native host bridge drivers] [+cc maintainers of drivers with additional questions below] Please run "git log --oneline drivers/pci/controller" and match the style, e.g., PCI: Remove dev_err() usage after platform_get_irq() On Tue, Jul 30, 2019 at 11:15:31AM -0700, S

[PATCH v6 31/57] pci: Remove dev_err() usage after platform_get_irq()

2019-07-30 Thread Stephen Boyd
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | plat