Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-07 Thread Steen Hegelund
On 04.12.2020 15:16, Alexandre Belloni wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On 03/12/2020 22:52:53+0100, Andrew Lunn wrote: > + if (macro->serdestype == SPX5_SDT_6G) { > + value = sdx5_rd(priv, SD6G_LANE_LANE_DF(macro->st

Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-04 Thread Alexandre Belloni
On 03/12/2020 22:52:53+0100, Andrew Lunn wrote: > > + if (macro->serdestype == SPX5_SDT_6G) { > > + value = sdx5_rd(priv, SD6G_LANE_LANE_DF(macro->stpidx)); > > + analog_sd = SD6G_LANE_LANE_DF_PMA2PCS_RXEI_FILTERED_GET(value); > > + } else if (macro->serdestype == SPX5_SDT_1

Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-04 Thread Russell King - ARM Linux admin
On Fri, Dec 04, 2020 at 02:48:26PM +0100, Steen Hegelund wrote: > On 03.12.2020 22:52, Andrew Lunn wrote: > > What i have not yet seen is how this code plugs together with > > phylink_pcs_ops? > > > > Can this hardware also be used for SATA, USB? As far as i understand, > > the Marvell Comphy is m

Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-04 Thread Steen Hegelund
On 03.12.2020 22:52, Russell King - ARM Linux admin wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Thu, Dec 03, 2020 at 10:52:53PM +0100, Andrew Lunn wrote: > +/* map from SD25G28 interface width to configuration value */ > +static u8 sd25g

Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-04 Thread Steen Hegelund
On 03.12.2020 22:52, Andrew Lunn wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe +/* map from SD25G28 interface width to configuration value */ +static u8 sd25g28_get_iw_setting(const u8 interface_width) +{ + switch (interface_width) { +

Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-04 Thread Russell King - ARM Linux admin
On Fri, Dec 04, 2020 at 08:56:33AM +0100, Alexandre Belloni wrote: > Hi Russell, > > On 03/12/2020 22:52:33+, Russell King - ARM Linux admin wrote: > > You still have not Cc'd me on your patches. Please can you either: > > > > 1) use get_maintainer.pl to find out whom you should be sending >

Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-03 Thread Alexandre Belloni
Hi Russell, On 03/12/2020 22:52:33+, Russell King - ARM Linux admin wrote: > You still have not Cc'd me on your patches. Please can you either: > > 1) use get_maintainer.pl to find out whom you should be sending >your patches to > or > 2) include me in your cc for this patch set as phylin

Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-03 Thread Russell King - ARM Linux admin
On Thu, Dec 03, 2020 at 10:52:53PM +0100, Andrew Lunn wrote: > > +/* map from SD25G28 interface width to configuration value */ > > +static u8 sd25g28_get_iw_setting(const u8 interface_width) > > +{ > > + switch (interface_width) { > > + case 10: return 0; > > + case 16: return 1; > > + cas

Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-03 Thread Andrew Lunn
> +/* map from SD25G28 interface width to configuration value */ > +static u8 sd25g28_get_iw_setting(const u8 interface_width) > +{ > + switch (interface_width) { > + case 10: return 0; > + case 16: return 1; > + case 32: return 3; > + case 40: return 4; > + case 64: return