RE: [PATCH v8 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler

2018-08-05 Thread Robin Gong
> >> +static struct pfuze_chip *syspm_pfuze_chip; > >> + > >> +static void pfuze_power_off_prepare(void) > >> + dev_info(syspm_pfuze_chip->dev, "Configure standy mode for power > >> +off"); > > Add 'if (syspm_pfuze_chip ->chip_id == PFUZE100))' here is easy for > > extend Support on pfuze200/3000.

Re: [PATCH v8 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler

2018-08-02 Thread Oleksij Rempel
gt;> ; Fabio Estevam ; Russell >> King ; dl-linux-imx ; Robin Gong >> ; A.s. Dong >> Subject: [PATCH v8 5/6] regulator: pfuze100-regulator: provide >> pm_power_off_prepare handler >> >> On some boards the SoC can use one pin "PMIC_STBY_REQ" to notify

Re: [PATCH v8 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler

2018-08-02 Thread Oleksij Rempel
On 30.07.2018 12:24, Mark Brown wrote: > On Mon, Jul 30, 2018 at 09:50:55AM +0200, Oleksij Rempel wrote: >> On 27.07.2018 11:32, Robin Gong wrote: > #include +#include > >>> Is it necessary? > >> yes, for pm_power_off_prepare > > That's a *weird* header to have to use for that sy

Re: [PATCH v8 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler

2018-07-30 Thread Mark Brown
On Mon, Jul 30, 2018 at 09:50:55AM +0200, Oleksij Rempel wrote: > On 27.07.2018 11:32, Robin Gong wrote: > >> #include > >> +#include > > Is it necessary? > yes, for pm_power_off_prepare That's a *weird* header to have to use for that symbol, are you sure there isn't something more specific

Re: [PATCH v8 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler

2018-07-30 Thread Oleksij Rempel
gt;> ; Fabio Estevam ; Russell >> King ; dl-linux-imx ; Robin Gong >> ; A.s. Dong >> Subject: [PATCH v8 5/6] regulator: pfuze100-regulator: provide >> pm_power_off_prepare handler >> >> On some boards the SoC can use one pin "PMIC_STBY_REQ" to notify

RE: [PATCH v8 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler

2018-07-27 Thread Robin Gong
nfradead.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Morton > ; Liam Girdwood ; > Leonard Crestez ; Rob Herring > ; Mark Rutland ; Michael > Turquette ; Stephen Boyd > ; Fabio Estevam ; Russell > King ; dl-linux-imx ; Robin Gong > ; A.s. Dong > Subje

[PATCH v8 5/6] regulator: pfuze100-regulator: provide pm_power_off_prepare handler

2018-07-26 Thread Oleksij Rempel
On some boards the SoC can use one pin "PMIC_STBY_REQ" to notify th PMIC about state changes. In this case internal state of PMIC must be preconfigured for upcomming state change. It works fine with the current regulator framework, except with the power-off case. This patch is providing an optiona