Re: [PATCH v8 6/8] cgroup/cpuset: Change cpuset_rwsem and hotplug lock order

2019-07-16 Thread Tejun Heo
On Fri, Jul 12, 2019 at 04:04:09PM +0200, Juri Lelli wrote: > > Should I take this as an indication that you had a look at the set and > > (apart from Peter's comments) you are OK with them? > > > > If that's the case I will send a v9 out soon. Otherwise I'd kindly ask > > you to please have a loo

Re: [PATCH v8 6/8] cgroup/cpuset: Change cpuset_rwsem and hotplug lock order

2019-07-12 Thread Juri Lelli
On 04/07/19 10:49, Juri Lelli wrote: > Hi, > > On 01/07/19 07:51, Tejun Heo wrote: > > Hello, > > > > On Mon, Jul 01, 2019 at 10:27:31AM +0200, Peter Zijlstra wrote: > > > IIRC TJ figured it wasn't strictly required to fix the lock invertion at > > > that time and they sorted it differently. If I

Re: [PATCH v8 6/8] cgroup/cpuset: Change cpuset_rwsem and hotplug lock order

2019-07-04 Thread Juri Lelli
Hi, On 01/07/19 07:51, Tejun Heo wrote: > Hello, > > On Mon, Jul 01, 2019 at 10:27:31AM +0200, Peter Zijlstra wrote: > > IIRC TJ figured it wasn't strictly required to fix the lock invertion at > > that time and they sorted it differently. If I (re)read the thread > > correctly the other day, he

Re: [PATCH v8 6/8] cgroup/cpuset: Change cpuset_rwsem and hotplug lock order

2019-07-01 Thread Tejun Heo
Hello, On Mon, Jul 01, 2019 at 10:27:31AM +0200, Peter Zijlstra wrote: > IIRC TJ figured it wasn't strictly required to fix the lock invertion at > that time and they sorted it differently. If I (re)read the thread > correctly the other day, he didn't have fundamental objections against > it, but

Re: [PATCH v8 6/8] cgroup/cpuset: Change cpuset_rwsem and hotplug lock order

2019-07-01 Thread Peter Zijlstra
On Mon, Jul 01, 2019 at 08:52:33AM +0200, Juri Lelli wrote: > Hi, > > On 28/06/19 15:03, Peter Zijlstra wrote: > > On Fri, Jun 28, 2019 at 10:06:16AM +0200, Juri Lelli wrote: > > > cpuset_rwsem is going to be acquired from sched_setscheduler() with a > > > following patch. There are however paths

Re: [PATCH v8 6/8] cgroup/cpuset: Change cpuset_rwsem and hotplug lock order

2019-06-30 Thread Juri Lelli
Hi, On 28/06/19 15:03, Peter Zijlstra wrote: > On Fri, Jun 28, 2019 at 10:06:16AM +0200, Juri Lelli wrote: > > cpuset_rwsem is going to be acquired from sched_setscheduler() with a > > following patch. There are however paths (e.g., spawn_ksoftirqd) in > > which sched_scheduler() is eventually cal

Re: [PATCH v8 6/8] cgroup/cpuset: Change cpuset_rwsem and hotplug lock order

2019-06-28 Thread Peter Zijlstra
On Fri, Jun 28, 2019 at 10:06:16AM +0200, Juri Lelli wrote: > cpuset_rwsem is going to be acquired from sched_setscheduler() with a > following patch. There are however paths (e.g., spawn_ksoftirqd) in > which sched_scheduler() is eventually called while holding hotplug lock; > this creates a depen

[PATCH v8 6/8] cgroup/cpuset: Change cpuset_rwsem and hotplug lock order

2019-06-28 Thread Juri Lelli
cpuset_rwsem is going to be acquired from sched_setscheduler() with a following patch. There are however paths (e.g., spawn_ksoftirqd) in which sched_scheduler() is eventually called while holding hotplug lock; this creates a dependecy between hotplug lock (to be always acquired first) and cpuset_r