Re: [PATCH v9 1/5] configfs: Allow dynamic group creation

2015-10-23 Thread Daniel Baluta
Christoph, one question. See below. On Fri, Oct 23, 2015 at 3:48 PM, Christoph Hellwig wrote: > Hi Daniel, > > all these functions look great, but can you also move your new > iio_sw_trigger_type_configfs_register/unregister functions to the > core code as those are the wrappers that everyone

Re: [PATCH v9 1/5] configfs: Allow dynamic group creation

2015-10-23 Thread Daniel Baluta
On Fri, Oct 23, 2015 at 3:48 PM, Christoph Hellwig wrote: > Hi Daniel, > > all these functions look great, but can you also move your new > iio_sw_trigger_type_configfs_register/unregister functions to the > core code as those are the wrappers that everyone would have to write, > e.g. something

Re: [PATCH v9 1/5] configfs: Allow dynamic group creation

2015-10-23 Thread Christoph Hellwig
Hi Daniel, all these functions look great, but can you also move your new iio_sw_trigger_type_configfs_register/unregister functions to the core code as those are the wrappers that everyone would have to write, e.g. something like: int configfs_register_default_group(struct config_group

[PATCH v9 1/5] configfs: Allow dynamic group creation

2015-10-23 Thread Daniel Baluta
We don't want to hardcode default groups at subsystem creation time. We export: * configfs_register_group * configfs_unregister_group to allow drivers to programatically create/destroy groups later, after module init time. This is needed for IIO configfs support. Suggested-by:

Re: [PATCH v9 1/5] configfs: Allow dynamic group creation

2015-10-23 Thread Christoph Hellwig
Hi Daniel, all these functions look great, but can you also move your new iio_sw_trigger_type_configfs_register/unregister functions to the core code as those are the wrappers that everyone would have to write, e.g. something like: int configfs_register_default_group(struct config_group

Re: [PATCH v9 1/5] configfs: Allow dynamic group creation

2015-10-23 Thread Daniel Baluta
On Fri, Oct 23, 2015 at 3:48 PM, Christoph Hellwig wrote: > Hi Daniel, > > all these functions look great, but can you also move your new > iio_sw_trigger_type_configfs_register/unregister functions to the > core code as those are the wrappers that everyone would have to write, >

Re: [PATCH v9 1/5] configfs: Allow dynamic group creation

2015-10-23 Thread Daniel Baluta
Christoph, one question. See below. On Fri, Oct 23, 2015 at 3:48 PM, Christoph Hellwig wrote: > Hi Daniel, > > all these functions look great, but can you also move your new > iio_sw_trigger_type_configfs_register/unregister functions to the > core code as those are the wrappers

[PATCH v9 1/5] configfs: Allow dynamic group creation

2015-10-23 Thread Daniel Baluta
We don't want to hardcode default groups at subsystem creation time. We export: * configfs_register_group * configfs_unregister_group to allow drivers to programatically create/destroy groups later, after module init time. This is needed for IIO configfs support. Suggested-by: