Re: [PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

2012-09-25 Thread Andy Shevchenko
On Wed, Sep 26, 2012 at 9:51 AM, viresh kumar wrote: > On Wed, Sep 26, 2012 at 12:17 PM, Andy Shevchenko > wrote: > >> This separate driver makes no sense in case it is built properly without >> CLK framework. Let me check this and leave comments at patch 1/6. > > Following is the commit that int

Re: [PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

2012-09-25 Thread viresh kumar
On Wed, Sep 26, 2012 at 12:17 PM, Andy Shevchenko wrote: > This separate driver makes no sense in case it is built properly without > CLK framework. Let me check this and leave comments at patch 1/6. Following is the commit that introduced this change :) commit 93abe8e4b13ae9a0428ce940a8a03ac72

Re: [PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

2012-09-25 Thread Andy Shevchenko
On Wed, 2012-09-26 at 09:20 +0530, viresh kumar wrote: > On Tue, Sep 25, 2012 at 5:43 PM, Andy Shevchenko > wrote: > > From: Heikki Krogerus > > > > This driver should be usable on all platforms that depend on clk API. > > This is not what you mentioned in subject :( > > > Signed-off-by: Heik

Re: [PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

2012-09-25 Thread viresh kumar
On Tue, Sep 25, 2012 at 5:43 PM, Andy Shevchenko wrote: > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index df32537..e47cc90 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -89,6 +89,15 @@ config DW_DMAC > Support the Synopsys DesignWare AHB DMA controlle

Re: [PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

2012-09-25 Thread viresh kumar
On Tue, Sep 25, 2012 at 5:43 PM, Andy Shevchenko wrote: > From: Heikki Krogerus > > This driver should be usable on all platforms that depend on clk API. This is not what you mentioned in subject :( > Signed-off-by: Heikki Krogerus > Signed-off-by: Andy Shevchenko > --- > drivers/dma/Kconfig

[PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

2012-09-25 Thread Andy Shevchenko
From: Heikki Krogerus This driver should be usable on all platforms that depend on clk API. Signed-off-by: Heikki Krogerus Signed-off-by: Andy Shevchenko --- drivers/dma/Kconfig|9 +++ drivers/dma/Makefile |1 + drivers/dma/dw_dmac.c | 23 +-- drivers/dma/dw_d