Re: [PATCHv2] x86: mm: clean up probe_memory_block_size()

2015-11-30 Thread Seth Jennings
On Fri, Nov 27, 2015 at 08:39:32AM +0100, Ingo Molnar wrote: > > * Seth Jennings wrote: > > > v2: > > remove local bz variable (Ingo) and debug message since, if > > the 2GB message doesn't print, there is only one possible > > block size. > > I'd not remove the info message, it would print the

Re: [PATCHv2] x86: mm: clean up probe_memory_block_size()

2015-11-26 Thread Ingo Molnar
* Seth Jennings wrote: > v2: > remove local bz variable (Ingo) and debug message since, if > the 2GB message doesn't print, there is only one possible > block size. I'd not remove the info message, it would print the memory block size regardless of memory size. Yes, one could decode the 'no m

[PATCHv2] x86: mm: clean up probe_memory_block_size()

2015-11-26 Thread Seth Jennings
v2: remove local bz variable (Ingo) and debug message since, if the 2GB message doesn't print, there is only one possible block size. The cumulative effect of bdee237c and 982792c7 is some pretty convoluted code. This commit has no (intended) functional change; just seeks to simplify and make the