Re: [PATCHv4] remoteproc: Add STE modem driver for remoteproc

2012-09-22 Thread Ohad Ben-Cohen
On Sat, Sep 22, 2012 at 4:33 PM, Sjur Brændeland wrote: It might be safer though to invoke ->setup() in probe/remove, instead of in start/stop (just like you essentially did before). This way we don't assume that stop is always called before remove (as assumption that migh

Re: [PATCHv4] remoteproc: Add STE modem driver for remoteproc

2012-09-22 Thread Sjur Brændeland
Hi Ohad, >>> It might be safer though to invoke ->setup() in probe/remove, instead >>> of in start/stop (just like you essentially did before). >>> >>> This way we don't assume that stop is always called before remove (as >>> assumption that might be implicitly valid today, but may break in the >>

Re: [PATCHv4] remoteproc: Add STE modem driver for remoteproc

2012-09-22 Thread Ohad Ben-Cohen
Hi Sjur, On Sat, Sep 22, 2012 at 2:38 PM, Sjur Brændeland wrote: >> It might be safer though to invoke ->setup() in probe/remove, instead >> of in start/stop (just like you essentially did before). >> >> This way we don't assume that stop is always called before remove (as >> assumption that migh

Re: [PATCHv4] remoteproc: Add STE modem driver for remoteproc

2012-09-22 Thread Sjur Brændeland
Hi Ohad, > Thanks, it looks good. > > It might be safer though to invoke ->setup() in probe/remove, instead > of in start/stop (just like you essentially did before). > > This way we don't assume that stop is always called before remove (as > assumption that might be implicitly valid today, but ma

Re: [PATCHv4] remoteproc: Add STE modem driver for remoteproc

2012-09-22 Thread Ohad Ben-Cohen
On Thu, Sep 20, 2012 at 7:32 PM, wrote: > From: Sjur Brændeland > > Add support for the STE modem shared memory driver. > This driver hooks into the remoteproc framework > in order to manage configuration and the virtio > devices. > > This driver adds custom firmware handlers, because > STE mode

[PATCHv4] remoteproc: Add STE modem driver for remoteproc

2012-09-20 Thread sjur . brandeland
From: Sjur Brændeland Add support for the STE modem shared memory driver. This driver hooks into the remoteproc framework in order to manage configuration and the virtio devices. This driver adds custom firmware handlers, because STE modem uses a custom firmware layout. Signed-off-by: Sjur Bræn