Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Tue, 7 Feb 2017 01:42:53 +0900 Sergey Senozhatsky wrote: > On (02/06/17 08:27), Steven Rostedt wrote: > [..] > > > > > just in case, the patch (which I prefer to be ignored) > > > > > > > > let's keep printk_safe_flush_line(). > > > > > > I do not have

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Tue, 7 Feb 2017 01:42:53 +0900 Sergey Senozhatsky wrote: > On (02/06/17 08:27), Steven Rostedt wrote: > [..] > > > > > just in case, the patch (which I prefer to be ignored) > > > > > > > > let's keep printk_safe_flush_line(). > > > > > > I do not have strong opinion but I would

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On (02/06/17 08:27), Steven Rostedt wrote: [..] > > > > just in case, the patch (which I prefer to be ignored) > > > > > > let's keep printk_safe_flush_line(). > > > > I do not have strong opinion but I would slightly prefer > > to keep the helper function. The use of printk_deferred() > >

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On (02/06/17 08:27), Steven Rostedt wrote: [..] > > > > just in case, the patch (which I prefer to be ignored) > > > > > > let's keep printk_safe_flush_line(). > > > > I do not have strong opinion but I would slightly prefer > > to keep the helper function. The use of printk_deferred() > >

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Mon, 6 Feb 2017 13:16:52 +0100 Petr Mladek wrote: > > > just in case, the patch (which I prefer to be ignored) > > > > let's keep printk_safe_flush_line(). > > I do not have strong opinion but I would slightly prefer > to keep the helper function. The use of

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Mon, 6 Feb 2017 13:16:52 +0100 Petr Mladek wrote: > > > just in case, the patch (which I prefer to be ignored) > > > > let's keep printk_safe_flush_line(). > > I do not have strong opinion but I would slightly prefer > to keep the helper function. The use of printk_deferred() > is a

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Mon 2017-02-06 11:08:20, Sergey Senozhatsky wrote: > On (02/06/17 10:48), Sergey Senozhatsky wrote: > [..] > > from many places: > > > > 4x printk_safe_flush_buffer() > > 1x __printk_safe_flush() > > > > > > replacing printk_safe_flush_line() with printk_deferred() produces things >

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Mon 2017-02-06 11:08:20, Sergey Senozhatsky wrote: > On (02/06/17 10:48), Sergey Senozhatsky wrote: > [..] > > from many places: > > > > 4x printk_safe_flush_buffer() > > 1x __printk_safe_flush() > > > > > > replacing printk_safe_flush_line() with printk_deferred() produces things >

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On (02/06/17 10:48), Sergey Senozhatsky wrote: [..] > from many places: > > 4x printk_safe_flush_buffer() > 1x __printk_safe_flush() > > > replacing printk_safe_flush_line() with printk_deferred() produces things > like these > >printk_deferred("%.*s", end - start,

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On (02/06/17 10:48), Sergey Senozhatsky wrote: [..] > from many places: > > 4x printk_safe_flush_buffer() > 1x __printk_safe_flush() > > > replacing printk_safe_flush_line() with printk_deferred() produces things > like these > >printk_deferred("%.*s", end - start,

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On (02/03/17 12:18), Petr Mladek wrote: [..] > > by "the new approved variant" do you mean resend of the entire > > patch set (v8) or just 0004 patch? > > I depends on how many and how complicated are possible conflicts > with the followup patches. > > It is perfectly fine to send just 0004 if

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On (02/03/17 12:18), Petr Mladek wrote: [..] > > by "the new approved variant" do you mean resend of the entire > > patch set (v8) or just 0004 patch? > > I depends on how many and how complicated are possible conflicts > with the followup patches. > > It is perfectly fine to send just 0004 if

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Fri 2017-02-03 11:04:18, Sergey Senozhatsky wrote: > On (02/02/17 16:52), Petr Mladek wrote: > [..] > > > I am still learning how to manage the patches in the printk.git tree. > > > > > > I would like to add Steven's Reviewed-by tags, links to the mails, > > > and list of CC-ed people. IMHO,

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Fri 2017-02-03 11:04:18, Sergey Senozhatsky wrote: > On (02/02/17 16:52), Petr Mladek wrote: > [..] > > > I am still learning how to manage the patches in the printk.git tree. > > > > > > I would like to add Steven's Reviewed-by tags, links to the mails, > > > and list of CC-ed people. IMHO,

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On (02/02/17 16:52), Petr Mladek wrote: [..] > > I am still learning how to manage the patches in the printk.git tree. > > > > I would like to add Steven's Reviewed-by tags, links to the mails, > > and list of CC-ed people. IMHO, the only way is to rebase the for-4.11 > > and for-next branches.

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On (02/02/17 16:52), Petr Mladek wrote: [..] > > I am still learning how to manage the patches in the printk.git tree. > > > > I would like to add Steven's Reviewed-by tags, links to the mails, > > and list of CC-ed people. IMHO, the only way is to rebase the for-4.11 > > and for-next branches.

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Thu 2017-02-02 16:37:53, Petr Mladek wrote: > On Thu 2017-02-02 15:05:38, Sergey Senozhatsky wrote: > > On (02/01/17 11:06), Steven Rostedt wrote: > > [..] > > > > static void printk_safe_flush_line(const char *text, int len) > > > > { > > > > /* > > > > -* The buffers are

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Thu 2017-02-02 16:37:53, Petr Mladek wrote: > On Thu 2017-02-02 15:05:38, Sergey Senozhatsky wrote: > > On (02/01/17 11:06), Steven Rostedt wrote: > > [..] > > > > static void printk_safe_flush_line(const char *text, int len) > > > > { > > > > /* > > > > -* The buffers are

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Thu 2017-02-02 15:05:38, Sergey Senozhatsky wrote: > On (02/01/17 11:06), Steven Rostedt wrote: > [..] > > > static void printk_safe_flush_line(const char *text, int len) > > > { > > > /* > > > - * The buffers are flushed in NMI only on panic. The messages must > > > - * go only into the

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Thu 2017-02-02 15:05:38, Sergey Senozhatsky wrote: > On (02/01/17 11:06), Steven Rostedt wrote: > [..] > > > static void printk_safe_flush_line(const char *text, int len) > > > { > > > /* > > > - * The buffers are flushed in NMI only on panic. The messages must > > > - * go only into the

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On (02/01/17 11:06), Steven Rostedt wrote: [..] > > static void printk_safe_flush_line(const char *text, int len) > > { > > /* > > -* The buffers are flushed in NMI only on panic. The messages must > > -* go only into the ring buffer at this stage. Consoles will get > > -*

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On (02/01/17 11:06), Steven Rostedt wrote: [..] > > static void printk_safe_flush_line(const char *text, int len) > > { > > /* > > -* The buffers are flushed in NMI only on panic. The messages must > > -* go only into the ring buffer at this stage. Consoles will get > > -*

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Tue, 27 Dec 2016 23:16:07 +0900 Sergey Senozhatsky wrote: > Always use printk_deferred() in printk_safe_flush_line(). > Flushing can be done from NMI or printk_safe contexts (when > we are in panic), so we can't call console drivers, yet still > want to store the

Re: [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

On Tue, 27 Dec 2016 23:16:07 +0900 Sergey Senozhatsky wrote: > Always use printk_deferred() in printk_safe_flush_line(). > Flushing can be done from NMI or printk_safe contexts (when > we are in panic), so we can't call console drivers, yet still > want to store the messages in the logbuf

[PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

Always use printk_deferred() in printk_safe_flush_line(). Flushing can be done from NMI or printk_safe contexts (when we are in panic), so we can't call console drivers, yet still want to store the messages in the logbuf buffer. Therefore we use a deferred printk version. Signed-off-by: Sergey

[PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines

Always use printk_deferred() in printk_safe_flush_line(). Flushing can be done from NMI or printk_safe contexts (when we are in panic), so we can't call console drivers, yet still want to store the messages in the logbuf buffer. Therefore we use a deferred printk version. Signed-off-by: Sergey