Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-24 Thread David Wilder
Christoph Hellwig wrote: Your mailer wrapper the patch so I can't actually apply it to start playing with the patch. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-24 Thread David Wilder
Christoph Hellwig wrote: Your mailer wrapper the patch so I can't actually apply it to start playing with the patch. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-23 Thread Christoph Hellwig
Your mailer wrapper the patch so I can't actually apply it to start playing with the patch. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-23 Thread Christoph Hellwig
Your mailer wrapper the patch so I can't actually apply it to start playing with the patch. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-21 Thread Randy Dunlap
On Fri, 21 Sep 2007 14:48:14 -0700 David J. Wilder wrote: > I updated the example code to eliminate the use of the temp print buffer > and the use of NR_CPU. > > Please see previous postings for more information and patch > dependencies. > http://lkml.org/lkml/2007/9/19/4 (PATCH 0/2) >

[Patch 1/2] Trace code and documentation (updated)

2007-09-21 Thread David J. Wilder
I updated the example code to eliminate the use of the temp print buffer and the use of NR_CPU. Please see previous postings for more information and patch dependencies. http://lkml.org/lkml/2007/9/19/4 (PATCH 0/2) http://lkml.org/lkml/2007/9/19/6 (PATCH 2/2) - Trace -

[Patch 1/2] Trace code and documentation (updated)

2007-09-21 Thread David J. Wilder
I updated the example code to eliminate the use of the temp print buffer and the use of NR_CPU. Please see previous postings for more information and patch dependencies. http://lkml.org/lkml/2007/9/19/4 (PATCH 0/2) http://lkml.org/lkml/2007/9/19/6 (PATCH 2/2) ---start of

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-21 Thread Randy Dunlap
On Fri, 21 Sep 2007 14:48:14 -0700 David J. Wilder wrote: I updated the example code to eliminate the use of the temp print buffer and the use of NR_CPU. Please see previous postings for more information and patch dependencies. http://lkml.org/lkml/2007/9/19/4 (PATCH 0/2)

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Randy Dunlap
On Wed, 19 Sep 2007 17:20:18 +0100 Christoph Hellwig wrote: > On Wed, Sep 19, 2007 at 07:14:47AM -0700, David Wilder wrote: > > I agree with you; however, this is in the example code in the > > Documentation directory, It is not part of the trace code. The example > > was just meant to be a

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Christoph Hellwig
On Wed, Sep 19, 2007 at 07:48:45PM +0200, Sam Ravnborg wrote: > > Well, this is kernel code - so util-linux is not the solution here > > obviously :) > > Can you sketch what you have in mind. > We right now have said we wnated to: > 1) include a framework for executing simple

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Sam Ravnborg
On Wed, Sep 19, 2007 at 05:55:07PM +0100, Christoph Hellwig wrote: > On Wed, Sep 19, 2007 at 09:52:23AM -0700, Randy Dunlap wrote: > > That's why they exmaples should not be hidden/embedded in .txt files; > > they should be standalone .c files with makefiles etc. > > Yes. And most importantly

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread David Wilder
Randy Dunlap wrote: On Wed, 19 Sep 2007 17:20:18 +0100 Christoph Hellwig wrote: On Wed, Sep 19, 2007 at 07:14:47AM -0700, David Wilder wrote: I agree with you; however, this is in the example code in the Documentation directory, It is not part of the trace code. The example was just meant

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Christoph Hellwig
On Wed, Sep 19, 2007 at 09:52:23AM -0700, Randy Dunlap wrote: > That's why they exmaples should not be hidden/embedded in .txt files; > they should be standalone .c files with makefiles etc. Yes. And most importantly integrated with the kernel build system. > and they can be taken out of

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Christoph Hellwig
On Wed, Sep 19, 2007 at 07:14:47AM -0700, David Wilder wrote: > I agree with you; however, this is in the example code in the > Documentation directory, It is not part of the trace code. The example > was just meant to be a demonstration of how the interface works. So we tell people to write

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Andi Kleen
> I agree with you; however, this is in the example code in the > Documentation directory, It is not part of the trace code. The example > was just meant to be a demonstration of how the interface works. That's not a good excuse. In fact it's a very bad one. Especially example code needs to

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread David Wilder
Andi Kleen wrote: "David J. Wilder" <[EMAIL PROTECTED]> writes: Not having read the whole thing; just something I noticed. Gut feeling is that you have too many knobs and options and some overengineering though -- simplifying it would be a good thing. + +#define TRACE_PRINTF_TMPBUF_SIZE

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Andi Kleen
"David J. Wilder" <[EMAIL PROTECTED]> writes: Not having read the whole thing; just something I noticed. Gut feeling is that you have too many knobs and options and some overengineering though -- simplifying it would be a good thing. > + > +#define TRACE_PRINTF_TMPBUF_SIZE (1024) > +static

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Andi Kleen
David J. Wilder [EMAIL PROTECTED] writes: Not having read the whole thing; just something I noticed. Gut feeling is that you have too many knobs and options and some overengineering though -- simplifying it would be a good thing. + +#define TRACE_PRINTF_TMPBUF_SIZE (1024) +static char

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread David Wilder
Andi Kleen wrote: David J. Wilder [EMAIL PROTECTED] writes: Not having read the whole thing; just something I noticed. Gut feeling is that you have too many knobs and options and some overengineering though -- simplifying it would be a good thing. + +#define TRACE_PRINTF_TMPBUF_SIZE (1024)

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Andi Kleen
I agree with you; however, this is in the example code in the Documentation directory, It is not part of the trace code. The example was just meant to be a demonstration of how the interface works. That's not a good excuse. In fact it's a very bad one. Especially example code needs to be

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Christoph Hellwig
On Wed, Sep 19, 2007 at 07:14:47AM -0700, David Wilder wrote: I agree with you; however, this is in the example code in the Documentation directory, It is not part of the trace code. The example was just meant to be a demonstration of how the interface works. So we tell people to write bad

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Christoph Hellwig
On Wed, Sep 19, 2007 at 09:52:23AM -0700, Randy Dunlap wrote: That's why they exmaples should not be hidden/embedded in .txt files; they should be standalone .c files with makefiles etc. Yes. And most importantly integrated with the kernel build system. and they can be taken out of

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread David Wilder
Randy Dunlap wrote: On Wed, 19 Sep 2007 17:20:18 +0100 Christoph Hellwig wrote: On Wed, Sep 19, 2007 at 07:14:47AM -0700, David Wilder wrote: I agree with you; however, this is in the example code in the Documentation directory, It is not part of the trace code. The example was just meant

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Sam Ravnborg
On Wed, Sep 19, 2007 at 05:55:07PM +0100, Christoph Hellwig wrote: On Wed, Sep 19, 2007 at 09:52:23AM -0700, Randy Dunlap wrote: That's why they exmaples should not be hidden/embedded in .txt files; they should be standalone .c files with makefiles etc. Yes. And most importantly

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Christoph Hellwig
On Wed, Sep 19, 2007 at 07:48:45PM +0200, Sam Ravnborg wrote: Well, this is kernel code - so util-linux is not the solution here obviously :) Can you sketch what you have in mind. We right now have said we wnated to: 1) include a framework for executing simple new-syscall-test-stubs 2)

Re: [Patch 1/2] Trace code and documentation (updated)

2007-09-19 Thread Randy Dunlap
On Wed, 19 Sep 2007 17:20:18 +0100 Christoph Hellwig wrote: On Wed, Sep 19, 2007 at 07:14:47AM -0700, David Wilder wrote: I agree with you; however, this is in the example code in the Documentation directory, It is not part of the trace code. The example was just meant to be a

[Patch 1/2] Trace code and documentation (updated)

2007-09-18 Thread David J. Wilder
Trace - Provides tracing primitives Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]> Signed-off-by: Martin Hunt <[EMAIL PROTECTED]> Signed-off-by: David Wilder <[EMAIL PROTECTED]> --- Documentation/trace/src/Makefile |7 + Documentation/trace/src/README | 18 +

[Patch 1/2] Trace code and documentation (updated)

2007-09-18 Thread David J. Wilder
Trace - Provides tracing primitives Signed-off-by: Tom Zanussi [EMAIL PROTECTED] Signed-off-by: Martin Hunt [EMAIL PROTECTED] Signed-off-by: David Wilder [EMAIL PROTECTED] --- Documentation/trace/src/Makefile |7 + Documentation/trace/src/README | 18 +