Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-10-01 Thread Stephen Warren
On 10/01/2013 02:08 AM, Uwe Kleine-König wrote: > On Wed, Sep 25, 2013 at 04:33:24PM +0200, Daniel Lezcano wrote: >> On 09/16/2013 11:44 AM, Uwe Kleine-König wrote: >>> Signed-off-by: Uwe Kleine-König >>> --- >>> Hello, >>> >>> I'm not sure that the way I implemented if a given timer is used as >>

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-10-01 Thread Uwe Kleine-König
On Wed, Sep 25, 2013 at 04:33:24PM +0200, Daniel Lezcano wrote: > On 09/16/2013 11:44 AM, Uwe Kleine-König wrote: > > Signed-off-by: Uwe Kleine-König > > --- > > Hello, > > > > I'm not sure that the way I implemented if a given timer is used as > > clock_source or clock_event_device is robust. Do

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-26 Thread Uwe Kleine-König
Hello Daniel, On Thu, Sep 26, 2013 at 10:52:29AM +0200, Daniel Lezcano wrote: > On 09/26/2013 10:20 AM, Uwe Kleine-König wrote: > >Hello Daniel, > > > >On Thu, Sep 26, 2013 at 01:49:52AM +0200, Daniel Lezcano wrote: > >>On 09/25/2013 05:32 PM, Uwe Kleine-König wrote: > >+static void __init efm

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-26 Thread Daniel Lezcano
On 09/26/2013 10:20 AM, Uwe Kleine-König wrote: Hello Daniel, On Thu, Sep 26, 2013 at 01:49:52AM +0200, Daniel Lezcano wrote: On 09/25/2013 05:32 PM, Uwe Kleine-König wrote: +static void __init efm32_timer_init(struct device_node *np) +{ + static int has_clocksource, has_clockevent; +

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-26 Thread Uwe Kleine-König
Hello Daniel, On Thu, Sep 26, 2013 at 01:49:52AM +0200, Daniel Lezcano wrote: > On 09/25/2013 05:32 PM, Uwe Kleine-König wrote: > >>> +static void __init efm32_timer_init(struct device_node *np) > >>> +{ > >>> + static int has_clocksource, has_clockevent; > >>> + int ret; > >>> + > >>> + if (!has_

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-26 Thread Uwe Kleine-König
On Wed, Sep 25, 2013 at 04:55:15PM -0700, John Stultz wrote: > On 09/25/2013 04:49 PM, Daniel Lezcano wrote: > > On 09/25/2013 05:32 PM, Uwe Kleine-König wrote: > >> Hello Daniel, > >> > >> On Wed, Sep 25, 2013 at 04:33:24PM +0200, Daniel Lezcano wrote: > >>> On 09/16/2013 11:44 AM, Uwe Kleine-Köni

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-25 Thread John Stultz
On 09/25/2013 04:49 PM, Daniel Lezcano wrote: > On 09/25/2013 05:32 PM, Uwe Kleine-König wrote: >> Hello Daniel, >> >> On Wed, Sep 25, 2013 at 04:33:24PM +0200, Daniel Lezcano wrote: >>> On 09/16/2013 11:44 AM, Uwe Kleine-König wrote: diff --git a/drivers/clocksource/Kconfig b/drivers/clocksou

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-25 Thread Daniel Lezcano
On 09/25/2013 05:32 PM, Uwe Kleine-König wrote: > Hello Daniel, > > On Wed, Sep 25, 2013 at 04:33:24PM +0200, Daniel Lezcano wrote: >> On 09/16/2013 11:44 AM, Uwe Kleine-König wrote: >>> Signed-off-by: Uwe Kleine-König >>> --- >>> I'm not sure that the way I implemented if a given timer is used a

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-25 Thread Uwe Kleine-König
Hello Daniel, On Wed, Sep 25, 2013 at 04:33:24PM +0200, Daniel Lezcano wrote: > On 09/16/2013 11:44 AM, Uwe Kleine-König wrote: > > Signed-off-by: Uwe Kleine-König > > --- > > I'm not sure that the way I implemented if a given timer is used as > > clock_source or clock_event_device is robust. Doe

Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-25 Thread Daniel Lezcano
On 09/16/2013 11:44 AM, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König > --- > Hello, > > I'm not sure that the way I implemented if a given timer is used as > clock_source or clock_event_device is robust. Does it need locking? > The reason to create a timer device for each timer inste

[RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs

2013-09-16 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König --- Hello, I'm not sure that the way I implemented if a given timer is used as clock_source or clock_event_device is robust. Does it need locking? The reason to create a timer device for each timer instead of a single device of all of them is that it makes it clean