Re: [RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-21 Thread Daniel Thompson
On Fri, Aug 21, 2020 at 12:19:03PM +0200, pet...@infradead.org wrote: > On Thu, Aug 20, 2020 at 04:28:28PM +0100, Daniel Thompson wrote: > > > Specifically I've entered the kdb in pretty much the simplest way > > possible: a direct call to kgdb_breakpoint() from a task context. I > > generate a ba

Re: [RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-21 Thread peterz
On Thu, Aug 20, 2020 at 04:28:28PM +0100, Daniel Thompson wrote: > Specifically I've entered the kdb in pretty much the simplest way > possible: a direct call to kgdb_breakpoint() from a task context. I > generate a backtrace to illustrate this, just to give you a better > understanding of what mi

Re: [RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-20 Thread peterz
On Thu, Aug 20, 2020 at 09:43:15AM -0700, Andy Lutomirski wrote: > I’ve lost track of how many bugs QEMU and KVM have in this space. > Let’s keep it as a warning, but a bug. But let’s get rid of the > totally bogus TIF_SINGLESTEP manipulation. OK, I've shuffled the series around to fix that orderi

Re: [RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-20 Thread Josh Poimboeuf
On Thu, Aug 20, 2020 at 09:43:15AM -0700, Andy Lutomirski wrote: > > > > On Aug 20, 2020, at 9:35 AM, pet...@infradead.org wrote: > > > > On Thu, Aug 20, 2020 at 11:17:29AM -0500, Josh Poimboeuf wrote: > >> On Thu, Aug 20, 2020 at 05:21:11PM +0200, pet...@infradead.org wrote: > > > >>> qemu-gd

Re: [RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-20 Thread Andy Lutomirski
> On Aug 20, 2020, at 9:35 AM, pet...@infradead.org wrote: > > On Thu, Aug 20, 2020 at 11:17:29AM -0500, Josh Poimboeuf wrote: >> On Thu, Aug 20, 2020 at 05:21:11PM +0200, pet...@infradead.org wrote: > >>> qemu-gdb stub should eat the event before it lands in the guest >> >> Are we sure abou

Re: [RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-20 Thread peterz
On Thu, Aug 20, 2020 at 11:17:29AM -0500, Josh Poimboeuf wrote: > On Thu, Aug 20, 2020 at 05:21:11PM +0200, pet...@infradead.org wrote: > > qemu-gdb stub should eat the event before it lands in the guest > > Are we sure about that? I triggered the warning just now, stepping > through the debug h

Re: [RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-20 Thread Josh Poimboeuf
On Thu, Aug 20, 2020 at 05:21:11PM +0200, pet...@infradead.org wrote: > On Thu, Aug 20, 2020 at 10:16:59AM -0500, Josh Poimboeuf wrote: > > On Thu, Aug 20, 2020 at 05:08:41PM +0200, pet...@infradead.org wrote: > > > On Thu, Aug 20, 2020 at 10:45:12AM -0400, Brian Gerst wrote: > > > > On Thu, Aug 20

Re: [RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-20 Thread peterz
On Thu, Aug 20, 2020 at 04:28:28PM +0100, Daniel Thompson wrote: > On Thu, Aug 20, 2020 at 12:38:36PM +0200, Peter Zijlstra wrote: > > > > Signed-off-by: Peter Zijlstra (Intel) > > --- > > arch/x86/kernel/traps.c | 24 > > 1 file changed, 12 insertions(+), 12 deletions

Re: [RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-20 Thread Daniel Thompson
On Thu, Aug 20, 2020 at 12:38:36PM +0200, Peter Zijlstra wrote: > > Signed-off-by: Peter Zijlstra (Intel) > --- > arch/x86/kernel/traps.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > --- a/arch/x86/kernel/traps.c > +++ b/arch/x86/kernel/traps.c > @@ -

Re: [RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-20 Thread peterz
On Thu, Aug 20, 2020 at 10:16:59AM -0500, Josh Poimboeuf wrote: > On Thu, Aug 20, 2020 at 05:08:41PM +0200, pet...@infradead.org wrote: > > On Thu, Aug 20, 2020 at 10:45:12AM -0400, Brian Gerst wrote: > > > On Thu, Aug 20, 2020 at 6:53 AM Peter Zijlstra > > > wrote: > > > > > > > > > > > > Signed

Re: [RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-20 Thread Josh Poimboeuf
On Thu, Aug 20, 2020 at 05:08:41PM +0200, pet...@infradead.org wrote: > On Thu, Aug 20, 2020 at 10:45:12AM -0400, Brian Gerst wrote: > > On Thu, Aug 20, 2020 at 6:53 AM Peter Zijlstra wrote: > > > > > > > > > Signed-off-by: Peter Zijlstra (Intel) > > > --- > > > arch/x86/kernel/traps.c | 24 ++

Re: [RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-20 Thread peterz
On Thu, Aug 20, 2020 at 10:45:12AM -0400, Brian Gerst wrote: > On Thu, Aug 20, 2020 at 6:53 AM Peter Zijlstra wrote: > > > > > > Signed-off-by: Peter Zijlstra (Intel) > > --- > > arch/x86/kernel/traps.c | 24 > > 1 file changed, 12 insertions(+), 12 deletions(-) > > >

Re: [RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-20 Thread Brian Gerst
On Thu, Aug 20, 2020 at 6:53 AM Peter Zijlstra wrote: > > > Signed-off-by: Peter Zijlstra (Intel) > --- > arch/x86/kernel/traps.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > --- a/arch/x86/kernel/traps.c > +++ b/arch/x86/kernel/traps.c > @@ -820,18 +8

[RFC][PATCH 4/7] x86/debug: Move historical SYSENTER junk into exc_debug_kernel()

2020-08-20 Thread Peter Zijlstra
Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/kernel/traps.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -820,18 +820,6 @@ static void handle_debug(struct pt_regs goto out