Re: [RFC][Patch 2/6] integrity: fs hook placement

2007-03-08 Thread Serge E. Hallyn
Quoting Stephen Smalley ([EMAIL PROTECTED]): > On Thu, 2007-03-08 at 12:01 -0600, Serge E. Hallyn wrote: > > Quoting Chris Wright ([EMAIL PROTECTED]): > > > * Serge E. Hallyn ([EMAIL PROTECTED]) wrote: > > > > Are you objecting only to the duplication at the callsites, so that an > > > > fsnotify-t

Re: [RFC][Patch 2/6] integrity: fs hook placement

2007-03-08 Thread Stephen Smalley
On Thu, 2007-03-08 at 12:01 -0600, Serge E. Hallyn wrote: > Quoting Chris Wright ([EMAIL PROTECTED]): > > * Serge E. Hallyn ([EMAIL PROTECTED]) wrote: > > > Are you objecting only to the duplication at the callsites, so that an > > > fsnotify-type of consolidation of security and integrity hooks wo

Re: [RFC][Patch 2/6] integrity: fs hook placement

2007-03-08 Thread Mimi Zohar
On Thu, 2007-03-08 at 21:16 +0300, Dmitriy Monakhov wrote: > Mimi Zohar <[EMAIL PROTECTED]> writes: > > > This patch places calls to the new integrity hooks in the appropriate > > places in the fs directory. It is not meant in any way to be viewed > > as a complete set, but used as a basis for an

Re: [RFC][Patch 2/6] integrity: fs hook placement

2007-03-08 Thread Mimi Zohar
On Thu, 2007-03-08 at 09:40 -0800, Chris Wright wrote: > * Serge E. Hallyn ([EMAIL PROTECTED]) wrote: > > Are you objecting only to the duplication at the callsites, so that an > > fsnotify-type of consolidation of security and integrity hooks would be > > ok? Or are you complaining that the secur

Re: [RFC][Patch 2/6] integrity: fs hook placement

2007-03-08 Thread Dmitriy Monakhov
Mimi Zohar <[EMAIL PROTECTED]> writes: > This patch places calls to the new integrity hooks in the appropriate > places in the fs directory. It is not meant in any way to be viewed > as a complete set, but used as a basis for an initial discussion. > > Index: linux-2.6.21-rc3-mm2/fs/ext3/xattr_sec

Re: [RFC][Patch 2/6] integrity: fs hook placement

2007-03-08 Thread Serge E. Hallyn
Quoting Chris Wright ([EMAIL PROTECTED]): > * Serge E. Hallyn ([EMAIL PROTECTED]) wrote: > > Are you objecting only to the duplication at the callsites, so that an > > fsnotify-type of consolidation of security and integrity hooks would be > > ok? Or are you complaining that the security_inode_set

Re: [RFC][Patch 2/6] integrity: fs hook placement

2007-03-08 Thread Chris Wright
* Serge E. Hallyn ([EMAIL PROTECTED]) wrote: > Are you objecting only to the duplication at the callsites, so that an > fsnotify-type of consolidation of security and integrity hooks would be > ok? Or are you complaining that the security_inode_setxattr and > integrity_inode_setxattr hooks are too

Re: [RFC][Patch 2/6] integrity: fs hook placement

2007-03-08 Thread Serge E. Hallyn
Quoting Chris Wright ([EMAIL PROTECTED]): > * Mimi Zohar ([EMAIL PROTECTED]) wrote: > > + integrity_d_instantiate(entry, inode); > > security_d_instantiate(entry, inode); > > > + integrity_d_instantiate(entry, inode); > > security_d_instantiate(entry, inode); > > >

Re: [RFC][Patch 2/6] integrity: fs hook placement

2007-03-08 Thread Chris Wright
* Mimi Zohar ([EMAIL PROTECTED]) wrote: > + integrity_d_instantiate(entry, inode); > security_d_instantiate(entry, inode); > + integrity_d_instantiate(entry, inode); > security_d_instantiate(entry, inode); > spin_unlock(&dcache_lock); > +

[RFC][Patch 2/6] integrity: fs hook placement

2007-03-08 Thread Mimi Zohar
This patch places calls to the new integrity hooks in the appropriate places in the fs directory. It is not meant in any way to be viewed as a complete set, but used as a basis for an initial discussion. Index: linux-2.6.21-rc3-mm2/fs/ext3/xattr_security.c =