On Mon, 25 Feb 2008 14:49:22 -0800
Andrew Morton <[EMAIL PROTECTED]> wrote:
> Please feed the diff through scritps/checkpatch.pl and consider addressing
> the things which it finds.
I checked that, but I didn't think any of them were worth fixing. And
since this is a work in progress and a in a s
Hey, Pekka,
A couple of little things I noticed...
> +static int post_kmmio_handler(unsigned long condition, struct pt_regs *regs)
> +{
> + int ret = 0;
> + struct kmmio_probe *probe;
> + struct kmmio_fault_page *faultpage;
> + struct kmmio_context *ctx = &get_cpu_var(kmmio_ctx);
On Mon, Feb 25, 2008 at 09:42:00PM -0500, Pavel Roskin wrote:
> It looks like a mutex, it acts like a mutex, but it isn't a mutex, it's a
> trap for the unwary. Weird. I was annoyed by it before; now I see a
> fellow developer actually getting into that trap.
>
> I'd say, rename DECLARE_MUTEX t
On Tue, Feb 26, 2008 at 11:49:48AM +0100, Ingo Molnar wrote:
>
> * Andy Whitcroft <[EMAIL PROTECTED]> wrote:
>
> > Ok, so that would be the following, work for everyone?
> >
> > WARNING: mutexes are preferred for single holder semaphores
> > #1: FILE: Z95.c:1:
> > + DECLARE_MUTEX(&foo);
>
* Andy Whitcroft <[EMAIL PROTECTED]> wrote:
> Ok, so that would be the following, work for everyone?
>
> WARNING: mutexes are preferred for single holder semaphores
> #1: FILE: Z95.c:1:
> + DECLARE_MUTEX(&foo);
>
> WARNING: mutexes are preferred for single holder semaphores
> #3: FILE: Z9
On Mon, Feb 25, 2008 at 06:34:49PM -0500, Christoph Hellwig wrote:
> On Mon, Feb 25, 2008 at 02:49:22PM -0800, Andrew Morton wrote:
> > the things which it finds.
> >
> > > +static DECLARE_MUTEX(kmmio_init_mutex);
> >
> > That's not a mutex.
> >
> > > + down(&kmmio_init_mutex);
> >
> > It's a s
On Mon, Feb 25, 2008 at 09:42:00PM -0500, Pavel Roskin wrote:
> Quoting Christoph Hellwig <[EMAIL PROTECTED]>:
>
> >On Mon, Feb 25, 2008 at 02:49:22PM -0800, Andrew Morton wrote:
> >>the things which it finds.
> >>
> >>> +static DECLARE_MUTEX(kmmio_init_mutex);
> >>
> >>That's not a mutex.
> >>
>
Quoting Christoph Hellwig <[EMAIL PROTECTED]>:
On Mon, Feb 25, 2008 at 02:49:22PM -0800, Andrew Morton wrote:
the things which it finds.
> +static DECLARE_MUTEX(kmmio_init_mutex);
That's not a mutex.
> + down(&kmmio_init_mutex);
It's a semaphore. Please do convert it to a mutex.
Andy, I'
On Mon, Feb 25, 2008 at 02:49:22PM -0800, Andrew Morton wrote:
> the things which it finds.
>
> > +static DECLARE_MUTEX(kmmio_init_mutex);
>
> That's not a mutex.
>
> > + down(&kmmio_init_mutex);
>
> It's a semaphore. Please do convert it to a mutex.
>
> Andy, I'd say that addition of new s
On Sun, 24 Feb 2008 19:03:23 +0200 Pekka Paalanen <[EMAIL PROTECTED]> wrote:
> arch/x86/Kconfig.debug | 33 +++
> arch/x86/mm/Makefile|5 +
> arch/x86/mm/fault.c | 13 +
> arch/x86/mm/kmmio.c | 541
> +++
> arch/x86/mm
Hi Pekka.
A small nitpick..
>
> +config MMIOTRACE_HOOKS
> + bool
> + default n
n is default so no need to be explicit.
If you prefer being explcit then use:
def_bool n
> +config MMIOTRACE
> + tristate "Memory mapped IO tracing"
> + depends on DEBUG_KERNEL && RELAY && DE
Hi all,
I have finally got kmmio.c into shape so that it is built in when mmiotrace
is built. I'd like to hear your comments on kmmio.c.
kmmio.c handles the list of mmio probes with callbacks, list of traced
pages, and attaching into the page fault handler and die notifier. It
arms, traps and dis
12 matches
Mail list logo
