Re: [RFC] pci_bus conversion to struct device

2007-01-29 Thread Jesse Barnes
On Saturday, January 27, 2007 8:19 am, Matthew Wilcox wrote: > > There are also some "legacy io" binary sysfs files in these > > directories for those platforms that support it (#ifdef > > HAVE_PCI_LEGACY), and I'm guessing that there is some user for them > > out there, otherwise they would not

Re: [RFC] pci_bus conversion to struct device

2007-01-29 Thread Jesse Barnes
On Saturday, January 27, 2007 8:19 am, Matthew Wilcox wrote: There are also some legacy io binary sysfs files in these directories for those platforms that support it (#ifdef HAVE_PCI_LEGACY), and I'm guessing that there is some user for them out there, otherwise they would not have been

Re: [RFC] pci_bus conversion to struct device

2007-01-27 Thread Matthew Wilcox
On Thu, Jan 18, 2007 at 01:00:44AM -0800, Greg KH wrote: > On Thu, Jan 18, 2007 at 09:14:06AM +0100, Martin Mares wrote: > > Hello! > > > > > I recommend we just delete the pci_bus class. I don't think it serves > > > any useful purpose. The bridge can be inferred frmo the sysfs hierarchy > > >

Re: [RFC] pci_bus conversion to struct device

2007-01-27 Thread Matthew Wilcox
On Thu, Jan 18, 2007 at 11:58:05PM -0700, Grant Grundler wrote: > Other per bus attributes might be address routing, VGA routing enabled, > Fast-back-to-back enabled. PCI-X bridges and PCI-e bridges might also > advertise data related to MMRBC and similar onboard buffer mgt behaviors. > > ISTR,

Re: [RFC] pci_bus conversion to struct device

2007-01-27 Thread Matthew Wilcox
On Thu, Jan 18, 2007 at 11:58:05PM -0700, Grant Grundler wrote: Other per bus attributes might be address routing, VGA routing enabled, Fast-back-to-back enabled. PCI-X bridges and PCI-e bridges might also advertise data related to MMRBC and similar onboard buffer mgt behaviors. ISTR, IBM

Re: [RFC] pci_bus conversion to struct device

2007-01-27 Thread Matthew Wilcox
On Thu, Jan 18, 2007 at 01:00:44AM -0800, Greg KH wrote: On Thu, Jan 18, 2007 at 09:14:06AM +0100, Martin Mares wrote: Hello! I recommend we just delete the pci_bus class. I don't think it serves any useful purpose. The bridge can be inferred frmo the sysfs hierarchy (not to

Re: [RFC] pci_bus conversion to struct device

2007-01-23 Thread Benjamin Herrenschmidt
On Tue, 2007-01-23 at 16:22 -0800, Tim Pepper wrote: > On 1/18/07, Greg KH <[EMAIL PROTECTED]> wrote: > > > Hm, only ia64 enables that option. Matthew, do you care about those > > files? > > Given the ia64 nature, unless benh was truly wanting to do something > or ppc64, IBM's big NUMA boxes

Re: [RFC] pci_bus conversion to struct device

2007-01-23 Thread Tim Pepper
On 1/18/07, Greg KH <[EMAIL PROTECTED]> wrote: Hm, only ia64 enables that option. Matthew, do you care about those files? Given the ia64 nature, unless benh was truly wanting to do something or ppc64, IBM's big NUMA boxes are pretty unlikely to care. Tim - To unsubscribe from this list:

Re: [RFC] pci_bus conversion to struct device

2007-01-23 Thread Tim Pepper
On 1/18/07, Greg KH [EMAIL PROTECTED] wrote: Hm, only ia64 enables that option. Matthew, do you care about those files? Given the ia64 nature, unless benh was truly wanting to do something or ppc64, IBM's big NUMA boxes are pretty unlikely to care. Tim - To unsubscribe from this list: send

Re: [RFC] pci_bus conversion to struct device

2007-01-23 Thread Benjamin Herrenschmidt
On Tue, 2007-01-23 at 16:22 -0800, Tim Pepper wrote: On 1/18/07, Greg KH [EMAIL PROTECTED] wrote: Hm, only ia64 enables that option. Matthew, do you care about those files? Given the ia64 nature, unless benh was truly wanting to do something or ppc64, IBM's big NUMA boxes are pretty

Re: [RFC] pci_bus conversion to struct device

2007-01-18 Thread Grant Grundler
On Thu, Jan 18, 2007 at 09:14:06AM +0100, Martin Mares wrote: > Hello! > > > I recommend we just delete the pci_bus class. I don't think it serves > > any useful purpose. The bridge can be inferred frmo the sysfs hierarchy > > (not to mention lspci will tell you). The cpuaffinity file should

Re: [RFC] pci_bus conversion to struct device

2007-01-18 Thread Martin Mares
Hello! > So, if it were to stay, where in the tree should it be? Hanging off of > the pci device that is the bridge? Or just placing these files within > the pci device directory itself, as it is the bridge. I originally didn't realize that we already represent devices on the subordinate bus

Re: [RFC] pci_bus conversion to struct device

2007-01-18 Thread Jesse Barnes
On Thursday, January 18, 2007 1:00 am, Greg KH wrote: > On Thu, Jan 18, 2007 at 09:14:06AM +0100, Martin Mares wrote: > > Hello! > > > > > I recommend we just delete the pci_bus class. I don't think it > > > serves any useful purpose. The bridge can be inferred frmo the > > > sysfs hierarchy

Re: [RFC] pci_bus conversion to struct device

2007-01-18 Thread Greg KH
On Thu, Jan 18, 2007 at 09:14:06AM +0100, Martin Mares wrote: > Hello! > > > I recommend we just delete the pci_bus class. I don't think it serves > > any useful purpose. The bridge can be inferred frmo the sysfs hierarchy > > (not to mention lspci will tell you). The cpuaffinity file should

Re: [RFC] pci_bus conversion to struct device

2007-01-18 Thread Martin Mares
Hello! > I recommend we just delete the pci_bus class. I don't think it serves > any useful purpose. The bridge can be inferred frmo the sysfs hierarchy > (not to mention lspci will tell you). The cpuaffinity file should be > moved from the bus to the device -- it really doesn't make any sense

Re: [RFC] pci_bus conversion to struct device

2007-01-18 Thread Martin Mares
Hello! I recommend we just delete the pci_bus class. I don't think it serves any useful purpose. The bridge can be inferred frmo the sysfs hierarchy (not to mention lspci will tell you). The cpuaffinity file should be moved from the bus to the device -- it really doesn't make any sense to

Re: [RFC] pci_bus conversion to struct device

2007-01-18 Thread Greg KH
On Thu, Jan 18, 2007 at 09:14:06AM +0100, Martin Mares wrote: Hello! I recommend we just delete the pci_bus class. I don't think it serves any useful purpose. The bridge can be inferred frmo the sysfs hierarchy (not to mention lspci will tell you). The cpuaffinity file should be

Re: [RFC] pci_bus conversion to struct device

2007-01-18 Thread Jesse Barnes
On Thursday, January 18, 2007 1:00 am, Greg KH wrote: On Thu, Jan 18, 2007 at 09:14:06AM +0100, Martin Mares wrote: Hello! I recommend we just delete the pci_bus class. I don't think it serves any useful purpose. The bridge can be inferred frmo the sysfs hierarchy (not to mention

Re: [RFC] pci_bus conversion to struct device

2007-01-18 Thread Martin Mares
Hello! So, if it were to stay, where in the tree should it be? Hanging off of the pci device that is the bridge? Or just placing these files within the pci device directory itself, as it is the bridge. I originally didn't realize that we already represent devices on the subordinate bus as

Re: [RFC] pci_bus conversion to struct device

2007-01-18 Thread Grant Grundler
On Thu, Jan 18, 2007 at 09:14:06AM +0100, Martin Mares wrote: Hello! I recommend we just delete the pci_bus class. I don't think it serves any useful purpose. The bridge can be inferred frmo the sysfs hierarchy (not to mention lspci will tell you). The cpuaffinity file should be

Re: [RFC] pci_bus conversion to struct device

2007-01-17 Thread Greg KH
On Wed, Jan 17, 2007 at 07:23:52PM -0700, Matthew Wilcox wrote: > On Wed, Jan 17, 2007 at 04:53:45PM -0800, Greg KH wrote: > > I'm trying to clean up all the usages of struct class_device to use > > struct device, and I ran into the pci_bus code. Right now you create a > > symlink called "bridge"

Re: [RFC] pci_bus conversion to struct device

2007-01-17 Thread Matthew Wilcox
On Wed, Jan 17, 2007 at 04:53:45PM -0800, Greg KH wrote: > I'm trying to clean up all the usages of struct class_device to use > struct device, and I ran into the pci_bus code. Right now you create a > symlink called "bridge" under the /sys/class/pci_bus/:XX/ directory > to the pci device

[RFC] pci_bus conversion to struct device

2007-01-17 Thread Greg KH
Hi Matt, I'm trying to clean up all the usages of struct class_device to use struct device, and I ran into the pci_bus code. Right now you create a symlink called "bridge" under the /sys/class/pci_bus/:XX/ directory to the pci device that is the bridge. This is messy to try to convert to

[RFC] pci_bus conversion to struct device

2007-01-17 Thread Greg KH
Hi Matt, I'm trying to clean up all the usages of struct class_device to use struct device, and I ran into the pci_bus code. Right now you create a symlink called bridge under the /sys/class/pci_bus/:XX/ directory to the pci device that is the bridge. This is messy to try to convert to

Re: [RFC] pci_bus conversion to struct device

2007-01-17 Thread Matthew Wilcox
On Wed, Jan 17, 2007 at 04:53:45PM -0800, Greg KH wrote: I'm trying to clean up all the usages of struct class_device to use struct device, and I ran into the pci_bus code. Right now you create a symlink called bridge under the /sys/class/pci_bus/:XX/ directory to the pci device that is

Re: [RFC] pci_bus conversion to struct device

2007-01-17 Thread Greg KH
On Wed, Jan 17, 2007 at 07:23:52PM -0700, Matthew Wilcox wrote: On Wed, Jan 17, 2007 at 04:53:45PM -0800, Greg KH wrote: I'm trying to clean up all the usages of struct class_device to use struct device, and I ran into the pci_bus code. Right now you create a symlink called bridge under