Re: [RFC] workqueue: remove manual lockdep uses to detect deadlocks

2017-08-29 Thread Peter Zijlstra
On Wed, Aug 30, 2017 at 10:53:39AM +0900, Byungchul Park wrote: > On Tue, Aug 29, 2017 at 08:57:27PM +0200, Peter Zijlstra wrote: > > On Sat, Aug 26, 2017 at 12:49:26AM +0900, Byungchul Park wrote: > > > > However, how would it distinguish things like flushing another work > > > > > > I think it m

Re: [RFC] workqueue: remove manual lockdep uses to detect deadlocks

2017-08-29 Thread Byungchul Park
On Tue, Aug 29, 2017 at 08:57:27PM +0200, Peter Zijlstra wrote: > On Sat, Aug 26, 2017 at 12:49:26AM +0900, Byungchul Park wrote: > > > However, how would it distinguish things like flushing another work > > > > I think it must be distinguished with what it actually waits for, e.i. > > completion

Re: [RFC] workqueue: remove manual lockdep uses to detect deadlocks

2017-08-29 Thread Peter Zijlstra
On Sat, Aug 26, 2017 at 12:49:26AM +0900, Byungchul Park wrote: > > However, how would it distinguish things like flushing another work > > I think it must be distinguished with what it actually waits for, e.i. > completion > variables instead of work or wq. I will make it next week and let you kn

Re: [RFC] workqueue: remove manual lockdep uses to detect deadlocks

2017-08-28 Thread Byungchul Park
yes, I want to resend after working it more carefully. > > > > Could you let me know your opinions about this? > > > > ->8- > > From 448360c343477fff63df766544eec4620657a59e Mon Sep 17 00:00:00 2001 > > From: Byungchul Park > > Date: Fri, 25 A

Re: [RFC] workqueue: remove manual lockdep uses to detect deadlocks

2017-08-28 Thread Byungchul Park
yes, I want to resend after working it more carefully. > > > > Could you let me know your opinions about this? > > > > ->8- > > From 448360c343477fff63df766544eec4620657a59e Mon Sep 17 00:00:00 2001 > > From: Byungchul Park > > Date: Fri, 25 A

Re: [RFC] workqueue: remove manual lockdep uses to detect deadlocks

2017-08-28 Thread Byungchul Park
nt to resend after working it more carefully. >> >> Could you let me know your opinions about this? >> >> ->8- >> From 448360c343477fff63df766544eec4620657a59e Mon Sep 17 00:00:00 2001 >> From: Byungchul Park >> Date: Fri, 25 Aug 2017 17:35:07 +

Re: [RFC] workqueue: remove manual lockdep uses to detect deadlocks

2017-08-27 Thread Peter Zijlstra
ions about this? > > ->8- > From 448360c343477fff63df766544eec4620657a59e Mon Sep 17 00:00:00 2001 > From: Byungchul Park > Date: Fri, 25 Aug 2017 17:35:07 +0900 > Subject: [RFC] workqueue: remove manual lockdep uses to detect deadlocks > > We intro

Re: [RFC] workqueue: remove manual lockdep uses to detect deadlocks

2017-08-25 Thread Byungchul Park
nt to resend after working it more carefully. >> >> Could you let me know your opinions about this? >> >> ->8- >> From 448360c343477fff63df766544eec4620657a59e Mon Sep 17 00:00:00 2001 >> From: Byungchul Park >> Date: Fri, 25 Aug 2017 17:35:07 +0900 >&g

Re: [RFC] workqueue: remove manual lockdep uses to detect deadlocks

2017-08-25 Thread Tejun Heo
ions about this? > > ->8- > From 448360c343477fff63df766544eec4620657a59e Mon Sep 17 00:00:00 2001 > From: Byungchul Park > Date: Fri, 25 Aug 2017 17:35:07 +0900 > Subject: [RFC] workqueue: remove manual lockdep uses to detect deadlocks > > We intro

Re: [RFC] workqueue: remove manual lockdep uses to detect deadlocks

2017-08-25 Thread Byungchul Park
r opinions about this? +cc o...@redhat.com +cc da...@fromorbit.com > ->8- > >From 448360c343477fff63df766544eec4620657a59e Mon Sep 17 00:00:00 2001 > From: Byungchul Park > Date: Fri, 25 Aug 2017 17:35:07 +0900 > Subject: [RFC] workqueue: remove manual lockdep uses to detect

[RFC] workqueue: remove manual lockdep uses to detect deadlocks

2017-08-25 Thread Byungchul Park
0 2001 From: Byungchul Park Date: Fri, 25 Aug 2017 17:35:07 +0900 Subject: [RFC] workqueue: remove manual lockdep uses to detect deadlocks We introduced the following commit to detect deadlocks caused by wait_for_completion() in flush_{workqueue, work}() and other locks. But now LOCKDEP_COM