Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-09-02 Thread Jacopo Mondi
Hi Pavel, On Sun, Sep 01, 2019 at 07:24:57PM +0200, Pavel Machek wrote: > Hi! > > > > @@ -510,6 +510,29 @@ enum v4l2_scene_mode - > > > value down. A value of zero stops the motion if one is in > > > progress > > > and has no effect otherwise. > > > > > >

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-09-02 Thread Laurent Pinchart
Hi Pawel, On Mon, Sep 02, 2019 at 10:27:39AM +0200, Pavel Machek wrote: > On Mon 2019-09-02 11:19:42, Laurent Pinchart wrote: > > On Mon, Sep 02, 2019 at 10:06:57AM +0200, Pavel Machek wrote: > > Single integer. It's read-only, so it just reports the location. > > > > It would be

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-09-02 Thread Pavel Machek
On Mon 2019-09-02 11:19:42, Laurent Pinchart wrote: > On Mon, Sep 02, 2019 at 10:06:57AM +0200, Pavel Machek wrote: > > >>> Single integer. It's read-only, so it just reports the location. > > >>> > > >>> It would be different if this was a writable control: then you need to > > >>> know which

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-09-02 Thread Laurent Pinchart
On Mon, Sep 02, 2019 at 10:06:57AM +0200, Pavel Machek wrote: > >>> Single integer. It's read-only, so it just reports the location. > >>> > >>> It would be different if this was a writable control: then you need to > >>> know which locations are possible to set, and that requires a menu type. >

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-09-02 Thread Pavel Machek
Hi! > > > Single integer. It's read-only, so it just reports the location. > > > > > > It would be different if this was a writable control: then you need to > > > know which locations are possible to set, and that requires a menu type. > > > > > > But it doesn't make sense to set the location

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-09-02 Thread Laurent Pinchart
Hi Pavel, On Sun, Sep 01, 2019 at 07:24:57PM +0200, Pavel Machek wrote: > >> @@ -510,6 +510,29 @@ enum v4l2_scene_mode - > >> value down. A value of zero stops the motion if one is in progress > >> and has no effect otherwise. > >> > >> +``V4L2_CID_LOCATION

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-09-01 Thread Pavel Machek
Hi! > > @@ -510,6 +510,29 @@ enum v4l2_scene_mode - > > value down. A value of zero stops the motion if one is in progress > > and has no effect otherwise. > > > > +``V4L2_CID_LOCATION (integer)`` > > Maybe V4L2_CID_CAMERA_SENSOR_LOCATION ? Same for the

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Sakari Ailus
Hi Hans, On Thu, Aug 15, 2019 at 04:40:03PM +0200, Hans Verkuil wrote: > On 8/15/19 4:34 PM, Jacopo Mondi wrote: > > Hi Hans, > > > > On Thu, Aug 15, 2019 at 04:14:38PM +0200, Hans Verkuil wrote: > >> On 8/15/19 4:10 PM, Hans Verkuil wrote: > >>> On 8/15/19 12:43 AM, Laurent Pinchart wrote: >

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Hans Verkuil
On 8/15/19 4:34 PM, Jacopo Mondi wrote: > Hi Hans, > > On Thu, Aug 15, 2019 at 04:14:38PM +0200, Hans Verkuil wrote: >> On 8/15/19 4:10 PM, Hans Verkuil wrote: >>> On 8/15/19 12:43 AM, Laurent Pinchart wrote: Hi Jacopo, Thank you for the patch. On Wed, Aug 14, 2019 at

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Jacopo Mondi
Hi Hans, On Thu, Aug 15, 2019 at 04:14:38PM +0200, Hans Verkuil wrote: > On 8/15/19 4:10 PM, Hans Verkuil wrote: > > On 8/15/19 12:43 AM, Laurent Pinchart wrote: > >> Hi Jacopo, > >> > >> Thank you for the patch. > >> > >> On Wed, Aug 14, 2019 at 10:28:12PM +0200, Jacopo Mondi wrote: > >>> Add

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Hans Verkuil
On 8/15/19 4:10 PM, Hans Verkuil wrote: > On 8/15/19 12:43 AM, Laurent Pinchart wrote: >> Hi Jacopo, >> >> Thank you for the patch. >> >> On Wed, Aug 14, 2019 at 10:28:12PM +0200, Jacopo Mondi wrote: >>> Add documentation for the V4L2_CID_LOCATION camera control. The newly >>> added read-only

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Hans Verkuil
On 8/15/19 12:43 AM, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Wed, Aug 14, 2019 at 10:28:12PM +0200, Jacopo Mondi wrote: >> Add documentation for the V4L2_CID_LOCATION camera control. The newly >> added read-only control reports the camera device mounting

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Jacopo Mondi
Hi Hans, On Thu, Aug 15, 2019 at 03:30:59PM +0200, Hans Verkuil wrote: > On 8/14/19 10:28 PM, Jacopo Mondi wrote: > > Add documentation for the V4L2_CID_LOCATION camera control. The newly > > added read-only control reports the camera device mounting position. > > > > Signed-off-by: Jacopo Mondi

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Laurent Pinchart
Hi Hans, On Thu, Aug 15, 2019 at 03:30:59PM +0200, Hans Verkuil wrote: > On 8/14/19 10:28 PM, Jacopo Mondi wrote: > > Add documentation for the V4L2_CID_LOCATION camera control. The newly > > added read-only control reports the camera device mounting position. > > > > Signed-off-by: Jacopo Mondi

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Hans Verkuil
On 8/14/19 10:28 PM, Jacopo Mondi wrote: > Add documentation for the V4L2_CID_LOCATION camera control. The newly > added read-only control reports the camera device mounting position. > > Signed-off-by: Jacopo Mondi > --- > .../media/uapi/v4l/ext-ctrls-camera.rst | 23 +++

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Laurent Pinchart
On Thu, Aug 15, 2019 at 04:15:10PM +0300, Sakari Ailus wrote: > On Thu, Aug 15, 2019 at 04:10:53PM +0300, Laurent Pinchart wrote: > > On Thu, Aug 15, 2019 at 04:08:49PM +0300, Sakari Ailus wrote: > >> On Thu, Aug 15, 2019 at 03:59:38PM +0300, Laurent Pinchart wrote: > >>> On Thu, Aug 15, 2019 at

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Sakari Ailus
On Thu, Aug 15, 2019 at 04:10:53PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Thu, Aug 15, 2019 at 04:08:49PM +0300, Sakari Ailus wrote: > > On Thu, Aug 15, 2019 at 03:59:38PM +0300, Laurent Pinchart wrote: > > > On Thu, Aug 15, 2019 at 10:00:25AM +0300, Sakari Ailus wrote: > > > > On

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Laurent Pinchart
Hi Sakari, On Thu, Aug 15, 2019 at 04:08:49PM +0300, Sakari Ailus wrote: > On Thu, Aug 15, 2019 at 03:59:38PM +0300, Laurent Pinchart wrote: > > On Thu, Aug 15, 2019 at 10:00:25AM +0300, Sakari Ailus wrote: > > > On Wed, Aug 14, 2019 at 10:28:12PM +0200, Jacopo Mondi wrote: > > > > Add

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Sakari Ailus
On Thu, Aug 15, 2019 at 03:59:38PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Thu, Aug 15, 2019 at 10:00:25AM +0300, Sakari Ailus wrote: > > On Wed, Aug 14, 2019 at 10:28:12PM +0200, Jacopo Mondi wrote: > > > Add documentation for the V4L2_CID_LOCATION camera control. The newly > > >

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Laurent Pinchart
Hi Sakari, On Thu, Aug 15, 2019 at 10:00:25AM +0300, Sakari Ailus wrote: > On Wed, Aug 14, 2019 at 10:28:12PM +0200, Jacopo Mondi wrote: > > Add documentation for the V4L2_CID_LOCATION camera control. The newly > > added read-only control reports the camera device mounting position. > > > >

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Jacopo Mondi
Hi Laurent, On Thu, Aug 15, 2019 at 01:43:40AM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Wed, Aug 14, 2019 at 10:28:12PM +0200, Jacopo Mondi wrote: > > Add documentation for the V4L2_CID_LOCATION camera control. The newly > > added read-only control reports

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-15 Thread Sakari Ailus
Hi Jacopo, On Wed, Aug 14, 2019 at 10:28:12PM +0200, Jacopo Mondi wrote: > Add documentation for the V4L2_CID_LOCATION camera control. The newly > added read-only control reports the camera device mounting position. > > Signed-off-by: Jacopo Mondi > --- >

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-14 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Wed, Aug 14, 2019 at 10:28:12PM +0200, Jacopo Mondi wrote: > Add documentation for the V4L2_CID_LOCATION camera control. The newly > added read-only control reports the camera device mounting position. > > Signed-off-by: Jacopo Mondi > --- >

[RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-14 Thread Jacopo Mondi
Add documentation for the V4L2_CID_LOCATION camera control. The newly added read-only control reports the camera device mounting position. Signed-off-by: Jacopo Mondi --- .../media/uapi/v4l/ext-ctrls-camera.rst | 23 +++ 1 file changed, 23 insertions(+) diff --git