Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-11 Thread Borislav Petkov
On Thu, Apr 10, 2014 at 12:09:03PM +0200, Michal Simek wrote: > The question here is. This driver is just reporting problem through > edac interface which is counting that errors and provide an unified > way how to report problems. Yes, normally you can use edac for reporting and error counting. B

Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-10 Thread Michal Simek
Hi Borislav, >> My question is if using printk in IRQ handler and report problem is >> equal to reporting this via edac interface. Or it is just easy way >> to do but using edac interface is right solution and how to do it >> properly is different question. > > Yeah, it would probably be easier i

Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-10 Thread Borislav Petkov
On Thu, Apr 10, 2014 at 08:12:17AM +0200, Michal Simek wrote: > I am just curious about this recommendation. Does it mean that we > shouldn't use edac interface just for reporting problems? Yes, we should. But, if you want to have two different drivers accessing the hardware and have to build sync

Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-09 Thread Michal Simek
On 04/09/2014 07:47 PM, Borislav Petkov wrote: > On Wed, Apr 09, 2014 at 10:59:49PM +0530, Punnaiah Choudary wrote: >> There is a driver file cache-l2x0.c under arch/arm/mm for pl310 cache >> configuration and management. Russel king had suggested to use >> single driver file for both pl310 edac im

Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-09 Thread Borislav Petkov
On Wed, Apr 09, 2014 at 10:59:49PM +0530, Punnaiah Choudary wrote: > There is a driver file cache-l2x0.c under arch/arm/mm for pl310 cache > configuration and management. Russel king had suggested to use > single driver file for both pl310 edac implementation and cache-l2x0.c > Here is the thread >

Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-09 Thread Punnaiah Choudary
There is a driver file cache-l2x0.c under arch/arm/mm for pl310 cache configuration and management. Russel king had suggested to use single driver file for both pl310 edac implementation and cache-l2x0.c Here is the thread http://www.spinics.net/lists/arm-kernel/msg320407.html please provide your

Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-09 Thread Borislav Petkov
On Wed, Apr 09, 2014 at 08:18:28AM -0500, Rob Herring wrote: > I don't think so, the PL310 is present on lots of ARM chips besides > Xilinx. I don't know how many support parity as that is optional. In > fact the highbank_l2_edac.c is for the PL310 as well, but the > registers it uses is all custom

Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-09 Thread Rob Herring
On Wed, Apr 9, 2014 at 6:32 AM, Borislav Petkov wrote: > On Sun, Mar 02, 2014 at 08:02:40PM +0530, Punnaiah Choudary Kalluri wrote: >> Add support for ARM Pl310 L2 cache controller parity error >> >> Signed-off-by: Punnaiah Choudary Kalluri >> --- >> .../devicetree/bindings/edac/pl310_edac_l2.tx

Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-09 Thread Borislav Petkov
On Sun, Mar 02, 2014 at 08:02:40PM +0530, Punnaiah Choudary Kalluri wrote: > Add support for ARM Pl310 L2 cache controller parity error > > Signed-off-by: Punnaiah Choudary Kalluri > --- > .../devicetree/bindings/edac/pl310_edac_l2.txt | 19 ++ > drivers/edac/Kconfig

Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-03 Thread Michal Simek
On 04/03/2014 05:24 PM, Borislav Petkov wrote: > On Thu, Apr 03, 2014 at 05:02:30PM +0200, Michal Simek wrote: >> Any comment about this driver? > > It is all on the TODO list. I'll take a look after the merge window > closes. Ok. Thank you, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> Key

Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-03 Thread Borislav Petkov
On Thu, Apr 03, 2014 at 05:02:30PM +0200, Michal Simek wrote: > Any comment about this driver? It is all on the TODO list. I'll take a look after the merge window closes. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from thi

Re: [RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-04-03 Thread Michal Simek
Hi Borislav, On 03/02/2014 03:32 PM, Punnaiah Choudary Kalluri wrote: > Add support for ARM Pl310 L2 cache controller parity error > > Signed-off-by: Punnaiah Choudary Kalluri > --- > .../devicetree/bindings/edac/pl310_edac_l2.txt | 19 ++ > drivers/edac/Kconfig

[RFC PATCH] edac: add support for ARM PL310 L2 cache parity

2014-03-02 Thread Punnaiah Choudary Kalluri
Add support for ARM Pl310 L2 cache controller parity error Signed-off-by: Punnaiah Choudary Kalluri --- .../devicetree/bindings/edac/pl310_edac_l2.txt | 19 ++ drivers/edac/Kconfig |7 + drivers/edac/Makefile |1 + drivers/