Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-04 Thread Boris Brezillon
On Thu, 04 Oct 2018 16:11:42 +0200 Janusz Krzysztofik wrote: > > Legacy nand_wait_ready() uses a hardcoded timeout value of 400 ms. Should > we > follow the same approach in nand_gpio_waitrdy(), or should we rather let > drivers pass the timeout value, like in case of nand_soft_waitrdy()?

Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-04 Thread Boris Brezillon
On Thu, 04 Oct 2018 16:11:42 +0200 Janusz Krzysztofik wrote: > > Legacy nand_wait_ready() uses a hardcoded timeout value of 400 ms. Should > we > follow the same approach in nand_gpio_waitrdy(), or should we rather let > drivers pass the timeout value, like in case of nand_soft_waitrdy()?

Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-04 Thread Janusz Krzysztofik
On Thursday, October 4, 2018 3:59:33 PM CEST Boris Brezillon wrote: > On Thu, 04 Oct 2018 15:52:57 +0200 > Janusz Krzysztofik wrote: > > > Hi Boris, > > > > On Wednesday, October 3, 2018 4:06:34 PM CEST Boris Brezillon wrote: > > > On Wed, 03 Oct 2018 15:55:25 +0200 > > > Janusz Krzysztofik

Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-04 Thread Janusz Krzysztofik
On Thursday, October 4, 2018 3:59:33 PM CEST Boris Brezillon wrote: > On Thu, 04 Oct 2018 15:52:57 +0200 > Janusz Krzysztofik wrote: > > > Hi Boris, > > > > On Wednesday, October 3, 2018 4:06:34 PM CEST Boris Brezillon wrote: > > > On Wed, 03 Oct 2018 15:55:25 +0200 > > > Janusz Krzysztofik

Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-04 Thread Boris Brezillon
On Thu, 04 Oct 2018 15:52:57 +0200 Janusz Krzysztofik wrote: > Hi Boris, > > On Wednesday, October 3, 2018 4:06:34 PM CEST Boris Brezillon wrote: > > On Wed, 03 Oct 2018 15:55:25 +0200 > > Janusz Krzysztofik wrote: > > > > > > > > > > > > Implementation of NAND_OP_WAITRDY_INSTR has been

Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-04 Thread Boris Brezillon
On Thu, 04 Oct 2018 15:52:57 +0200 Janusz Krzysztofik wrote: > Hi Boris, > > On Wednesday, October 3, 2018 4:06:34 PM CEST Boris Brezillon wrote: > > On Wed, 03 Oct 2018 15:55:25 +0200 > > Janusz Krzysztofik wrote: > > > > > > > > > > > > Implementation of NAND_OP_WAITRDY_INSTR has been

Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-04 Thread Janusz Krzysztofik
Hi Boris, On Wednesday, October 3, 2018 4:06:34 PM CEST Boris Brezillon wrote: > On Wed, 03 Oct 2018 15:55:25 +0200 > Janusz Krzysztofik wrote: > > > > > > > > > Implementation of NAND_OP_WAITRDY_INSTR has been based on legacy > > > > nand_wait_ready(), > > > > > > I don't remember what

Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-04 Thread Janusz Krzysztofik
Hi Boris, On Wednesday, October 3, 2018 4:06:34 PM CEST Boris Brezillon wrote: > On Wed, 03 Oct 2018 15:55:25 +0200 > Janusz Krzysztofik wrote: > > > > > > > > > Implementation of NAND_OP_WAITRDY_INSTR has been based on legacy > > > > nand_wait_ready(), > > > > > > I don't remember what

Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-03 Thread Boris Brezillon
On Wed, 03 Oct 2018 15:55:25 +0200 Janusz Krzysztofik wrote: > > > > > > Implementation of NAND_OP_WAITRDY_INSTR has been based on legacy > > > nand_wait_ready(), > > > > I don't remember what the ams-delta ->dev_ready()/->waitfunc() hooks > > are doing, but is shouldn't be too hard to

Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-03 Thread Boris Brezillon
On Wed, 03 Oct 2018 15:55:25 +0200 Janusz Krzysztofik wrote: > > > > > > Implementation of NAND_OP_WAITRDY_INSTR has been based on legacy > > > nand_wait_ready(), > > > > I don't remember what the ams-delta ->dev_ready()/->waitfunc() hooks > > are doing, but is shouldn't be too hard to

Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-03 Thread Janusz Krzysztofik
On Wednesday, October 3, 2018 2:30:54 PM CEST Boris Brezillon wrote: > Hi Janusz, > > On Wed, 3 Oct 2018 14:00:28 +0200 > Janusz Krzysztofik wrote: > > > Replace legacy callbacks with ->select_chip() and ->exec_op(). > > Thanks for working on that, that's really appreciated. > > > > >

Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-03 Thread Janusz Krzysztofik
On Wednesday, October 3, 2018 2:30:54 PM CEST Boris Brezillon wrote: > Hi Janusz, > > On Wed, 3 Oct 2018 14:00:28 +0200 > Janusz Krzysztofik wrote: > > > Replace legacy callbacks with ->select_chip() and ->exec_op(). > > Thanks for working on that, that's really appreciated. > > > > >

Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-03 Thread Boris Brezillon
Hi Janusz, On Wed, 3 Oct 2018 14:00:28 +0200 Janusz Krzysztofik wrote: > Replace legacy callbacks with ->select_chip() and ->exec_op(). Thanks for working on that, that's really appreciated. > > Implementation of NAND_OP_WAITRDY_INSTR has been based on legacy > nand_wait_ready(), I don't

Re: [RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-03 Thread Boris Brezillon
Hi Janusz, On Wed, 3 Oct 2018 14:00:28 +0200 Janusz Krzysztofik wrote: > Replace legacy callbacks with ->select_chip() and ->exec_op(). Thanks for working on that, that's really appreciated. > > Implementation of NAND_OP_WAITRDY_INSTR has been based on legacy > nand_wait_ready(), I don't

[RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-03 Thread Janusz Krzysztofik
Replace legacy callbacks with ->select_chip() and ->exec_op(). Implementation of NAND_OP_WAITRDY_INSTR has been based on legacy nand_wait_ready(), otherwise that function would probabaly have to be reimplemented inside the driver. Hence, legacy callback ->dev_ready() is still used. Use of

[RFC PATCH] mtd: rawnand: ams-delta: use ->exec_op()

2018-10-03 Thread Janusz Krzysztofik
Replace legacy callbacks with ->select_chip() and ->exec_op(). Implementation of NAND_OP_WAITRDY_INSTR has been based on legacy nand_wait_ready(), otherwise that function would probabaly have to be reimplemented inside the driver. Hence, legacy callback ->dev_ready() is still used. Use of