Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-18 Thread Kishon Vijay Abraham I
Hi, On Friday 14 June 2013 06:04 PM, Laxman Dewangan wrote: On Wednesday 12 June 2013 08:53 PM, g...@slimlogic.co.uk wrote: On 2013-06-12 15:51, Mark Brown wrote: On Wed, Jun 12, 2013 at 03:31:09PM +0100, g...@slimlogic.co.uk wrote: On 2013-06-12 15:14, Mark Brown wrote: Yes, that seems

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-18 Thread Kishon Vijay Abraham I
Hi, On Friday 14 June 2013 06:04 PM, Laxman Dewangan wrote: On Wednesday 12 June 2013 08:53 PM, g...@slimlogic.co.uk wrote: On 2013-06-12 15:51, Mark Brown wrote: On Wed, Jun 12, 2013 at 03:31:09PM +0100, g...@slimlogic.co.uk wrote: On 2013-06-12 15:14, Mark Brown wrote: Yes, that seems

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-14 Thread Laxman Dewangan
On Wednesday 12 June 2013 08:53 PM, g...@slimlogic.co.uk wrote: On 2013-06-12 15:51, Mark Brown wrote: On Wed, Jun 12, 2013 at 03:31:09PM +0100, g...@slimlogic.co.uk wrote: On 2013-06-12 15:14, Mark Brown wrote: Yes, that seems like the most obvious thing here as far as I can tell >from the

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-14 Thread Laxman Dewangan
On Wednesday 12 June 2013 08:53 PM, g...@slimlogic.co.uk wrote: On 2013-06-12 15:51, Mark Brown wrote: On Wed, Jun 12, 2013 at 03:31:09PM +0100, g...@slimlogic.co.uk wrote: On 2013-06-12 15:14, Mark Brown wrote: Yes, that seems like the most obvious thing here as far as I can tell from the

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-12 Thread gg
On 2013-06-12 15:51, Mark Brown wrote: On Wed, Jun 12, 2013 at 03:31:09PM +0100, g...@slimlogic.co.uk wrote: On 2013-06-12 15:14, Mark Brown wrote: >Yes, that seems like the most obvious thing here as far as I can tell >from the frankly fragmented and obscure information but given all the

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-12 Thread Mark Brown
On Wed, Jun 12, 2013 at 03:31:09PM +0100, g...@slimlogic.co.uk wrote: > On 2013-06-12 15:14, Mark Brown wrote: > >Yes, that seems like the most obvious thing here as far as I can tell > >from the frankly fragmented and obscure information but given all the > >confusion that seems to exist among

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-12 Thread gg
On 2013-06-12 15:14, Mark Brown wrote: On Wed, Jun 12, 2013 at 02:12:07PM +0530, Laxman Dewangan wrote: I think ff we really want to abstract this stuff then we should have the two different regulator SMPS10-OUT1 and SMPS-OUT2 as there is physically two pins in the device for output and

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-12 Thread Mark Brown
On Wed, Jun 12, 2013 at 02:12:07PM +0530, Laxman Dewangan wrote: > I think ff we really want to abstract this stuff then we should have > the two different regulator SMPS10-OUT1 and SMPS-OUT2 as there is > physically two pins in the device for output and controlled > different way. Yes, that

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-12 Thread Laxman Dewangan
On Monday 10 June 2013 06:19 PM, Mark Brown wrote: * PGP Signed by an unknown key On Mon, Jun 10, 2013 at 04:33:04PM +0530, Kishon Vijay Abraham I wrote: IIUC, normal enable should be when output is driven through OUT2. I'm sorry but you're really not making much sense at all here. You say

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-12 Thread Laxman Dewangan
On Monday 10 June 2013 06:19 PM, Mark Brown wrote: * PGP Signed by an unknown key On Mon, Jun 10, 2013 at 04:33:04PM +0530, Kishon Vijay Abraham I wrote: IIUC, normal enable should be when output is driven through OUT2. I'm sorry but you're really not making much sense at all here. You say

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-12 Thread Mark Brown
On Wed, Jun 12, 2013 at 02:12:07PM +0530, Laxman Dewangan wrote: I think ff we really want to abstract this stuff then we should have the two different regulator SMPS10-OUT1 and SMPS-OUT2 as there is physically two pins in the device for output and controlled different way. Yes, that seems

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-12 Thread gg
On 2013-06-12 15:14, Mark Brown wrote: On Wed, Jun 12, 2013 at 02:12:07PM +0530, Laxman Dewangan wrote: I think ff we really want to abstract this stuff then we should have the two different regulator SMPS10-OUT1 and SMPS-OUT2 as there is physically two pins in the device for output and

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-12 Thread Mark Brown
On Wed, Jun 12, 2013 at 03:31:09PM +0100, g...@slimlogic.co.uk wrote: On 2013-06-12 15:14, Mark Brown wrote: Yes, that seems like the most obvious thing here as far as I can tell from the frankly fragmented and obscure information but given all the confusion that seems to exist among the

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-12 Thread gg
On 2013-06-12 15:51, Mark Brown wrote: On Wed, Jun 12, 2013 at 03:31:09PM +0100, g...@slimlogic.co.uk wrote: On 2013-06-12 15:14, Mark Brown wrote: Yes, that seems like the most obvious thing here as far as I can tell from the frankly fragmented and obscure information but given all the

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-10 Thread Mark Brown
On Mon, Jun 10, 2013 at 04:33:04PM +0530, Kishon Vijay Abraham I wrote: > On Monday 10 June 2013 03:33 PM, Mark Brown wrote: > >On Mon, Jun 10, 2013 at 03:20:06PM +0530, Kishon Vijay Abraham I wrote: > >>SMPS10 has two outputs OUT2 and OUT1. In order to connect OUT2 to > >>OUT1 we have to set

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-10 Thread Kishon Vijay Abraham I
Hi, On Monday 10 June 2013 03:33 PM, Mark Brown wrote: On Mon, Jun 10, 2013 at 03:20:06PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 04 June 2013 03:35 PM, Mark Brown wrote: On Tue, Jun 04, 2013 at 03:13:27PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 04 June 2013 03:08 PM, Mark

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-10 Thread Mark Brown
On Mon, Jun 10, 2013 at 03:20:06PM +0530, Kishon Vijay Abraham I wrote: > On Tuesday 04 June 2013 03:35 PM, Mark Brown wrote: > >On Tue, Jun 04, 2013 at 03:13:27PM +0530, Kishon Vijay Abraham I wrote: > >>On Tuesday 04 June 2013 03:08 PM, Mark Brown wrote: > >>>No. A boost regulator is still a

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-10 Thread Kishon Vijay Abraham I
Hi, On Tuesday 04 June 2013 03:35 PM, Mark Brown wrote: On Tue, Jun 04, 2013 at 03:13:27PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 04 June 2013 03:08 PM, Mark Brown wrote: No. A boost regulator is still a voltage regulator, it just happens to raise rather than lower the voltage but

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-10 Thread Kishon Vijay Abraham I
Hi, On Tuesday 04 June 2013 03:35 PM, Mark Brown wrote: On Tue, Jun 04, 2013 at 03:13:27PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 04 June 2013 03:08 PM, Mark Brown wrote: No. A boost regulator is still a voltage regulator, it just happens to raise rather than lower the voltage but

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-10 Thread Mark Brown
On Mon, Jun 10, 2013 at 03:20:06PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 04 June 2013 03:35 PM, Mark Brown wrote: On Tue, Jun 04, 2013 at 03:13:27PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 04 June 2013 03:08 PM, Mark Brown wrote: No. A boost regulator is still a voltage

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-10 Thread Kishon Vijay Abraham I
Hi, On Monday 10 June 2013 03:33 PM, Mark Brown wrote: On Mon, Jun 10, 2013 at 03:20:06PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 04 June 2013 03:35 PM, Mark Brown wrote: On Tue, Jun 04, 2013 at 03:13:27PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 04 June 2013 03:08 PM, Mark

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-10 Thread Mark Brown
On Mon, Jun 10, 2013 at 04:33:04PM +0530, Kishon Vijay Abraham I wrote: On Monday 10 June 2013 03:33 PM, Mark Brown wrote: On Mon, Jun 10, 2013 at 03:20:06PM +0530, Kishon Vijay Abraham I wrote: SMPS10 has two outputs OUT2 and OUT1. In order to connect OUT2 to OUT1 we have to set SWITCH_EN

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-04 Thread Mark Brown
On Tue, Jun 04, 2013 at 03:13:27PM +0530, Kishon Vijay Abraham I wrote: > On Tuesday 04 June 2013 03:08 PM, Mark Brown wrote: > >No. A boost regulator is still a voltage regulator, it just happens to > >raise rather than lower the voltage but it's otherwise a normal > >regulator. I'm not sure

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-04 Thread Kishon Vijay Abraham I
Hi, On Tuesday 04 June 2013 03:08 PM, Mark Brown wrote: On Tue, Jun 04, 2013 at 02:38:08PM +0530, Kishon Vijay Abraham I wrote: On Sunday 02 June 2013 02:35 AM, Mark Brown wrote: This is still not making any sense. The quality of regulation and output voltage are essentially orthogonal,

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-04 Thread Mark Brown
On Tue, Jun 04, 2013 at 02:38:08PM +0530, Kishon Vijay Abraham I wrote: > On Sunday 02 June 2013 02:35 AM, Mark Brown wrote: > >This is still not making any sense. The quality of regulation and > >output voltage are essentially orthogonal, and obviously there's a > >specific API for bypass which

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-04 Thread Kishon Vijay Abraham I
Hi, On Sunday 02 June 2013 02:35 AM, Mark Brown wrote: On Sun, Jun 02, 2013 at 12:33:10AM +0530, Laxman Dewangan wrote: On Sunday 02 June 2013 12:15 AM, Mark Brown wrote: No, that makes no sense at all to me. Why do you think this maps onto the set mode API? Modes are all about accuracy

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-04 Thread Kishon Vijay Abraham I
Hi, On Sunday 02 June 2013 02:35 AM, Mark Brown wrote: On Sun, Jun 02, 2013 at 12:33:10AM +0530, Laxman Dewangan wrote: On Sunday 02 June 2013 12:15 AM, Mark Brown wrote: No, that makes no sense at all to me. Why do you think this maps onto the set mode API? Modes are all about accuracy

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-04 Thread Mark Brown
On Tue, Jun 04, 2013 at 02:38:08PM +0530, Kishon Vijay Abraham I wrote: On Sunday 02 June 2013 02:35 AM, Mark Brown wrote: This is still not making any sense. The quality of regulation and output voltage are essentially orthogonal, and obviously there's a specific API for bypass which is

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-04 Thread Kishon Vijay Abraham I
Hi, On Tuesday 04 June 2013 03:08 PM, Mark Brown wrote: On Tue, Jun 04, 2013 at 02:38:08PM +0530, Kishon Vijay Abraham I wrote: On Sunday 02 June 2013 02:35 AM, Mark Brown wrote: This is still not making any sense. The quality of regulation and output voltage are essentially orthogonal,

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-04 Thread Mark Brown
On Tue, Jun 04, 2013 at 03:13:27PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 04 June 2013 03:08 PM, Mark Brown wrote: No. A boost regulator is still a voltage regulator, it just happens to raise rather than lower the voltage but it's otherwise a normal regulator. I'm not sure what you

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-01 Thread Mark Brown
On Sun, Jun 02, 2013 at 12:33:10AM +0530, Laxman Dewangan wrote: > On Sunday 02 June 2013 12:15 AM, Mark Brown wrote: > >No, that makes no sense at all to me. Why do you think this maps onto > >the set mode API? Modes are all about accuracy of regulation. > I mapped this to the regulation

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-01 Thread Laxman Dewangan
On Sunday 02 June 2013 12:15 AM, Mark Brown wrote: * PGP Signed by an unknown key On Thu, May 30, 2013 at 06:30:32PM +0530, Laxman Dewangan wrote: Palma have SMPS10 regulator which can generate two voltage level 3.75 and 5V. This SMPS10 has the two outputs OUT1 and OUT2 and having one input

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-01 Thread Mark Brown
On Thu, May 30, 2013 at 06:30:32PM +0530, Laxman Dewangan wrote: > Palma have SMPS10 regulator which can generate two voltage level > 3.75 and 5V. > This SMPS10 has the two outputs OUT1 and OUT2 and having one input IN1. > SMPS10-OUT2 is always connected to SMPS10-IN1 via following logic: > -

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-01 Thread Mark Brown
On Thu, May 30, 2013 at 06:24:37PM +0530, Kishon Vijay Abraham I wrote: > On Thursday 30 May 2013 05:02 PM, Mark Brown wrote: > >On Thu, May 30, 2013 at 04:26:33PM +0530, Kishon Vijay Abraham I wrote: > >>Only compile tested. Just sent a patch to get some comments > >>/ideas on how to handle such

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-01 Thread Mark Brown
On Thu, May 30, 2013 at 06:24:37PM +0530, Kishon Vijay Abraham I wrote: On Thursday 30 May 2013 05:02 PM, Mark Brown wrote: On Thu, May 30, 2013 at 04:26:33PM +0530, Kishon Vijay Abraham I wrote: Only compile tested. Just sent a patch to get some comments /ideas on how to handle such one off

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-01 Thread Mark Brown
On Thu, May 30, 2013 at 06:30:32PM +0530, Laxman Dewangan wrote: Palma have SMPS10 regulator which can generate two voltage level 3.75 and 5V. This SMPS10 has the two outputs OUT1 and OUT2 and having one input IN1. SMPS10-OUT2 is always connected to SMPS10-IN1 via following logic: - Through

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-01 Thread Laxman Dewangan
On Sunday 02 June 2013 12:15 AM, Mark Brown wrote: * PGP Signed by an unknown key On Thu, May 30, 2013 at 06:30:32PM +0530, Laxman Dewangan wrote: Palma have SMPS10 regulator which can generate two voltage level 3.75 and 5V. This SMPS10 has the two outputs OUT1 and OUT2 and having one input

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-06-01 Thread Mark Brown
On Sun, Jun 02, 2013 at 12:33:10AM +0530, Laxman Dewangan wrote: On Sunday 02 June 2013 12:15 AM, Mark Brown wrote: No, that makes no sense at all to me. Why do you think this maps onto the set mode API? Modes are all about accuracy of regulation. I mapped this to the regulation under

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-05-30 Thread Laxman Dewangan
HI Mark, On Thursday 30 May 2013 05:02 PM, Mark Brown wrote: * PGP Signed by an unknown key On Thu, May 30, 2013 at 04:26:33PM +0530, Kishon Vijay Abraham I wrote: Only compile tested. Just sent a patch to get some comments /ideas on how to handle such one off regulators. to handle What's

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-05-30 Thread Kishon Vijay Abraham I
Hi, On Thursday 30 May 2013 05:02 PM, Mark Brown wrote: On Thu, May 30, 2013 at 04:26:33PM +0530, Kishon Vijay Abraham I wrote: Only compile tested. Just sent a patch to get some comments /ideas on how to handle such one off regulators. to handle What's unclear or confusing? This all looks

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-05-30 Thread Mark Brown
On Thu, May 30, 2013 at 04:26:33PM +0530, Kishon Vijay Abraham I wrote: > Only compile tested. Just sent a patch to get some comments > /ideas on how to handle such one off regulators. > to handle What's unclear or confusing? This all looks really basic... > +

[RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-05-30 Thread Kishon Vijay Abraham I
SMPS10 supports different modes such as BOOST mode, BYPASS mode and SWITCH. Inorder to configure SMPS10 in these modes, added palmas_set_mode_smps10() and palmas_get_mode_smps10() for the consumers of SMPS10 to configure it accordingly. Signed-off-by: Kishon Vijay Abraham I --- Only compile

[RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-05-30 Thread Kishon Vijay Abraham I
SMPS10 supports different modes such as BOOST mode, BYPASS mode and SWITCH. Inorder to configure SMPS10 in these modes, added palmas_set_mode_smps10() and palmas_get_mode_smps10() for the consumers of SMPS10 to configure it accordingly. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- Only

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-05-30 Thread Mark Brown
On Thu, May 30, 2013 at 04:26:33PM +0530, Kishon Vijay Abraham I wrote: Only compile tested. Just sent a patch to get some comments /ideas on how to handle such one off regulators. to handle What's unclear or confusing? This all looks really basic... + palmas_smps_read(pmic-palmas,

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-05-30 Thread Kishon Vijay Abraham I
Hi, On Thursday 30 May 2013 05:02 PM, Mark Brown wrote: On Thu, May 30, 2013 at 04:26:33PM +0530, Kishon Vijay Abraham I wrote: Only compile tested. Just sent a patch to get some comments /ideas on how to handle such one off regulators. to handle What's unclear or confusing? This all looks

Re: [RFC PATCH] regulator: palmas: enable all modes for SMPS10

2013-05-30 Thread Laxman Dewangan
HI Mark, On Thursday 30 May 2013 05:02 PM, Mark Brown wrote: * PGP Signed by an unknown key On Thu, May 30, 2013 at 04:26:33PM +0530, Kishon Vijay Abraham I wrote: Only compile tested. Just sent a patch to get some comments /ideas on how to handle such one off regulators. to handle What's