Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-29 Thread Sricharan R
Hi Bjorn, On 5/29/2018 9:37 AM, Bjorn Andersson wrote: > On Wed 23 May 07:48 PDT 2018, Sricharan R wrote: >> On 5/23/2018 1:07 PM, Vinod wrote: >>> On 22-05-18, 23:58, Bjorn Andersson wrote: On Tue 22 May 23:05 PDT 2018, Vinod wrote: > On 22-05-18, 22:20, Bjorn Andersson wrote: > [..]

Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-29 Thread Sricharan R
Hi Bjorn, On 5/29/2018 9:37 AM, Bjorn Andersson wrote: > On Wed 23 May 07:48 PDT 2018, Sricharan R wrote: >> On 5/23/2018 1:07 PM, Vinod wrote: >>> On 22-05-18, 23:58, Bjorn Andersson wrote: On Tue 22 May 23:05 PDT 2018, Vinod wrote: > On 22-05-18, 22:20, Bjorn Andersson wrote: > [..]

Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-28 Thread Bjorn Andersson
On Wed 23 May 07:48 PDT 2018, Sricharan R wrote: > On 5/23/2018 1:07 PM, Vinod wrote: > > On 22-05-18, 23:58, Bjorn Andersson wrote: > >> On Tue 22 May 23:05 PDT 2018, Vinod wrote: > >>> On 22-05-18, 22:20, Bjorn Andersson wrote: [..] > >>> Looking at the patch, few other comments would be

Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-28 Thread Bjorn Andersson
On Wed 23 May 07:48 PDT 2018, Sricharan R wrote: > On 5/23/2018 1:07 PM, Vinod wrote: > > On 22-05-18, 23:58, Bjorn Andersson wrote: > >> On Tue 22 May 23:05 PDT 2018, Vinod wrote: > >>> On 22-05-18, 22:20, Bjorn Andersson wrote: [..] > >>> Looking at the patch, few other comments would be

Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-23 Thread Sricharan R
Hi Bjorn, On 5/23/2018 1:07 PM, Vinod wrote: > On 22-05-18, 23:58, Bjorn Andersson wrote: >> On Tue 22 May 23:05 PDT 2018, Vinod wrote: >> >>> On 22-05-18, 22:20, Bjorn Andersson wrote: >>> +static int q6v5_wcss_reset(struct q6v5_wcss *wcss) +{ + int ret; + u32 val; +

Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-23 Thread Sricharan R
Hi Bjorn, On 5/23/2018 1:07 PM, Vinod wrote: > On 22-05-18, 23:58, Bjorn Andersson wrote: >> On Tue 22 May 23:05 PDT 2018, Vinod wrote: >> >>> On 22-05-18, 22:20, Bjorn Andersson wrote: >>> +static int q6v5_wcss_reset(struct q6v5_wcss *wcss) +{ + int ret; + u32 val; +

Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-23 Thread Vinod
On 22-05-18, 23:58, Bjorn Andersson wrote: > On Tue 22 May 23:05 PDT 2018, Vinod wrote: > > > On 22-05-18, 22:20, Bjorn Andersson wrote: > > > > > +static int q6v5_wcss_reset(struct q6v5_wcss *wcss) > > > +{ > > > + int ret; > > > + u32 val; > > > + int i; > > > + > > > + /* Assert resets, stop

Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-23 Thread Vinod
On 22-05-18, 23:58, Bjorn Andersson wrote: > On Tue 22 May 23:05 PDT 2018, Vinod wrote: > > > On 22-05-18, 22:20, Bjorn Andersson wrote: > > > > > +static int q6v5_wcss_reset(struct q6v5_wcss *wcss) > > > +{ > > > + int ret; > > > + u32 val; > > > + int i; > > > + > > > + /* Assert resets, stop

Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-23 Thread Bjorn Andersson
On Tue 22 May 23:05 PDT 2018, Vinod wrote: > On 22-05-18, 22:20, Bjorn Andersson wrote: > > > +static int q6v5_wcss_reset(struct q6v5_wcss *wcss) > > +{ > > + int ret; > > + u32 val; > > + int i; > > + > > + /* Assert resets, stop core */ > > + val = readl(wcss->reg_base +

Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-23 Thread Bjorn Andersson
On Tue 22 May 23:05 PDT 2018, Vinod wrote: > On 22-05-18, 22:20, Bjorn Andersson wrote: > > > +static int q6v5_wcss_reset(struct q6v5_wcss *wcss) > > +{ > > + int ret; > > + u32 val; > > + int i; > > + > > + /* Assert resets, stop core */ > > + val = readl(wcss->reg_base +

Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-23 Thread Vinod
On 22-05-18, 22:20, Bjorn Andersson wrote: > +static int q6v5_wcss_reset(struct q6v5_wcss *wcss) > +{ > + int ret; > + u32 val; > + int i; > + > + /* Assert resets, stop core */ > + val = readl(wcss->reg_base + QDSP6SS_RESET_REG); > + val |= Q6SS_CORE_ARES |

Re: [RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-23 Thread Vinod
On 22-05-18, 22:20, Bjorn Andersson wrote: > +static int q6v5_wcss_reset(struct q6v5_wcss *wcss) > +{ > + int ret; > + u32 val; > + int i; > + > + /* Assert resets, stop core */ > + val = readl(wcss->reg_base + QDSP6SS_RESET_REG); > + val |= Q6SS_CORE_ARES |

[RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-22 Thread Bjorn Andersson
From: Sricharan R IPQ8074 has an integrated Hexagon dsp core q6v5 and a wireless lan (Lithium) IP. An mdt type single image format is used for the firmware. So the mdt_load function can be directly used to load the firmware. Also add the relevant resets required for

[RFC PATCH 5/5] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver

2018-05-22 Thread Bjorn Andersson
From: Sricharan R IPQ8074 has an integrated Hexagon dsp core q6v5 and a wireless lan (Lithium) IP. An mdt type single image format is used for the firmware. So the mdt_load function can be directly used to load the firmware. Also add the relevant resets required for this core. Signed-off-by: