Re: [RFC PATCH v2 13/17] sched: Add core wide task selection and scheduling.

2019-05-21 Thread Vineeth Pillai
> > Please try this and see how it compares with the vanilla v2. I think its > > time for a v3 now and we shall be posting it soon after some more > > testing and benchmarking. > > Is there any potential change between pre v3 and v3? I prefer working > based on v3 so that everyone are on the same p

Re: [RFC PATCH v2 13/17] sched: Add core wide task selection and scheduling.

2019-05-21 Thread Aubrey Li
On Mon, May 20, 2019 at 10:04 PM Vineeth Pillai wrote: > > > > The following patch improved my test cases. > > > Welcome any comments. > > > > > > > This is certainly better than violating the point of the core scheduler :) > > > > If I'm understanding this right what will happen in this case is i

Re: [RFC PATCH v2 13/17] sched: Add core wide task selection and scheduling.

2019-05-20 Thread Vineeth Pillai
> > The following patch improved my test cases. > > Welcome any comments. > > > > This is certainly better than violating the point of the core scheduler :) > > If I'm understanding this right what will happen in this case is instead > of using the idle process selected by the sibling we do the cor

Re: [RFC PATCH v2 13/17] sched: Add core wide task selection and scheduling.

2019-05-20 Thread Phil Auld
On Sat, May 18, 2019 at 11:37:56PM +0800 Aubrey Li wrote: > On Wed, Apr 24, 2019 at 12:18 AM Vineeth Remanan Pillai > wrote: > > > > From: Peter Zijlstra (Intel) > > > > Instead of only selecting a local task, select a task for all SMT > > siblings for every reschedule on the core (irrespective w

Re: [RFC PATCH v2 13/17] sched: Add core wide task selection and scheduling.

2019-05-18 Thread Aubrey Li
On Wed, Apr 24, 2019 at 12:18 AM Vineeth Remanan Pillai wrote: > > From: Peter Zijlstra (Intel) > > Instead of only selecting a local task, select a task for all SMT > siblings for every reschedule on the core (irrespective which logical > CPU does the reschedule). > > NOTE: there is still potent

Re: [RFC PATCH v2 13/17] sched: Add core wide task selection and scheduling.

2019-04-29 Thread Aaron Lu
On Tue, Apr 23, 2019 at 04:18:18PM +, Vineeth Remanan Pillai wrote: > +// XXX fairness/fwd progress conditions > +static struct task_struct * > +pick_task(struct rq *rq, const struct sched_class *class, struct task_struct > *max) > +{ > + struct task_struct *class_pick, *cookie_pick; > +

[RFC PATCH v2 13/17] sched: Add core wide task selection and scheduling.

2019-04-23 Thread Vineeth Remanan Pillai
From: Peter Zijlstra (Intel) Instead of only selecting a local task, select a task for all SMT siblings for every reschedule on the core (irrespective which logical CPU does the reschedule). NOTE: there is still potential for siblings rivalry. NOTE: this is far too complicated; but thus far I've