[RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-27 Thread Sowjanya Komatineni
CSI MIPI pads need to be enabled and calibrated for capturing from the external sensor or transmitter. MIPI CAL unit calibrates MIPI pads pull-up, pull-down and termination impedances. Calibration is done by co-work of MIPI BIAS pad and MIPI CAL control unit. Triggering calibration start can happ

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Dmitry Osipenko
28.07.2020 18:59, Sowjanya Komatineni пишет: ... >>> +    ret = tegra_mipi_finish_calibration(csi_chan->mipi); >>> +    if (ret < 0) >>> +    dev_err(csi_chan->csi->dev, >>> +    "MIPI calibration failed: %d\n", ret); >> Doesn't v4l2_subdev_call(OFF) need to be invoked h

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 4:25 PM, Dmitry Osipenko wrote: 28.07.2020 18:59, Sowjanya Komatineni пишет: ... +    ret = tegra_mipi_finish_calibration(csi_chan->mipi); +    if (ret < 0) +    dev_err(csi_chan->csi->dev, +    "MIPI calibration failed: %d\n", ret); Doesn't v4l2_subdev_

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 4:59 PM, Sowjanya Komatineni wrote: On 7/29/20 4:25 PM, Dmitry Osipenko wrote: 28.07.2020 18:59, Sowjanya Komatineni пишет: ... +    ret = tegra_mipi_finish_calibration(csi_chan->mipi); +    if (ret < 0) +    dev_err(csi_chan->csi->dev, +    "MIPI calib

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 5:27 PM, Sowjanya Komatineni wrote: On 7/29/20 4:59 PM, Sowjanya Komatineni wrote: On 7/29/20 4:25 PM, Dmitry Osipenko wrote: 28.07.2020 18:59, Sowjanya Komatineni пишет: ... +    ret = tegra_mipi_finish_calibration(csi_chan->mipi); +    if (ret < 0) +    dev_err

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Dmitry Osipenko
30.07.2020 03:27, Sowjanya Komatineni пишет: ... >>> Secondly, perhaps a failed calibration isn't a very critical error? >>> Hence just printing a warning message should be enough. >> >> Using dev_err to report calibration failure. Are you suggesting to use >> dev_warn instead of dev_err? I meant

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 5:43 PM, Dmitry Osipenko wrote: 30.07.2020 03:27, Sowjanya Komatineni пишет: ... Secondly, perhaps a failed calibration isn't a very critical error? Hence just printing a warning message should be enough. Using dev_err to report calibration failure. Are you suggesting to use dev_wa

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 5:52 PM, Sowjanya Komatineni wrote: On 7/29/20 5:43 PM, Dmitry Osipenko wrote: 30.07.2020 03:27, Sowjanya Komatineni пишет: ... Secondly, perhaps a failed calibration isn't a very critical error? Hence just printing a warning message should be enough. Using dev_err to report cali

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Dmitry Osipenko
30.07.2020 03:55, Sowjanya Komatineni пишет: > > On 7/29/20 5:52 PM, Sowjanya Komatineni wrote: >> >> On 7/29/20 5:43 PM, Dmitry Osipenko wrote: >>> 30.07.2020 03:27, Sowjanya Komatineni пишет: >>> ... >> Secondly, perhaps a failed calibration isn't a very critical error? >> Hence just pri

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Sowjanya Komatineni
On 7/29/20 5:53 PM, Dmitry Osipenko wrote: 30.07.2020 03:55, Sowjanya Komatineni пишет: On 7/29/20 5:52 PM, Sowjanya Komatineni wrote: On 7/29/20 5:43 PM, Dmitry Osipenko wrote: 30.07.2020 03:27, Sowjanya Komatineni пишет: ... Secondly, perhaps a failed calibration isn't a very critical err

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-29 Thread Dmitry Osipenko
30.07.2020 04:06, Sowjanya Komatineni пишет: ... > Will have v6 and add additional patch at the end to do enable/disable > separately. > > Separating this out with additional patch before adding sensor support > patch requires all patches to be updated. > > So I am ok either ways. Please let me k

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-28 Thread Dmitry Osipenko
27.07.2020 23:57, Sowjanya Komatineni пишет: > + /* > + * TRM has incorrectly documented to wait for done status from > + * calibration logic after CSI interface power on. > + * As per the design, calibration results are latched and applied > + * to the pads only when the li

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-28 Thread Sowjanya Komatineni
On 7/28/20 3:30 AM, Dmitry Osipenko wrote: 27.07.2020 23:57, Sowjanya Komatineni пишет: + /* +* TRM has incorrectly documented to wait for done status from +* calibration logic after CSI interface power on. +* As per the design, calibration results are latched and

Re: [RFC PATCH v5 13/14] media: tegra-video: Add CSI MIPI pads calibration

2020-07-28 Thread Sowjanya Komatineni
On 7/28/20 8:59 AM, Sowjanya Komatineni wrote: On 7/28/20 3:30 AM, Dmitry Osipenko wrote: 27.07.2020 23:57, Sowjanya Komatineni пишет: +    /* + * TRM has incorrectly documented to wait for done status from + * calibration logic after CSI interface power on. + * As per the design