Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-12 Thread Marc Zyngier
On Thu, 11 Aug 2016 14:23:53 -0700 Bjorn Andersson wrote: Hi Bjorn, > On Thu 11 Aug 05:46 PDT 2016, Marc Zyngier wrote: > > > On 11/08/16 10:47, Jon Hunter wrote: > > > > > > On 11/08/16 09:37, Marc Zyngier wrote: > > >> On 08/08/16 22:48, Linus Walleij wrote: > > >>> On Sat, Aug 6, 2016

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-11 Thread Bjorn Andersson
On Thu 11 Aug 05:46 PDT 2016, Marc Zyngier wrote: > On 11/08/16 10:47, Jon Hunter wrote: > > > > On 11/08/16 09:37, Marc Zyngier wrote: > >> On 08/08/16 22:48, Linus Walleij wrote: > >>> On Sat, Aug 6, 2016 at 1:45 AM, John Stultz > >>> wrote: > >>> > @@ -614,7 +615,11 @@ unsigned int irq_

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-11 Thread Linus Walleij
On Thu, Aug 11, 2016 at 2:46 PM, Marc Zyngier wrote: > Nailed the sucker: > > diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c > index b4c1bc7..9d7284a 100644 > --- a/kernel/irq/chip.c > +++ b/kernel/irq/chip.c > @@ -820,6 +820,18 @@ __irq_do_set_handler(struct irq_desc *desc, > irq_flow_handl

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-11 Thread Marc Zyngier
On 11/08/16 16:32, John Stultz wrote: > On Thu, Aug 11, 2016 at 5:46 AM, Marc Zyngier wrote: > >> Nailed the sucker: >> >> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c >> index b4c1bc7..9d7284a 100644 >> --- a/kernel/irq/chip.c >> +++ b/kernel/irq/chip.c >> @@ -820,6 +820,18 @@ __irq_do_set_

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-11 Thread John Stultz
On Thu, Aug 11, 2016 at 5:46 AM, Marc Zyngier wrote: > On 11/08/16 10:47, Jon Hunter wrote: >> >> On 11/08/16 09:37, Marc Zyngier wrote: >>> On 08/08/16 22:48, Linus Walleij wrote: On Sat, Aug 6, 2016 at 1:45 AM, John Stultz wrote: > @@ -614,7 +615,11 @@ unsigned int irq_create_fwsp

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-11 Thread Marc Zyngier
On 11/08/16 14:29, Jon Hunter wrote: > > On 11/08/16 13:46, Marc Zyngier wrote: >> On 11/08/16 10:47, Jon Hunter wrote: >>> >>> On 11/08/16 09:37, Marc Zyngier wrote: On 08/08/16 22:48, Linus Walleij wrote: > On Sat, Aug 6, 2016 at 1:45 AM, John Stultz > wrote: > >> @@ -614,

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-11 Thread Jon Hunter
On 11/08/16 13:46, Marc Zyngier wrote: > On 11/08/16 10:47, Jon Hunter wrote: >> >> On 11/08/16 09:37, Marc Zyngier wrote: >>> On 08/08/16 22:48, Linus Walleij wrote: On Sat, Aug 6, 2016 at 1:45 AM, John Stultz wrote: > @@ -614,7 +615,11 @@ unsigned int irq_create_fwspec_mapping(str

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-11 Thread Marc Zyngier
On 11/08/16 10:47, Jon Hunter wrote: > > On 11/08/16 09:37, Marc Zyngier wrote: >> On 08/08/16 22:48, Linus Walleij wrote: >>> On Sat, Aug 6, 2016 at 1:45 AM, John Stultz wrote: >>> @@ -614,7 +615,11 @@ unsigned int irq_create_fwspec_mapping(struct irq_fwspec *fwspec)

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-11 Thread Linus Walleij
On Thu, Aug 11, 2016 at 10:37 AM, Marc Zyngier wrote: > On 08/08/16 22:48, Linus Walleij wrote: >> On Sat, Aug 6, 2016 at 1:45 AM, John Stultz wrote: >> >>> @@ -614,7 +615,11 @@ unsigned int irq_create_fwspec_mapping(struct >>> irq_fwspec *fwspec) >>> * it now and return the inte

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-11 Thread Marc Zyngier
On 11/08/16 10:47, Jon Hunter wrote: > > On 11/08/16 09:37, Marc Zyngier wrote: >> On 08/08/16 22:48, Linus Walleij wrote: >>> On Sat, Aug 6, 2016 at 1:45 AM, John Stultz wrote: >>> @@ -614,7 +615,11 @@ unsigned int irq_create_fwspec_mapping(struct irq_fwspec *fwspec)

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-11 Thread Marc Zyngier
On 11/08/16 12:45, Marc Zyngier wrote: > On 11/08/16 10:47, Jon Hunter wrote: >> >> On 11/08/16 09:37, Marc Zyngier wrote: >>> On 08/08/16 22:48, Linus Walleij wrote: On Sat, Aug 6, 2016 at 1:45 AM, John Stultz wrote: > @@ -614,7 +615,11 @@ unsigned int irq_create_fwspec_mapping(stru

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-11 Thread Jon Hunter
On 11/08/16 09:37, Marc Zyngier wrote: > On 08/08/16 22:48, Linus Walleij wrote: >> On Sat, Aug 6, 2016 at 1:45 AM, John Stultz wrote: >> >>> @@ -614,7 +615,11 @@ unsigned int irq_create_fwspec_mapping(struct >>> irq_fwspec *fwspec) >>> * it now and return the interrupt number. >

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-11 Thread Marc Zyngier
On 08/08/16 22:48, Linus Walleij wrote: > On Sat, Aug 6, 2016 at 1:45 AM, John Stultz wrote: > >> @@ -614,7 +615,11 @@ unsigned int irq_create_fwspec_mapping(struct >> irq_fwspec *fwspec) >> * it now and return the interrupt number. >> */ >> if (i

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-10 Thread Linus Walleij
On Wed, Aug 10, 2016 at 5:17 PM, Marc Zyngier wrote: > Guess what, I just found this exact sucker in the pile of > "junk we won't ever use because it can't run mainline". > I even booted one of your test images on it. > > Do you have a tree I can clone directly, with all the ugly patches > applie

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-10 Thread Linus Walleij
On Wed, Aug 10, 2016 at 4:12 PM, Jon Hunter wrote: > Where can I see the DT source for this board? There is a > arch/arm/boot/dts/qcom-apq8060-dragonboard.dts but this does not appear > to be the same (does not have smsc911x). There: https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-inte

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-10 Thread Jon Hunter
On 10/08/16 14:58, Linus Walleij wrote: > On Wed, Aug 10, 2016 at 11:56 AM, Jon Hunter wrote: >> Hi Marc, Linus, >> On 10/08/16 10:41, Marc Zyngier wrote: >>> On 10/08/16 00:03, Linus Walleij wrote: On Tue, Aug 9, 2016 at 3:20 PM, Jon Hunter wrote: > If that works, then does the fo

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-10 Thread Marc Zyngier
Hi Linus, On 10/08/16 00:03, Linus Walleij wrote: > On Tue, Aug 9, 2016 at 3:20 PM, Jon Hunter wrote: > >> If that works, then does the following also work (without the above) ... >> >> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c >> index b4c1bc7c9ca2..e111b72e3162 100644 >> --- a/kernel/

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-10 Thread Linus Walleij
On Wed, Aug 10, 2016 at 11:56 AM, Jon Hunter wrote: > Hi Marc, Linus, > On 10/08/16 10:41, Marc Zyngier wrote: >> On 10/08/16 00:03, Linus Walleij wrote: >>> On Tue, Aug 9, 2016 at 3:20 PM, Jon Hunter wrote: >>> If that works, then does the following also work (without the above) ... >>

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-10 Thread Marc Zyngier
On 10/08/16 14:50, Linus Walleij wrote: > On Wed, Aug 10, 2016 at 11:41 AM, Marc Zyngier wrote: > >> Is this platform related to the Dragonboard 410C? I've got one from >> Sudeep, and it seems to work fine (though I've spotted a couple of >> gotchas in the DT). > > Nopes this is the ARMv7 APQ806

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-10 Thread Linus Walleij
On Wed, Aug 10, 2016 at 11:41 AM, Marc Zyngier wrote: > Is this platform related to the Dragonboard 410C? I've got one from > Sudeep, and it seems to work fine (though I've spotted a couple of > gotchas in the DT). Nopes this is the ARMv7 APQ8060, the original (first!) dragonboard. https://dflun

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-10 Thread Marc Zyngier
On 10/08/16 10:56, Jon Hunter wrote: > Hi Marc, Linus, > > On 10/08/16 10:41, Marc Zyngier wrote: >> Hi Linus, >> >> On 10/08/16 00:03, Linus Walleij wrote: >>> On Tue, Aug 9, 2016 at 3:20 PM, Jon Hunter wrote: >>> If that works, then does the following also work (without the above) ...

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-10 Thread Jon Hunter
Hi Marc, Linus, On 10/08/16 10:41, Marc Zyngier wrote: > Hi Linus, > > On 10/08/16 00:03, Linus Walleij wrote: >> On Tue, Aug 9, 2016 at 3:20 PM, Jon Hunter wrote: >> >>> If that works, then does the following also work (without the above) ... >>> >>> diff --git a/kernel/irq/chip.c b/kernel/irq/

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-09 Thread Linus Walleij
On Tue, Aug 9, 2016 at 3:20 PM, Jon Hunter wrote: > If that works, then does the following also work (without the above) ... > > diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c > index b4c1bc7c9ca2..e111b72e3162 100644 > --- a/kernel/irq/chip.c > +++ b/kernel/irq/chip.c > @@ -824,6 +824,7 @@ _

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-09 Thread Marc Zyngier
On 09/08/16 14:20, Jon Hunter wrote: > > On 09/08/16 05:25, John Stultz wrote: > > ... > >> So actually no. We usually call irqd_set_trigger_type() but something >> still doesn't work. >> >> Interestingly, just adding irq_set_irq_type(virq, type); to the top of >> that block (leaving the rest of

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-09 Thread Jon Hunter
On 09/08/16 05:25, John Stultz wrote: ... > So actually no. We usually call irqd_set_trigger_type() but something > still doesn't work. > > Interestingly, just adding irq_set_irq_type(virq, type); to the top of > that block (leaving the rest of the code) also works. Interesting. By saving the

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-08 Thread John Stultz
On Mon, Aug 8, 2016 at 2:31 AM, Jon Hunter wrote: > > On 06/08/16 00:45, John Stultz wrote: >> On Mon, Aug 1, 2016 at 3:26 AM, Jon Hunter wrote: >>> Hi John, >>> >>> On 30/07/16 05:39, John Stultz wrote: Hey Jon, So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I no

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-08 Thread Linus Walleij
On Mon, Aug 8, 2016 at 11:04 AM, Jon Hunter wrote: > I am wondering if it is related to ... > > [1.678160] apq8064-pinctrl 80.pinctrl: pin GPIO_16 already requested > by 1654.serial; cannot claim for 1658.i2c > [1.678207] apq8064-pinctrl 80.pinctrl: pin-16 (1658.i2c)

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-08 Thread Linus Walleij
On Sat, Aug 6, 2016 at 1:45 AM, John Stultz wrote: > @@ -614,7 +615,11 @@ unsigned int irq_create_fwspec_mapping(struct > irq_fwspec *fwspec) > * it now and return the interrupt number. > */ > if (irq_get_trigger_type(virq) == IRQ_TYPE_NONE) { > -

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-08 Thread Linus Walleij
On Sat, Jul 30, 2016 at 10:07 AM, Thomas Gleixner wrote: > On Fri, 29 Jul 2016, John Stultz wrote: >> Hey Jon, >> So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I >> noticed the power/volume buttons stopped working. >> >> I did a manual rebased bisection and chased it down to you

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-08 Thread Jon Hunter
On 06/08/16 00:45, John Stultz wrote: > On Mon, Aug 1, 2016 at 3:26 AM, Jon Hunter wrote: >> Hi John, >> >> On 30/07/16 05:39, John Stultz wrote: >>> Hey Jon, >>> So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I >>> noticed the power/volume buttons stopped working. >>> >>> I did

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-08 Thread Jon Hunter
On 05/08/16 19:12, John Stultz wrote: > On Sat, Jul 30, 2016 at 1:07 AM, Thomas Gleixner wrote: >> On Fri, 29 Jul 2016, John Stultz wrote: >>> Hey Jon, >>> So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I >>> noticed the power/volume buttons stopped working. >>> >>> I did a manu

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-06 Thread John Stultz
On Mon, Aug 1, 2016 at 3:26 AM, Jon Hunter wrote: > Hi John, > > On 30/07/16 05:39, John Stultz wrote: >> Hey Jon, >> So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I >> noticed the power/volume buttons stopped working. >> >> I did a manual rebased bisection and chased it down to

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-05 Thread John Stultz
On Sat, Jul 30, 2016 at 1:07 AM, Thomas Gleixner wrote: > On Fri, 29 Jul 2016, John Stultz wrote: >> Hey Jon, >> So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I >> noticed the power/volume buttons stopped working. >> >> I did a manual rebased bisection and chased it down to your

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-08-01 Thread Jon Hunter
Hi John, On 30/07/16 05:39, John Stultz wrote: > Hey Jon, > So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I > noticed the power/volume buttons stopped working. > > I did a manual rebased bisection and chased it down to your commit > 1e2a7d78499e ("irqdomain: Don't set type when

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-07-30 Thread Marc Zyngier
On Fri, 29 Jul 2016 21:52:01 -0700 Bjorn Andersson wrote: > On Fri 29 Jul 21:39 PDT 2016, John Stultz wrote: > > > Hey Jon, > > So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I > > noticed the power/volume buttons stopped working. > > > > +Linus, as that's gpio-keys on top

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-07-30 Thread Thomas Gleixner
On Fri, 29 Jul 2016, John Stultz wrote: > Hey Jon, > So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I > noticed the power/volume buttons stopped working. > > I did a manual rebased bisection and chased it down to your commit > 1e2a7d78499e ("irqdomain: Don't set type when mapping

Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-07-29 Thread Bjorn Andersson
On Fri 29 Jul 21:39 PDT 2016, John Stultz wrote: > Hey Jon, > So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I > noticed the power/volume buttons stopped working. > +Linus, as that's gpio-keys on top of two fairly standard gpio/pinctrl drivers (8064 TLMM and SSBI). Regards, Bj

[Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons

2016-07-29 Thread John Stultz
Hey Jon, So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I noticed the power/volume buttons stopped working. I did a manual rebased bisection and chased it down to your commit 1e2a7d78499e ("irqdomain: Don't set type when mapping an IRQ"). Reverting that patch makes things work a