On Wed, Aug 7, 2019 at 12:45 PM Christoph Hellwig wrote:
>
> On Wed, Aug 07, 2019 at 11:48:33AM +0200, Rafael J. Wysocki wrote:
> > So I think I know what the problem is here.
> >
> > If ASPM is disabled for the NVMe device (which is the case on my machine by
> > default),
> > skipping the
On Wed, Aug 07, 2019 at 11:48:33AM +0200, Rafael J. Wysocki wrote:
> So I think I know what the problem is here.
>
> If ASPM is disabled for the NVMe device (which is the case on my machine by
> default),
> skipping the bus-level PM in nvme_suspend() causes the PCIe link of it to
> stay up and
o: Kai-Heng Feng
> > > Cc: Rafael J. Wysocki; Limonciello, Mario; Keith Busch; Keith Busch;
> > > Christoph
> > > Hellwig; Sagi Grimberg; linux-nvme; Linux PM; Linux Kernel Mailing List;
> > > Rajat Jain
> > > Subject: Re: [Regression] Commit "nvme
On Thursday, August 1, 2019 12:19:56 AM CEST Keith Busch wrote:
> On Wed, Jul 31, 2019 at 11:25:51PM +0200, Rafael J. Wysocki wrote:
> >
> > A couple of remarks if you will.
> >
> > First, we don't know which case is the majority at this point. For
> > now, there is one example of each, but it
istoph
> > Hellwig; Sagi Grimberg; linux-nvme; Linux PM; Linux Kernel Mailing List;
> > Rajat Jain
> > Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for
> > suspend" has problems
> >
> >
> > [EXTERNAL EMAIL]
> >
>
Rajat Jain
> Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for
> suspend" has problems
>
>
> [EXTERNAL EMAIL]
>
> On Mon, Aug 5, 2019 at 9:14 PM Kai-Heng Feng
> wrote:
> >
> > at 19:04, Rafael J. Wysocki wrote:
&
Hellwig; Sagi Grimberg; linux-nvme; Linux
> >>>>> PM; Linux
> >>>>> Kernel Mailing List; Rajat Jain
> >>>>> Subject: Re: [Regression] Commit "nvme/pci: Use host managed power
> >>>>> state for
> >>>>>
; Limonciello, Mario
Cc: Keith Busch; Christoph Hellwig; Sagi Grimberg; linux-nvme; Linux
PM; Linux
Kernel Mailing List; Rajat Jain
Subject: Re: [Regression] Commit "nvme/pci: Use host managed power
state for
suspend" has problems
[EXTERNAL EMAIL]
On Thu, Aug 1, 2019 at 11:06 AM Kai-Heng F
M
> >>> To: Kai-Heng Feng; Keith Busch; Limonciello, Mario
> >>> Cc: Keith Busch; Christoph Hellwig; Sagi Grimberg; linux-nvme; Linux
> >>> PM; Linux
> >>> Kernel Mailing List; Rajat Jain
> >>> Subject: Re: [Regression] Commit
; Linux
Kernel Mailing List; Rajat Jain
Subject: Re: [Regression] Commit "nvme/pci: Use host managed power
state for
suspend" has problems
[EXTERNAL EMAIL]
On Thu, Aug 1, 2019 at 11:06 AM Kai-Heng Feng
wrote:
at 06:33, Rafael J. Wysocki wrote:
On Thu, Aug 1, 2019 at 12:22 AM K
; Linux PM;
> > Linux
> > Kernel Mailing List; Rajat Jain
> > Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for
> > suspend" has problems
> >
> >
> > [EXTERNAL EMAIL]
> >
> > On Thu, Aug 1, 2019 at 11:06
On Thu, Aug 01, 2019 at 02:05:54AM -0700, Kai-Heng Feng wrote:
> at 06:33, Rafael J. Wysocki wrote:
> > On Thu, Aug 1, 2019 at 12:22 AM Keith Busch wrote:
> >
> >> In which case we do need to reintroduce the HMB handling.
> >
> > Right.
>
> The patch alone doesn’t break HMB Toshiba NVMe I
ject: Re: [Regression] Commit "nvme/pci: Use host managed power state for
> suspend" has problems
>
>
> [EXTERNAL EMAIL]
>
> On Thu, Aug 1, 2019 at 11:06 AM Kai-Heng Feng
> wrote:
> >
> > at 06:33, Rafael J. Wysocki wrote:
> >
> > > On Thu, A
On Thu, Aug 1, 2019 at 11:06 AM Kai-Heng Feng
wrote:
>
> at 06:33, Rafael J. Wysocki wrote:
>
> > On Thu, Aug 1, 2019 at 12:22 AM Keith Busch wrote:
> >> On Wed, Jul 31, 2019 at 11:25:51PM +0200, Rafael J. Wysocki wrote:
> >>> A couple of remarks if you will.
> >>>
> >>> First, we don't know
at 06:33, Rafael J. Wysocki wrote:
On Thu, Aug 1, 2019 at 12:22 AM Keith Busch wrote:
On Wed, Jul 31, 2019 at 11:25:51PM +0200, Rafael J. Wysocki wrote:
A couple of remarks if you will.
First, we don't know which case is the majority at this point. For
now, there is one example of each,
On Thu, Aug 1, 2019 at 12:22 AM Keith Busch wrote:
>
> On Wed, Jul 31, 2019 at 11:25:51PM +0200, Rafael J. Wysocki wrote:
> >
> > A couple of remarks if you will.
> >
> > First, we don't know which case is the majority at this point. For
> > now, there is one example of each, but it may very
On Wed, Jul 31, 2019 at 11:25:51PM +0200, Rafael J. Wysocki wrote:
>
> A couple of remarks if you will.
>
> First, we don't know which case is the majority at this point. For
> now, there is one example of each, but it may very well turn out that
> the SK Hynix BC501 above needs to be quirked.
-Heng Feng
> > > Cc: Limonciello, Mario; r...@rjwysocki.net; keith.bu...@intel.com;
> > > h...@lst.de;
> > > s...@grimberg.me; linux-n...@lists.infradead.org;
> > > linux...@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; raja...@google.com
> > > S
l.com;
> > h...@lst.de;
> > s...@grimberg.me; linux-n...@lists.infradead.org; linux...@vger.kernel.org;
> > linux-kernel@vger.kernel.org; raja...@google.com
> > Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for
> > suspend" has problems
>
l.org;
> linux-kernel@vger.kernel.org; raja...@google.com
> Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for
> suspend" has problems
>
>
> [EXTERNAL EMAIL]
>
> On Wed, Jul 31, 2019 at 02:50:01AM +0800, Kai-Heng Feng wrote:
> >
> > Just
On Wed, Jul 31, 2019 at 02:50:01AM +0800, Kai-Heng Feng wrote:
>
> Just did a quick test, this patch regress SK Hynix BC501, the SoC stays at
> PC3 once the patch is applied.
Okay, I'm afraid device/platform quirks may be required unless there are
any other ideas out there.
I'm not a big fan of
: [Regression] Commit "nvme/pci: Use host managed power state
for
suspend" has problems
[EXTERNAL EMAIL]
On Tue, Jul 30, 2019 at 03:45:31AM -0700, Rafael J. Wysocki wrote:
So I can reproduce this problem with plain 5.3-rc1 and the patch below
fixes it.
Also Mario reports that the same p
: [Regression] Commit "nvme/pci: Use host managed power state for
> suspend" has problems
>
>
> [EXTERNAL EMAIL]
>
> On Tue, Jul 30, 2019 at 03:45:31AM -0700, Rafael J. Wysocki wrote:
> > So I can reproduce this problem with plain 5.3-rc1 and the patch below
On Tue, Jul 30, 2019 at 03:45:31AM -0700, Rafael J. Wysocki wrote:
> So I can reproduce this problem with plain 5.3-rc1 and the patch below fixes
> it.
>
> Also Mario reports that the same patch needs to be applied for his 9380 to
> reach
> SLP_S0 after some additional changes under
t; To: Rafael J. Wysocki
> > > Cc: Keith Busch; Christoph Hellwig; Sagi Grimberg; linux-
> > > n...@lists.infradead.org; Limonciello, Mario; Linux PM; LKML
> > > Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state
> > > for
> > > sus
erg;
> > linux-n...@lists.infradead.org; Limonciello, Mario; Linux PM; LKML
> > Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for
> > suspend" has problems
> >
> >
> > [EXTERNAL EMAIL]
> >
> > On Fri,
M; LKML
> Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for
> suspend" has problems
>
>
> [EXTERNAL EMAIL]
>
> On Fri, Jul 26, 2019 at 4:03 PM Kai-Heng Feng
> wrote:
> >
> > at 04:02, Rafael J. Wysocki wrote:
> >
> > >
On Fri, Jul 26, 2019 at 4:03 PM Kai-Heng Feng
wrote:
>
> at 04:02, Rafael J. Wysocki wrote:
>
> > On Thursday, July 25, 2019 9:52:59 PM CEST Keith Busch wrote:
> >> On Thu, Jul 25, 2019 at 09:48:57PM +0200, Rafael J. Wysocki wrote:
> >>> NVME Identify Controller:
> >>> vid : 0x1c5c
> >>>
at 04:02, Rafael J. Wysocki wrote:
On Thursday, July 25, 2019 9:52:59 PM CEST Keith Busch wrote:
On Thu, Jul 25, 2019 at 09:48:57PM +0200, Rafael J. Wysocki wrote:
NVME Identify Controller:
vid : 0x1c5c
ssvid : 0x1c5c
sn : MS92N171312902J0N
mn : PC401 NVMe SK hynix 256GB
fr
On Thursday, July 25, 2019 9:52:59 PM CEST Keith Busch wrote:
> On Thu, Jul 25, 2019 at 09:48:57PM +0200, Rafael J. Wysocki wrote:
> > NVME Identify Controller:
> > vid : 0x1c5c
> > ssvid : 0x1c5c
> > sn : MS92N171312902J0N
> > mn : PC401 NVMe SK hynix 256GB
> >
On Thu, Jul 25, 2019 at 09:48:57PM +0200, Rafael J. Wysocki wrote:
> NVME Identify Controller:
> vid : 0x1c5c
> ssvid : 0x1c5c
> sn : MS92N171312902J0N
> mn : PC401 NVMe SK hynix 256GB
> fr : 80007E00
> rab : 2
> ieee: ace42e
> cmic: 0
> mdts:
On Thursday, July 25, 2019 4:52:10 PM CEST Keith Busch wrote:
> On Thu, Jul 25, 2019 at 02:51:41AM -0700, Rafael J. Wysocki wrote:
> > Hi Keith,
> >
> > Unfortunately,
> >
> > commit d916b1be94b6dc8d293abed2451f3062f6af7551
> > Author: Keith Busch
> > Date: Thu May 23 09:27:35 2019 -0600
> >
at Jain
> Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for
> suspend" has problems
>
>
> [EXTERNAL EMAIL]
>
> at 01:03, Rafael J. Wysocki wrote:
>
> > On Thu, Jul 25, 2019 at 6:24 PM wrote:
> >> +Rajat
> >>
> >&
, Mario; Linux PM; LKML
Subject: Re: [Regression] Commit "nvme/pci: Use host managed power
state for
suspend" has problems
[EXTERNAL EMAIL]
Hi Rafael,
at 17:51, Rafael J. Wysocki wrote:
Hi Keith,
Unfortunately,
commit d916b1be94b6dc8d293abed2451f3062f6af7551
Author: Keith Busch
D
ai-Heng Feng
> > > Sent: Thursday, July 25, 2019 9:03 AM
> > > To: Rafael J. Wysocki
> > > Cc: Keith Busch; Christoph Hellwig; Sagi Grimberg; linux-
> > > n...@lists.infradead.org; Limonciello, Mario; Linux PM; LKML
> > > Subject: Re: [Regression] Commit
s.infradead.org; Limonciello, Mario; Linux PM; LKML
> > Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for
> > suspend" has problems
> >
> >
> > [EXTERNAL EMAIL]
> >
> > Hi Rafael,
> >
&g
On Thu, Jul 25, 2019 at 4:02 PM Kai-Heng Feng
wrote:
>
> Hi Rafael,
>
> at 17:51, Rafael J. Wysocki wrote:
>
> > Hi Keith,
> >
> > Unfortunately,
> >
> > commit d916b1be94b6dc8d293abed2451f3062f6af7551
> > Author: Keith Busch
> > Date: Thu May 23 09:27:35 2019 -0600
> >
> > nvme-pci: use
Commit "nvme/pci: Use host managed power state for
> suspend" has problems
>
>
> [EXTERNAL EMAIL]
>
> Hi Rafael,
>
> at 17:51, Rafael J. Wysocki wrote:
>
> > Hi Keith,
> >
> > Unfortunately,
> >
> > commit d916b1be94b6dc8d293a
On Thu, Jul 25, 2019 at 02:51:41AM -0700, Rafael J. Wysocki wrote:
> Hi Keith,
>
> Unfortunately,
>
> commit d916b1be94b6dc8d293abed2451f3062f6af7551
> Author: Keith Busch
> Date: Thu May 23 09:27:35 2019 -0600
>
> nvme-pci: use host managed power state for suspend
>
> doesn't
Hi Rafael,
at 17:51, Rafael J. Wysocki wrote:
Hi Keith,
Unfortunately,
commit d916b1be94b6dc8d293abed2451f3062f6af7551
Author: Keith Busch
Date: Thu May 23 09:27:35 2019 -0600
nvme-pci: use host managed power state for suspend
doesn't universally improve things. In fact, in some
Hi Keith,
Unfortunately,
commit d916b1be94b6dc8d293abed2451f3062f6af7551
Author: Keith Busch
Date: Thu May 23 09:27:35 2019 -0600
nvme-pci: use host managed power state for suspend
doesn't universally improve things. In fact, in some cases it makes things
worse.
For example, on the
41 matches
Mail list logo
