Re: [Resend Patch 7/9] I2C/ACPI: Add i2c ACPI operation region support

2014-04-23 Thread Lan Tianyu
On 2014年04月23日 15:28, Mika Westerberg wrote: > On Wed, Apr 23, 2014 at 09:53:21AM +0800, Lan Tianyu wrote: >> Hi Mika: >> Thanks a lot for your review. >> >> On 2014年04月22日 19:36, Mika Westerberg wrote: > + > + client.adapter = adapter; > + client.addr = sb->slave_address; > +

Re: [Resend Patch 7/9] I2C/ACPI: Add i2c ACPI operation region support

2014-04-23 Thread Mika Westerberg
On Wed, Apr 23, 2014 at 09:53:21AM +0800, Lan Tianyu wrote: > Hi Mika: > Thanks a lot for your review. > > On 2014年04月22日 19:36, Mika Westerberg wrote: > >> > + > >> > +client.adapter = adapter; > >> > +client.addr = sb->slave_address; > >> > +client.flags = 0; > > I'

Re: [Resend Patch 7/9] I2C/ACPI: Add i2c ACPI operation region support

2014-04-22 Thread Lan Tianyu
Hi Mika: Thanks a lot for your review. On 2014年04月22日 19:36, Mika Westerberg wrote: >> > + >> > + client.adapter = adapter; >> > + client.addr = sb->slave_address; >> > + client.flags = 0; > I'm not sure if this is the correct way to use struct i2c_client > (allocating it from stack and

Re: [Resend Patch 7/9] I2C/ACPI: Add i2c ACPI operation region support

2014-04-22 Thread Mika Westerberg
On Tue, Apr 22, 2014 at 02:24:13PM +0800, Lan Tianyu wrote: > diff --git a/drivers/i2c/i2c-acpi.c b/drivers/i2c/i2c-acpi.c > new file mode 100644 > index 000..942abdf > --- /dev/null > +++ b/drivers/i2c/i2c-acpi.c > @@ -0,0 +1,282 @@ > +/* > + * I2C ACPI code > + * > + * Copyright (C) 2014 Inte

[Resend Patch 7/9] I2C/ACPI: Add i2c ACPI operation region support

2014-04-21 Thread Lan Tianyu
ACPI 5.0 spec(5.5.2.4.5) defines GenericSerialBus(i2c, spi, uart) operation region. It allows ACPI aml code able to access such kind of devices to implement some ACPI standard method. ACPI Spec defines some access attribute to associate with i2c protocol. AttribQuick R