Re: [V9fs-developer] [PATCH] net/9p: Fix a deadlock case in the virtio transport

2018-07-16 Thread jiangyiwen
On 2018/7/16 21:38, Dominique Martinet wrote: > jiangyiwen wrote on Mon, Jul 16, 2018: >> You're right, this wake up operation should be put after the unlocking, >> I will resend it. In addition, whether I should resend this patch based >> on your 9p-next branch? > > There is a trivial conflict wi

Re: [V9fs-developer] [PATCH] net/9p: Fix a deadlock case in the virtio transport

2018-07-16 Thread Dominique Martinet
jiangyiwen wrote on Mon, Jul 16, 2018: > You're right, this wake up operation should be put after the unlocking, > I will resend it. In addition, whether I should resend this patch based > on your 9p-next branch? There is a trivial conflict with Thomas' validate PDU length patch, but as it is triv

Re: [V9fs-developer] [PATCH] net/9p: Fix a deadlock case in the virtio transport

2018-07-15 Thread jiangyiwen
On 2018/7/14 20:47, Dominique Martinet wrote: > jiangyiwen wrote on Sat, Jul 14, 2018: >> On 2018/7/14 17:05, Dominique Martinet wrote: >>> jiangyiwen wrote on Sat, Jul 14, 2018: When client has multiple threads that issue io requests all the time, and the server has a very good performan

Re: [V9fs-developer] [PATCH] net/9p: Fix a deadlock case in the virtio transport

2018-07-14 Thread Dominique Martinet
jiangyiwen wrote on Sat, Jul 14, 2018: > On 2018/7/14 17:05, Dominique Martinet wrote: > > jiangyiwen wrote on Sat, Jul 14, 2018: > >> When client has multiple threads that issue io requests all the > >> time, and the server has a very good performance, it may cause > >> cpu is running in the irq c

Re: [V9fs-developer] [PATCH] net/9p: Fix a deadlock case in the virtio transport

2018-07-14 Thread jiangyiwen
On 2018/7/14 17:05, Dominique Martinet wrote: > jiangyiwen wrote on Sat, Jul 14, 2018: >> When client has multiple threads that issue io requests all the >> time, and the server has a very good performance, it may cause >> cpu is running in the irq context for a long time because it can >> check vi

Re: [V9fs-developer] [PATCH] net/9p: Fix a deadlock case in the virtio transport

2018-07-14 Thread Dominique Martinet
jiangyiwen wrote on Sat, Jul 14, 2018: > When client has multiple threads that issue io requests all the > time, and the server has a very good performance, it may cause > cpu is running in the irq context for a long time because it can > check virtqueue has buf in the *while* loop. > > So we shou

[V9fs-developer] [PATCH] net/9p: Fix a deadlock case in the virtio transport

2018-07-14 Thread jiangyiwen
When client has multiple threads that issue io requests all the time, and the server has a very good performance, it may cause cpu is running in the irq context for a long time because it can check virtqueue has buf in the *while* loop. So we should keep chan->lock in the whole loop. Signed-off-b