Re: [Xen-devel] [PATCH V3 2/8] xen: Delay remapping memory of pv-domain

2014-11-14 Thread David Vrabel
On 14/11/14 04:53, Juergen Gross wrote: > > Using BUG() instead would make the code less complex. Do you really > think xen_update_mem_tables() would ever fail in a sane system? > > - set_phys_to_machine() would fail only on a memory shortage. Just > going on without adding more memory wouldn't

Re: [Xen-devel] [PATCH V3 2/8] xen: Delay remapping memory of pv-domain

2014-11-11 Thread Juergen Gross
On 11/11/2014 12:45 PM, Andrew Cooper wrote: On 11/11/14 05:43, Juergen Gross wrote: diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c index fa75842..f67f8cf 100644 --- a/arch/x86/xen/p2m.c +++ b/arch/x86/xen/p2m.c @@ -268,6 +271,22 @@ static void p2m_init(unsigned long *p2m)

Re: [Xen-devel] [PATCH V3 2/8] xen: Delay remapping memory of pv-domain

2014-11-11 Thread Andrew Cooper
On 11/11/14 05:43, Juergen Gross wrote: > diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c > index fa75842..f67f8cf 100644 > --- a/arch/x86/xen/p2m.c > +++ b/arch/x86/xen/p2m.c > @@ -268,6 +271,22 @@ static void p2m_init(unsigned long *p2m) > p2m[i] = INVALID_P2M_ENTRY; > } > >