Re: [alsa-devel] [PATCH] ASoC: codecs: Add DA9055 codec driver

2012-09-13 Thread Mark Brown
On Thu, Sep 13, 2012 at 05:38:36PM +0530, Ashish Chavan wrote: > On Wed, 2012-09-12 at 10:57 +0800, Mark Brown wrote: > > > + aif_ctrl |= (DA9055_AIF_OE | DA9055_AIF_EN); > > DAPM. > Here the trouble in making it DAPM based is that there is no separate > control for AIF input and output. It is c

Re: [alsa-devel] [PATCH] ASoC: codecs: Add DA9055 codec driver

2012-09-13 Thread Ashish Chavan
On Wed, 2012-09-12 at 10:57 +0800, Mark Brown wrote: > > > + aif_ctrl |= (DA9055_AIF_OE | DA9055_AIF_EN); > > DAPM. Here the trouble in making it DAPM based is that there is no separate control for AIF input and output. It is confirmed that AIF_EN is the master control bit, which enables both

RE: [alsa-devel] [PATCH] ASoC: codecs: Add DA9055 codec driver

2012-09-12 Thread Ashish P. Chavan
FYI. -Original Message- From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] Sent: Wednesday, September 12, 2012 6:20 PM To: Ashish P. Chavan Cc: lrg; alsa-devel; linux-kernel; David Dajun Chen Subject: Re: [alsa-devel] [PATCH] ASoC: codecs: Add DA9055 codec driver On Wed, Sep

Re: [alsa-devel] [PATCH] ASoC: codecs: Add DA9055 codec driver

2012-09-12 Thread Mark Brown
On Wed, Sep 12, 2012 at 06:26:18PM +0530, Ashish Chavan wrote: > On Wed, 2012-09-12 at 10:57 +0800, Mark Brown wrote: > > Why is any of this being exposed to userspace? If this should be > > configured I'd expect it to be static platform data, not something that > > gets changed at runtime. > Th

Re: [alsa-devel] [PATCH] ASoC: codecs: Add DA9055 codec driver

2012-09-12 Thread Ashish Chavan
On Wed, 2012-09-12 at 10:57 +0800, Mark Brown wrote: > > +/* Digital MIC clock rate select */ > > +static const char * const da9055_dmic_clk_rate_txt[] = { > > + "3MHz", "1.5MHz" > > +}; > > + > > +static const struct soc_enum da9055_dmic_clk_rate = > > + SOC_ENUM_SINGLE(DA9055_MIC_CONFIG, 2, 2

Re: [alsa-devel] [PATCH] ASoC: codecs: Add DA9055 codec driver

2012-09-11 Thread Mark Brown
On Tue, Sep 11, 2012 at 08:33:43PM +0530, Ashish Chavan wrote: > +/* LDO voltage level value */ > +static const char * const da9055_ldo_lvl_select_txt[] = { > + "1.05V", "1.1V", "1.2V", "1.4V" > +}; > +static const struct soc_enum da9055_ldo_lvl_select = > + SOC_ENUM_SINGLE(DA9055_LDO_CTR

[alsa-devel] [PATCH] ASoC: codecs: Add DA9055 codec driver

2012-09-11 Thread Ashish Chavan
This patch adds support for Dialog semiconductor's DA9055 audio codec. This has been tested on DA9055 EVB with Samsung SMDK6410 board. Signed-off-by: Ashish Chavan Signed-off-by: David Dajun Chen --- sound/soc/codecs/Kconfig |4 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/da905