Re: [alsa-devel] [PATCH v2 2/2] ALSA: au88x0: pr_* replaced with dev_*

2014-10-16 Thread Sudip Mukherjee
On Thu, Oct 16, 2014 at 03:45:44PM +0200, Takashi Iwai wrote: > At Thu, 16 Oct 2014 11:04:34 +0800, > Raymond Yau wrote: > > > > since these 2 commits: > > > > > > > > commit e28d713704117bca0820c732210df6075b09f13b > > > > Author: Linus Torvalds > > > > Date: Tue Jun 16 11:02:28 2009 -0700 > >

Re: [alsa-devel] [PATCH v2 2/2] ALSA: au88x0: pr_* replaced with dev_*

2014-10-16 Thread Takashi Iwai
At Thu, 16 Oct 2014 11:04:34 +0800, Raymond Yau wrote: > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > > > > > > > > > > > > > > > static int vortex_core_init(vortex_t *vortex) > > > > > > > > { > > > > > > > > > > > > > > > > - pr_info( "Vortex: init "); > > > > > > >

Re: [alsa-devel] [PATCH v2 2/2] ALSA: au88x0: pr_* replaced with dev_*

2014-10-11 Thread Sudip Mukherjee
On Sat, Oct 11, 2014 at 08:32:49AM -0700, Joe Perches wrote: > On Sat, 2014-10-11 at 17:03 +0530, Sudip Mukherjee wrote: > > On Sat, Oct 11, 2014 at 03:48:11AM -0700, Joe Perches wrote: > > > On Sat, 2014-10-11 at 14:39 +0530, Sudip Mukherjee wrote: > > > > On Sat, Oct 11, 2014 at 03:20:56PM +0800,

Re: [alsa-devel] [PATCH v2 2/2] ALSA: au88x0: pr_* replaced with dev_*

2014-10-11 Thread Joe Perches
On Sat, 2014-10-11 at 23:40 +0530, Sudip Mukherjee wrote: > now in this case what will you suggest - shutdown and done both > terminated by \n or some thing like : "shutdown process started" and then > "shutdown done" I think it doesn't matter one way or another as it's only useful when there'

Re: [alsa-devel] [PATCH v2 2/2] ALSA: au88x0: pr_* replaced with dev_*

2014-10-11 Thread Joe Perches
On Sat, 2014-10-11 at 17:03 +0530, Sudip Mukherjee wrote: > On Sat, Oct 11, 2014 at 03:48:11AM -0700, Joe Perches wrote: > > On Sat, 2014-10-11 at 14:39 +0530, Sudip Mukherjee wrote: > > > On Sat, Oct 11, 2014 at 03:20:56PM +0800, Raymond Yau wrote: > > > > > > > > > > > --- > > > > > > > > > > >

Re: [alsa-devel] [PATCH v2 2/2] ALSA: au88x0: pr_* replaced with dev_*

2014-10-11 Thread Sudip Mukherjee
On Sat, Oct 11, 2014 at 03:48:11AM -0700, Joe Perches wrote: > On Sat, 2014-10-11 at 14:39 +0530, Sudip Mukherjee wrote: > > On Sat, Oct 11, 2014 at 03:20:56PM +0800, Raymond Yau wrote: > > > > > > > > --- > > > > > > > > > > > static int vortex_core_init(vortex_t *vortex) > > > > { > > > > > >

Re: [alsa-devel] [PATCH v2 2/2] ALSA: au88x0: pr_* replaced with dev_*

2014-10-11 Thread Joe Perches
On Sat, 2014-10-11 at 14:39 +0530, Sudip Mukherjee wrote: > On Sat, Oct 11, 2014 at 03:20:56PM +0800, Raymond Yau wrote: > > > > > > pr_* macros replaced with dev_* as they are more preffered over pr_*. > > > each file which had pr_* was reviewed manually and replaced with dev_*. > > > here we have

Re: [alsa-devel] [PATCH v2 2/2] ALSA: au88x0: pr_* replaced with dev_*

2014-10-11 Thread Sudip Mukherjee
On Sat, Oct 11, 2014 at 03:20:56PM +0800, Raymond Yau wrote: > > > > pr_* macros replaced with dev_* as they are more preffered over pr_*. > > each file which had pr_* was reviewed manually and replaced with dev_*. > > here we have actually used the reference of the vortex which was added > > to so