Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

this convention is suggested: PLT_CLK[2:0] - Camera PLT_CLK[3] - Audio Codec PLT_CLK[4] - PLT_CLK[5] - COMMs By the way, would I suggest to use same prefix as provider, i.e. pmc_atom_plt_clk_%d ? I tried this suggestion and it doesn't work unfortunately. It looks like the struct

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

this convention is suggested: PLT_CLK[2:0] - Camera PLT_CLK[3] - Audio Codec PLT_CLK[4] - PLT_CLK[5] - COMMs By the way, would I suggest to use same prefix as provider, i.e. pmc_atom_plt_clk_%d ? I tried this suggestion and it doesn't work unfortunately. It looks like the struct

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On Thu, Dec 22, 2016 at 3:07 AM, Pierre-Louis Bossart wrote: > On 12/21/16 5:05 PM, Stephen Boyd wrote: >>> The name pmc_plt_clk_ follows the data sheet specification, where >>> this convention is suggested: >>> PLT_CLK[2:0] - Camera >>> PLT_CLK[3] -

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On Thu, Dec 22, 2016 at 3:07 AM, Pierre-Louis Bossart wrote: > On 12/21/16 5:05 PM, Stephen Boyd wrote: >>> The name pmc_plt_clk_ follows the data sheet specification, where >>> this convention is suggested: >>> PLT_CLK[2:0] - Camera >>> PLT_CLK[3] - Audio Codec >>> PLT_CLK[4] - >>>

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On 12/21/2016 05:07 PM, Pierre-Louis Bossart wrote: > On 12/21/16 5:05 PM, Stephen Boyd wrote: >> >> Ok, by clkdev design if a device is passed but there isn't a >> match in the lookup table it allows it to match based solely on >> the connection id. Given that the connection id is globally >>

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On 12/21/2016 05:07 PM, Pierre-Louis Bossart wrote: > On 12/21/16 5:05 PM, Stephen Boyd wrote: >> >> Ok, by clkdev design if a device is passed but there isn't a >> match in the lookup table it allows it to match based solely on >> the connection id. Given that the connection id is globally >>

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On 12/21/16 5:05 PM, Stephen Boyd wrote: On 12/19, Pierre-Louis Bossart wrote: On 12/17/16 7:57 AM, Andy Shevchenko wrote: On Sat, Dec 17, 2016 at 3:33 AM, Stephen Boyd wrote: On 12/15, Pierre-Louis Bossart wrote: Clients use devm_clk_get() with a "pmc_plt_clk_"

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On 12/21/16 5:05 PM, Stephen Boyd wrote: On 12/19, Pierre-Louis Bossart wrote: On 12/17/16 7:57 AM, Andy Shevchenko wrote: On Sat, Dec 17, 2016 at 3:33 AM, Stephen Boyd wrote: On 12/15, Pierre-Louis Bossart wrote: Clients use devm_clk_get() with a "pmc_plt_clk_" argument. This is the

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On 12/19, Pierre-Louis Bossart wrote: > On 12/17/16 7:57 AM, Andy Shevchenko wrote: > >On Sat, Dec 17, 2016 at 3:33 AM, Stephen Boyd wrote: > >>On 12/15, Pierre-Louis Bossart wrote: > > > >>>Clients use devm_clk_get() with a "pmc_plt_clk_" > >>>argument. > >> > >>This is the

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On 12/19, Pierre-Louis Bossart wrote: > On 12/17/16 7:57 AM, Andy Shevchenko wrote: > >On Sat, Dec 17, 2016 at 3:33 AM, Stephen Boyd wrote: > >>On 12/15, Pierre-Louis Bossart wrote: > > > >>>Clients use devm_clk_get() with a "pmc_plt_clk_" > >>>argument. > >> > >>This is the problem. Clients

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On 12/17/16 7:57 AM, Andy Shevchenko wrote: On Sat, Dec 17, 2016 at 3:33 AM, Stephen Boyd wrote: On 12/15, Pierre-Louis Bossart wrote: Clients use devm_clk_get() with a "pmc_plt_clk_" argument. This is the problem. Clients should be calling clk_get() like:

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On 12/17/16 7:57 AM, Andy Shevchenko wrote: On Sat, Dec 17, 2016 at 3:33 AM, Stephen Boyd wrote: On 12/15, Pierre-Louis Bossart wrote: Clients use devm_clk_get() with a "pmc_plt_clk_" argument. This is the problem. Clients should be calling clk_get() like: clk_get(dev, "signal

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On Sat, Dec 17, 2016 at 3:33 AM, Stephen Boyd wrote: > On 12/15, Pierre-Louis Bossart wrote: >>Clients use devm_clk_get() with a "pmc_plt_clk_" >> argument. > > This is the problem. Clients should be calling clk_get() like: > > clk_get(dev, "signal name in

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On Sat, Dec 17, 2016 at 3:33 AM, Stephen Boyd wrote: > On 12/15, Pierre-Louis Bossart wrote: >>Clients use devm_clk_get() with a "pmc_plt_clk_" >> argument. > > This is the problem. Clients should be calling clk_get() like: > > clk_get(dev, "signal name in datasheet") > > where the first

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On 12/15, Pierre-Louis Bossart wrote: > I am not sure I understand this last comment. > init.name is not a constant, it's made of the "pmc_plt_clk_" string > concatenated with an id which directly maps to which hardware clock > is registered. That's all fine. We need globally unique strings for

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On 12/15, Pierre-Louis Bossart wrote: > I am not sure I understand this last comment. > init.name is not a constant, it's made of the "pmc_plt_clk_" string > concatenated with an id which directly maps to which hardware clock > is registered. That's all fine. We need globally unique strings for

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On 12/16/16 2:46 AM, Andy Shevchenko wrote: On Fri, Dec 16, 2016 at 7:15 AM, Pierre-Louis Bossart wrote: Hi Stephen, can you elaborate on the last comment? Please don't do top posting. devm_kasprintf() Please no. That's why I used modal verb

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On 12/16/16 2:46 AM, Andy Shevchenko wrote: On Fri, Dec 16, 2016 at 7:15 AM, Pierre-Louis Bossart wrote: Hi Stephen, can you elaborate on the last comment? Please don't do top posting. devm_kasprintf() Please no. That's why I used modal verb "might" instead of "would". It's all

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On Fri, Dec 16, 2016 at 7:15 AM, Pierre-Louis Bossart wrote: > Hi Stephen, > > can you elaborate on the last comment? Please don't do top posting. >>> devm_kasprintf() >> >> Please no. That's why I used modal verb "might" instead of "would". >> It's all

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

On Fri, Dec 16, 2016 at 7:15 AM, Pierre-Louis Bossart wrote: > Hi Stephen, > > can you elaborate on the last comment? Please don't do top posting. >>> devm_kasprintf() >> >> Please no. That's why I used modal verb "might" instead of "would". >> It's all local to this function, devm isn't

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

Hi Stephen, can you elaborate on the last comment? thanks, -Pierre On 12/13/2016 05:25 PM, Stephen Boyd wrote: + void __iomem *base, + const char **parent_names, + int

Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks

Hi Stephen, can you elaborate on the last comment? thanks, -Pierre On 12/13/2016 05:25 PM, Stephen Boyd wrote: + void __iomem *base, + const char **parent_names, + int