On Sat, 2018-12-22 at 22:53 -0500, Steven Rostedt wrote:
> On Sat, 22 Dec 2018 12:03:41 -0600
> Tom Zanussi wrote:
>
> > Hi Steve,
> >
> > On Sat, 2018-12-22 at 13:01 -0500, Steven Rostedt wrote:
> > > On Sat, 22 Dec 2018 11:20:09 -0500
> > > Steven Rostedt wrote:
> > >
> > > > From:
On Sat, 22 Dec 2018 12:03:41 -0600
Tom Zanussi wrote:
> Hi Steve,
>
> On Sat, 2018-12-22 at 13:01 -0500, Steven Rostedt wrote:
> > On Sat, 22 Dec 2018 11:20:09 -0500
> > Steven Rostedt wrote:
> >
> > > From: "Steven Rostedt (VMware)"
> > >
> > > The tracing histogram code contains a lot
On Sat, Dec 22, 2018 at 11:20:09AM -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)"
>
> The tracing histogram code contains a lot of instances of the construct:
>
> strncmp(str, "const", sizeof("const") - 1)
>
> This can be prone to bugs due to typos or bad cut and paste. Use
Hi Steve,
On Sat, 2018-12-22 at 13:01 -0500, Steven Rostedt wrote:
> On Sat, 22 Dec 2018 11:20:09 -0500
> Steven Rostedt wrote:
>
> > From: "Steven Rostedt (VMware)"
> >
> > The tracing histogram code contains a lot of instances of the
> > construct:
> >
> > strncmp(str, "const",
On Sat, 22 Dec 2018 13:01:07 -0500
Steven Rostedt wrote:
> > Cc: Tom Zanussi
>
> I have no idea why I copied your intel email. The linux.intel.com
> appears to be no longer active. I'm going to rebase to fix this email
> address.
Looking at the other patches, I guess I cut and pasted wrong.
On Sat, 22 Dec 2018 11:20:09 -0500
Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)"
>
> The tracing histogram code contains a lot of instances of the construct:
>
> strncmp(str, "const", sizeof("const") - 1)
>
> This can be prone to bugs due to typos or bad cut and paste. Use the
>
From: "Steven Rostedt (VMware)"
The tracing histogram code contains a lot of instances of the construct:
strncmp(str, "const", sizeof("const") - 1)
This can be prone to bugs due to typos or bad cut and paste. Use the
str_has_prefix() helper macro instead that removes the need for having two
7 matches
Mail list logo