Re: [for-next][PATCH 2/5] tracing: Use str_has_prefix() helper for histogram code

2018-12-23 Thread Tom Zanussi
On Sat, 2018-12-22 at 22:53 -0500, Steven Rostedt wrote: > On Sat, 22 Dec 2018 12:03:41 -0600 > Tom Zanussi wrote: > > > Hi Steve, > > > > On Sat, 2018-12-22 at 13:01 -0500, Steven Rostedt wrote: > > > On Sat, 22 Dec 2018 11:20:09 -0500 > > > Steven Rostedt wrote: > > > > > > > From:

Re: [for-next][PATCH 2/5] tracing: Use str_has_prefix() helper for histogram code

2018-12-22 Thread Steven Rostedt
On Sat, 22 Dec 2018 12:03:41 -0600 Tom Zanussi wrote: > Hi Steve, > > On Sat, 2018-12-22 at 13:01 -0500, Steven Rostedt wrote: > > On Sat, 22 Dec 2018 11:20:09 -0500 > > Steven Rostedt wrote: > > > > > From: "Steven Rostedt (VMware)" > > > > > > The tracing histogram code contains a lot

Re: [for-next][PATCH 2/5] tracing: Use str_has_prefix() helper for histogram code

2018-12-22 Thread Namhyung Kim
On Sat, Dec 22, 2018 at 11:20:09AM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > The tracing histogram code contains a lot of instances of the construct: > > strncmp(str, "const", sizeof("const") - 1) > > This can be prone to bugs due to typos or bad cut and paste. Use

Re: [for-next][PATCH 2/5] tracing: Use str_has_prefix() helper for histogram code

2018-12-22 Thread Tom Zanussi
Hi Steve, On Sat, 2018-12-22 at 13:01 -0500, Steven Rostedt wrote: > On Sat, 22 Dec 2018 11:20:09 -0500 > Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > > The tracing histogram code contains a lot of instances of the > > construct: > > > > strncmp(str, "const",

Re: [for-next][PATCH 2/5] tracing: Use str_has_prefix() helper for histogram code

2018-12-22 Thread Steven Rostedt
On Sat, 22 Dec 2018 13:01:07 -0500 Steven Rostedt wrote: > > Cc: Tom Zanussi > > I have no idea why I copied your intel email. The linux.intel.com > appears to be no longer active. I'm going to rebase to fix this email > address. Looking at the other patches, I guess I cut and pasted wrong.

Re: [for-next][PATCH 2/5] tracing: Use str_has_prefix() helper for histogram code

2018-12-22 Thread Steven Rostedt
On Sat, 22 Dec 2018 11:20:09 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > The tracing histogram code contains a lot of instances of the construct: > > strncmp(str, "const", sizeof("const") - 1) > > This can be prone to bugs due to typos or bad cut and paste. Use the >

[for-next][PATCH 2/5] tracing: Use str_has_prefix() helper for histogram code

2018-12-22 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The tracing histogram code contains a lot of instances of the construct: strncmp(str, "const", sizeof("const") - 1) This can be prone to bugs due to typos or bad cut and paste. Use the str_has_prefix() helper macro instead that removes the need for having two