Re: [net-next PATCH 3/6] macvtap: remove the dead branch

2013-12-06 Thread Guenter Roeck
On Fri, Dec 06, 2013 at 11:46:02AM -0500, David Miller wrote: > From: Guenter Roeck > Date: Thu, 05 Dec 2013 22:08:20 -0800 > > > Assigning the function's return value to ret just to ignore it seems > > odd. > > > > Might make sense to change the function type to void. > > That's exactly what h

Re: [net-next PATCH 3/6] macvtap: remove the dead branch

2013-12-06 Thread David Miller
From: Guenter Roeck Date: Thu, 05 Dec 2013 22:08:20 -0800 > Assigning the function's return value to ret just to ignore it seems > odd. > > Might make sense to change the function type to void. That's exactly what his very next patch does, undoubtedly the two patches should be combined into one

Re: [net-next PATCH 3/6] macvtap: remove the dead branch

2013-12-05 Thread Zhi Yong Wu
On Fri, Dec 6, 2013 at 2:08 PM, Guenter Roeck wrote: > On 12/05/2013 02:28 PM, Zhi Yong Wu wrote: >> >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> --- >> drivers/net/macvtap.c |2 -- >> 1 files changed, 0 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/macvtap.c b/

Re: [net-next PATCH 3/6] macvtap: remove the dead branch

2013-12-05 Thread Guenter Roeck
On 12/05/2013 02:28 PM, Zhi Yong Wu wrote: From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- drivers/net/macvtap.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 9093004..d271fb4 100644 --- a/drivers/net/macvtap.c

[net-next PATCH 3/6] macvtap: remove the dead branch

2013-12-05 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- drivers/net/macvtap.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 9093004..d271fb4 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -779,8 +779,6 @