Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-21 Thread Anton Vorontsov
Hi Ian, Personally I'm very appreciate your patches, they'll will help submitting HP iPaqs SOCs/MFDs, you know... ;-) Thus, much thanks in advance. Few comments... On Wed, Nov 21, 2007 at 03:54:15AM +, ian wrote: > On Wed, 2007-11-21 at 10:23 +0800, eric miao wrote: > > Roughly went

Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-21 Thread Anton Vorontsov
Hi Ian, Personally I'm very appreciate your patches, they'll will help submitting HP iPaqs SOCs/MFDs, you know... ;-) Thus, much thanks in advance. Few comments... On Wed, Nov 21, 2007 at 03:54:15AM +, ian wrote: On Wed, 2007-11-21 at 10:23 +0800, eric miao wrote: Roughly went through

Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-20 Thread eric miao
On Nov 21, 2007 11:54 AM, ian <[EMAIL PROTECTED]> wrote: > On Wed, 2007-11-21 at 10:23 +0800, eric miao wrote: > > Roughly went through the patch, looks good, here comes the remind, though > > :-) > > > > 1. is it possible to use some name other than "soc_core", maybe > > "tmio_core" so that

Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-20 Thread ian
On Wed, 2007-11-21 at 10:23 +0800, eric miao wrote: > Roughly went through the patch, looks good, here comes the remind, though :-) > > 1. is it possible to use some name other than "soc_core", maybe > "tmio_core" so that other multifunction chips sharing a core base > will live easier. It's

Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-20 Thread eric miao
Roughly went through the patch, looks good, here comes the remind, though :-) 1. is it possible to use some name other than "soc_core", maybe "tmio_core" so that other multifunction chips sharing a core base will live easier. 2. those C++ style comments "//" are not so pleasant... - eric On

Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-20 Thread ian
On Wed, 2007-11-21 at 01:04 +0300, Dmitry Baryshkov wrote: > Just to note, that there is an alternative implementation for at least > the tc6393 chip devices. Most current version of those patches can be > found in the OpenEmbedded monotone. Yes, this is true. The core code in both cases

Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-20 Thread Dmitry Baryshkov
Hi, ian wrote: Hi guys. This patchset contains support for three toshiba multifunction devices. Just to note, that there is an alternative implementation for at least the tc6393 chip devices. Most current version of those patches can be found in the OpenEmbedded monotone. it

[patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-20 Thread ian
Hi guys. This patchset contains support for three toshiba multifunction devices. it introduces a small but useful bit of code as a library for similar devices, and includes support for these chips on the toshiba e-series family of handhelds. please copy me on reply! - To unsubscribe from this

[patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-20 Thread ian
Hi guys. This patchset contains support for three toshiba multifunction devices. it introduces a small but useful bit of code as a library for similar devices, and includes support for these chips on the toshiba e-series family of handhelds. please copy me on reply! - To unsubscribe from this

Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-20 Thread Dmitry Baryshkov
Hi, ian wrote: Hi guys. This patchset contains support for three toshiba multifunction devices. Just to note, that there is an alternative implementation for at least the tc6393 chip devices. Most current version of those patches can be found in the OpenEmbedded monotone. it

Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-20 Thread ian
On Wed, 2007-11-21 at 01:04 +0300, Dmitry Baryshkov wrote: Just to note, that there is an alternative implementation for at least the tc6393 chip devices. Most current version of those patches can be found in the OpenEmbedded monotone. Yes, this is true. The core code in both cases

Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-20 Thread eric miao
Roughly went through the patch, looks good, here comes the remind, though :-) 1. is it possible to use some name other than soc_core, maybe tmio_core so that other multifunction chips sharing a core base will live easier. 2. those C++ style comments // are not so pleasant... - eric On Nov 21,

Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-20 Thread ian
On Wed, 2007-11-21 at 10:23 +0800, eric miao wrote: Roughly went through the patch, looks good, here comes the remind, though :-) 1. is it possible to use some name other than soc_core, maybe tmio_core so that other multifunction chips sharing a core base will live easier. It's (soc-core)

Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices

2007-11-20 Thread eric miao
On Nov 21, 2007 11:54 AM, ian [EMAIL PROTECTED] wrote: On Wed, 2007-11-21 at 10:23 +0800, eric miao wrote: Roughly went through the patch, looks good, here comes the remind, though :-) 1. is it possible to use some name other than soc_core, maybe tmio_core so that other multifunction