Re: [patch] scripts: clean-whitespace.sh

2007-06-08 Thread Oleg Verych
On Fri, Jun 08, 2007 at 09:05:54PM +0200, Sam Ravnborg wrote: [] > > > > It does better whitespace cleanup, than > > > > scripts/{cleanfile *and* cleanpatch} > > Made a short test here. > Added the following to a file: > > static sam = ""; > > clean-whitespace replaced spac

Re: [patch] scripts: clean-whitespace.sh

2007-06-08 Thread Sam Ravnborg
On Fri, Jun 08, 2007 at 05:02:15PM +0200, Oleg Verych wrote: > On Fri, Jun 08, 2007 at 04:28:49PM +0200, Sam Ravnborg wrote: > > On Thu, Jun 07, 2007 at 11:44:59PM -0700, Andrew Morton wrote: > > > > > > Then again, it's a better strategy than trying to read the code ;) > > > > > > Please, tell u

Re: [patch] scripts: clean-whitespace.sh

2007-06-08 Thread Oleg Verych
On Fri, Jun 08, 2007 at 04:28:49PM +0200, Sam Ravnborg wrote: > On Thu, Jun 07, 2007 at 11:44:59PM -0700, Andrew Morton wrote: > > > > Then again, it's a better strategy than trying to read the code ;) > > > > Please, tell us what it does, so that we can decide whether we want it in > > Linux. >

Re: [patch] scripts: clean-whitespace.sh

2007-06-08 Thread Sam Ravnborg
On Thu, Jun 07, 2007 at 11:44:59PM -0700, Andrew Morton wrote: > > Then again, it's a better strategy than trying to read the code ;) > > Please, tell us what it does, so that we can decide whether we want it in > Linux. It does the same as cleanfile.pl. I have seen no reason to replace cleanfil

Re: [patch] scripts: clean-whitespace.sh

2007-06-07 Thread Andrew Morton
On Fri, 8 Jun 2007 08:40:42 +0200 Oleg Verych <[EMAIL PROTECTED]> wrote: > After running this script with filename as parameter, > look (with diff) for, what can be corrected. Sorry, but "run it and see what it did" is pretty poor documentation. > Only "*.diff" and "*.patch" files are handled as

[patch] scripts: clean-whitespace.sh

2007-06-07 Thread Oleg Verych
After running this script with filename as parameter, look (with diff) for, what can be corrected. Only "*.diff" and "*.patch" files are handled as patches. Signed-off-by: Oleg Verych <[EMAIL PROTECTED]> -- Two clean rules added, that can change look of damaged lines. Yet script still fits one