Re: [patch 03/18] Dont leak NT bit into next task

2007-02-22 Thread Andi Kleen
On Thursday 22 February 2007 16:29, Adrian Bunk wrote: > On Wed, Feb 21, 2007 at 11:00:15AM +0100, Giuseppe Bilotta wrote: > > On Wednesday 21 February 2007 02:49, Greg KH wrote: > > > > > /* frame pointer must be last for get_wchan */ > > > -#define SAVE_CONTEXT"pushq %%rbp ; movq

Re: [patch 03/18] Dont leak NT bit into next task

2007-02-22 Thread Adrian Bunk
On Wed, Feb 21, 2007 at 11:00:15AM +0100, Giuseppe Bilotta wrote: > On Wednesday 21 February 2007 02:49, Greg KH wrote: > > > /* frame pointer must be last for get_wchan */ > > -#define SAVE_CONTEXT"pushq %%rbp ; movq %%rsi,%%rbp\n\t" > > -#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq

Re: [patch 03/18] Dont leak NT bit into next task

2007-02-22 Thread Adrian Bunk
On Wed, Feb 21, 2007 at 11:00:15AM +0100, Giuseppe Bilotta wrote: On Wednesday 21 February 2007 02:49, Greg KH wrote: /* frame pointer must be last for get_wchan */ -#define SAVE_CONTEXTpushq %%rbp ; movq %%rsi,%%rbp\n\t -#define RESTORE_CONTEXT movq %%rbp,%%rsi ; popq %%rbp\n\t

Re: [patch 03/18] Dont leak NT bit into next task

2007-02-22 Thread Andi Kleen
On Thursday 22 February 2007 16:29, Adrian Bunk wrote: On Wed, Feb 21, 2007 at 11:00:15AM +0100, Giuseppe Bilotta wrote: On Wednesday 21 February 2007 02:49, Greg KH wrote: /* frame pointer must be last for get_wchan */ -#define SAVE_CONTEXTpushq %%rbp ; movq %%rsi,%%rbp\n\t

Re: [patch 03/18] Dont leak NT bit into next task

2007-02-21 Thread Chuck Ebbert
Giuseppe Bilotta wrote: > On Wednesday 21 February 2007 02:49, Greg KH wrote: > >> /* frame pointer must be last for get_wchan */ >> -#define SAVE_CONTEXT"pushq %%rbp ; movq %%rsi,%%rbp\n\t" >> -#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp\n\t" >> +#define SAVE_CONTEXT"pushf ;

Re: [patch 03/18] Dont leak NT bit into next task

2007-02-21 Thread Jan Engelhardt
On Feb 21 2007 11:00, Giuseppe Bilotta wrote: >On Wednesday 21 February 2007 02:49, Greg KH wrote: > >> /* frame pointer must be last for get_wchan */ >> -#define SAVE_CONTEXT"pushq %%rbp ; movq %%rsi,%%rbp\n\t" >> -#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp\n\t" >> +#define

Re: [patch 03/18] Dont leak NT bit into next task

2007-02-21 Thread Giuseppe Bilotta
On Wednesday 21 February 2007 02:49, Greg KH wrote: > /* frame pointer must be last for get_wchan */ > -#define SAVE_CONTEXT"pushq %%rbp ; movq %%rsi,%%rbp\n\t" > -#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp\n\t" > +#define SAVE_CONTEXT"pushf ; pushq %%rbp ; movq

Re: [patch 03/18] Dont leak NT bit into next task

2007-02-21 Thread Giuseppe Bilotta
On Wednesday 21 February 2007 02:49, Greg KH wrote: /* frame pointer must be last for get_wchan */ -#define SAVE_CONTEXTpushq %%rbp ; movq %%rsi,%%rbp\n\t -#define RESTORE_CONTEXT movq %%rbp,%%rsi ; popq %%rbp\n\t +#define SAVE_CONTEXTpushf ; pushq %%rbp ; movq %%rsi,%%rbp\n\t

Re: [patch 03/18] Dont leak NT bit into next task

2007-02-21 Thread Jan Engelhardt
On Feb 21 2007 11:00, Giuseppe Bilotta wrote: On Wednesday 21 February 2007 02:49, Greg KH wrote: /* frame pointer must be last for get_wchan */ -#define SAVE_CONTEXTpushq %%rbp ; movq %%rsi,%%rbp\n\t -#define RESTORE_CONTEXT movq %%rbp,%%rsi ; popq %%rbp\n\t +#define SAVE_CONTEXT

Re: [patch 03/18] Dont leak NT bit into next task

2007-02-21 Thread Chuck Ebbert
Giuseppe Bilotta wrote: On Wednesday 21 February 2007 02:49, Greg KH wrote: /* frame pointer must be last for get_wchan */ -#define SAVE_CONTEXTpushq %%rbp ; movq %%rsi,%%rbp\n\t -#define RESTORE_CONTEXT movq %%rbp,%%rsi ; popq %%rbp\n\t +#define SAVE_CONTEXTpushf ; pushq %%rbp ;

[patch 03/18] Dont leak NT bit into next task

2007-02-20 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Andi Kleen <[EMAIL PROTECTED]> SYSENTER can cause a NT to be set which might cause crashes on the IRET in the next task. Following similar i386 patch from Linus. Signed-off-by: Andi Kleen <[EMAIL

[patch 03/18] Dont leak NT bit into next task

2007-02-20 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Andi Kleen [EMAIL PROTECTED] SYSENTER can cause a NT to be set which might cause crashes on the IRET in the next task. Following similar i386 patch from Linus. Signed-off-by: Andi Kleen [EMAIL