Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-07 Thread Serge E. Hallyn
Quoting Miklos Szeredi ([EMAIL PROTECTED]): > > > > > Maybe sysctls just need to check capabilities, instead of uids. I > > > > > think that would make a lot of sense anyway. > > > > > > > > Would it be as simple as tagging the inodes with capability sets? One > > > > set for writing, or one

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-07 Thread Miklos Szeredi
> On Tue, Feb 05, 2008 at 10:36:23PM +0100, Miklos Szeredi wrote: > > From: Miklos Szeredi <[EMAIL PROTECTED]> > > > > Add the following: > > > > /proc/sys/fs/types/${FS_TYPE}/usermount_safe > > > > > There is /proc/fs// already. Since it is file system specific > shouldn't it go there ?

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-07 Thread Aneesh Kumar K.V
On Tue, Feb 05, 2008 at 10:36:23PM +0100, Miklos Szeredi wrote: > From: Miklos Szeredi <[EMAIL PROTECTED]> > > Add the following: > > /proc/sys/fs/types/${FS_TYPE}/usermount_safe > There is /proc/fs// already. Since it is file system specific shouldn't it go there ? -aneesh -- To

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-07 Thread Miklos Szeredi
> > > > Maybe sysctls just need to check capabilities, instead of uids. I > > > > think that would make a lot of sense anyway. > > > > > > Would it be as simple as tagging the inodes with capability sets? One > > > set for writing, or one each for reading and writing? > > > > Yes, or something

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-07 Thread Serge E. Hallyn
Quoting Miklos Szeredi ([EMAIL PROTECTED]): > > > Maybe sysctls just need to check capabilities, instead of uids. I > > > think that would make a lot of sense anyway. > > > > Would it be as simple as tagging the inodes with capability sets? One > > set for writing, or one each for reading and

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-07 Thread Miklos Szeredi
> > Maybe sysctls just need to check capabilities, instead of uids. I > > think that would make a lot of sense anyway. > > Would it be as simple as tagging the inodes with capability sets? One > set for writing, or one each for reading and writing? Yes, or something even simpler, like mapping

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-02-07 Thread Miklos Szeredi
Maybe sysctls just need to check capabilities, instead of uids. I think that would make a lot of sense anyway. Would it be as simple as tagging the inodes with capability sets? One set for writing, or one each for reading and writing? Yes, or something even simpler, like mapping the

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-02-07 Thread Miklos Szeredi
On Tue, Feb 05, 2008 at 10:36:23PM +0100, Miklos Szeredi wrote: From: Miklos Szeredi [EMAIL PROTECTED] Add the following: /proc/sys/fs/types/${FS_TYPE}/usermount_safe There is /proc/fs/type/ already. Since it is file system specific shouldn't it go there ? The problem is

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-02-07 Thread Serge E. Hallyn
Quoting Miklos Szeredi ([EMAIL PROTECTED]): Maybe sysctls just need to check capabilities, instead of uids. I think that would make a lot of sense anyway. Would it be as simple as tagging the inodes with capability sets? One set for writing, or one each for reading and writing?

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-02-07 Thread Aneesh Kumar K.V
On Tue, Feb 05, 2008 at 10:36:23PM +0100, Miklos Szeredi wrote: From: Miklos Szeredi [EMAIL PROTECTED] Add the following: /proc/sys/fs/types/${FS_TYPE}/usermount_safe There is /proc/fs/type/ already. Since it is file system specific shouldn't it go there ? -aneesh -- To unsubscribe

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-02-07 Thread Serge E. Hallyn
Quoting Miklos Szeredi ([EMAIL PROTECTED]): Maybe sysctls just need to check capabilities, instead of uids. I think that would make a lot of sense anyway. Would it be as simple as tagging the inodes with capability sets? One set for writing, or one each for reading and

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-06 Thread Serge E. Hallyn
Quoting Miklos Szeredi ([EMAIL PROTECTED]): > > > + t->table[0].mode = 0644; > > > > Yikes, this could be a problem for containers, as it's simply tied to > > uid 0, whereas tying it to a capability would let us solve it with > > capability bounds. > > > > This might mean more urgency to get

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-06 Thread Miklos Szeredi
> > + t->table[0].mode = 0644; > > Yikes, this could be a problem for containers, as it's simply tied to > uid 0, whereas tying it to a capability would let us solve it with > capability bounds. > > This might mean more urgency to get user namespaces working at least > with sysfs, else this is

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-06 Thread Serge E. Hallyn
Quoting Miklos Szeredi ([EMAIL PROTECTED]): > From: Miklos Szeredi <[EMAIL PROTECTED]> > > Add the following: > > /proc/sys/fs/types/${FS_TYPE}/usermount_safe > > Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> Thanks, Miklos, good explanations in the docs. Acked-by: Serge Hallyn <[EMAIL

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-02-06 Thread Miklos Szeredi
+ t-table[0].mode = 0644; Yikes, this could be a problem for containers, as it's simply tied to uid 0, whereas tying it to a capability would let us solve it with capability bounds. This might mean more urgency to get user namespaces working at least with sysfs, else this is a quick

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-02-06 Thread Serge E. Hallyn
Quoting Miklos Szeredi ([EMAIL PROTECTED]): + t-table[0].mode = 0644; Yikes, this could be a problem for containers, as it's simply tied to uid 0, whereas tying it to a capability would let us solve it with capability bounds. This might mean more urgency to get user namespaces

[patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-05 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add the following: /proc/sys/fs/types/${FS_TYPE}/usermount_safe Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/filesystems.c === --- linux.orig/fs/filesystems.c

[patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-02-05 Thread Miklos Szeredi
From: Miklos Szeredi [EMAIL PROTECTED] Add the following: /proc/sys/fs/types/${FS_TYPE}/usermount_safe Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/filesystems.c === --- linux.orig/fs/filesystems.c

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-01-22 Thread Serge E. Hallyn
Quoting Miklos Szeredi ([EMAIL PROTECTED]): > > > > What do you think about doing this only if FS_SAFE is also set, > > > > so for instance at first only FUSE would allow itself to be > > > > made user-mountable? > > > > > > > > A safe thing to do, or overly intrusive? > > > > > > It goes

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-01-22 Thread Miklos Szeredi
> > > What do you think about doing this only if FS_SAFE is also set, > > > so for instance at first only FUSE would allow itself to be > > > made user-mountable? > > > > > > A safe thing to do, or overly intrusive? > > > > It goes somewhat against the "no policy in kernel" policy ;). I think >

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-01-22 Thread Serge E. Hallyn
Quoting Miklos Szeredi ([EMAIL PROTECTED]): > > What do you think about doing this only if FS_SAFE is also set, > > so for instance at first only FUSE would allow itself to be > > made user-mountable? > > > > A safe thing to do, or overly intrusive? > > It goes somewhat against the "no policy in

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-01-22 Thread Serge E. Hallyn
Quoting Miklos Szeredi ([EMAIL PROTECTED]): What do you think about doing this only if FS_SAFE is also set, so for instance at first only FUSE would allow itself to be made user-mountable? A safe thing to do, or overly intrusive? It goes somewhat against the no policy in kernel

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-01-22 Thread Miklos Szeredi
What do you think about doing this only if FS_SAFE is also set, so for instance at first only FUSE would allow itself to be made user-mountable? A safe thing to do, or overly intrusive? It goes somewhat against the no policy in kernel policy ;). I think the warning in the

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-01-22 Thread Serge E. Hallyn
Quoting Miklos Szeredi ([EMAIL PROTECTED]): What do you think about doing this only if FS_SAFE is also set, so for instance at first only FUSE would allow itself to be made user-mountable? A safe thing to do, or overly intrusive? It goes somewhat against the no policy

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-01-21 Thread Miklos Szeredi
> What do you think about doing this only if FS_SAFE is also set, > so for instance at first only FUSE would allow itself to be > made user-mountable? > > A safe thing to do, or overly intrusive? It goes somewhat against the "no policy in kernel" policy ;). I think the warning in the

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-01-21 Thread Serge E. Hallyn
Quoting Miklos Szeredi ([EMAIL PROTECTED]): > From: Miklos Szeredi <[EMAIL PROTECTED]> > > Add the following: > > /proc/sys/fs/types/${FS_TYPE}/usermount_safe > > Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> > --- > > Index: linux/fs/filesystems.c >

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-01-21 Thread Serge E. Hallyn
Quoting Miklos Szeredi ([EMAIL PROTECTED]): From: Miklos Szeredi [EMAIL PROTECTED] Add the following: /proc/sys/fs/types/${FS_TYPE}/usermount_safe Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/filesystems.c

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-01-21 Thread Miklos Szeredi
What do you think about doing this only if FS_SAFE is also set, so for instance at first only FUSE would allow itself to be made user-mountable? A safe thing to do, or overly intrusive? It goes somewhat against the no policy in kernel policy ;). I think the warning in the documentation

[patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-01-16 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add the following: /proc/sys/fs/types/${FS_TYPE}/usermount_safe Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/filesystems.c === --- linux.orig/fs/filesystems.c

[patch 07/10] unprivileged mounts: add sysctl tunable for safe property

2008-01-16 Thread Miklos Szeredi
From: Miklos Szeredi [EMAIL PROTECTED] Add the following: /proc/sys/fs/types/${FS_TYPE}/usermount_safe Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/filesystems.c === --- linux.orig/fs/filesystems.c